hw/sd: sd: Bypass the RCA check for CMD13 in SPI mode
PATCH 1/1 hw/sd: sd: Bypass the RCA check for CMD13 in SPI mode
From: Bin Meng <[email protected]>
Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check.
---
Based-on: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=226787
hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
hw/sd/sd.c +2 -1
@@ -1166,8 +1166,9 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)case 13 :/* CMD13: SEND_STATUS */ switch (sd->mode) {case sd_data_transfer_mode: -if (sd->rca != rca) +if (!sd->spi && sd->rca != rca) {return sd_r0; + }return sd_r1;
Signature · 1 line
2.25.1
Hi Bin,
Quoted 4 lines · Bin Meng
From: Bin Meng <[email protected]>
Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check.
Is this for detecting events by polling? From spec v8:
5.7.5 Event Indication Method
5.7.5.1 FX_EVENT (Bit06 of Card Status)
An event indication method is introduced from Version 4.20. Card may use Bit06 of R1 (R1b) response of any SD command to indicate event generation.
F.2 Concept of Event Detection Method
F.2.2 Host Implementation to use Event Detection Method
Quoted 25 lines
Signed-off-by Bin Meng <[email protected]>---
Based-on: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=226787hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)hw/sd/sd.c +2
-1@@ -1166,8 +1166,9 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)case 13 :/* CMD13: SEND_STATUS */ switch (sd->mode) {case sd_data_transfer_mode: -if (sd->rca != rca) +if (!sd->spi && sd->rca != rca) {return sd_r0; + }return sd_r1;
Hi Philippe,
Quoted 14 lines · Philippe Mathieu-Daudé
Hi Bin,
Quoted 4 lines · Bin Meng
From: Bin Meng <[email protected]>
Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check.
Is this for detecting events by polling? From spec v8:
5.7.5 Event Indication Method
5.7.5.1FX_EVENT(Bit06 of Card Status)
Quoted 7 lines
An event indication method is introduced from Version 4.20. Card may use Bit06 of R1 (R1b) response of any SD command to indicate event generation.
F.2 Concept of Event Detection Method
F.2.2 Host Implementation to use Event Detection Method
I think you looked at the wrong place. See spec v8
chapter 7.3.1.3 Detailed Command Description
"The card shall ignore stuff bits and reserved bits in an argument"
and Table 7-3 Commands and Arguments
CMD13 Argument [31:0] stuff bits
Regards,
Bin
Quoted 27 lines · Bin Meng
Hi Philippe,
Quoted 14 lines · Philippe Mathieu-Daudé
Hi Bin,
Quoted 4 lines · Bin Meng
From: Bin Meng <[email protected]>
Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check.
Is this for detecting events by polling? From spec v8:
5.7.5 Event Indication Method
5.7.5.1FX_EVENT(Bit06 of Card Status)Quoted 7 lines
An event indication method is introduced from Version 4.20. Card may use Bit06 of R1 (R1b) response of any SD command to indicate event generation.
F.2 Concept of Event Detection Method
F.2.2 Host Implementation to use Event Detection MethodI think you looked at the wrong place. See spec v8
Quoted 7 lines
chapter 7.3.1.3 Detailed Command Description
"The card shall ignore stuff bits and reserved bits in an argument"
and Table 7-3 Commands and Arguments
CMD13 Argument [31:0] stuff bits
Indeed. Adding this information in the commit description makes things obvious ;)
The SPI responses are not well implemented, in this case (CMD13) it is incorrect, we should return a 2-byte R2. Your patch correctly skip the RCA check, but we still invalid data.
Hi Philippe,
Quoted 31 lines · Philippe Mathieu-Daudé
Quoted 29 lines · Bin Meng
Hi Philippe,
Quoted 14 lines · Philippe Mathieu-Daudé
Hi Bin,
Quoted 4 lines · Bin Meng
From: Bin Meng <[email protected]>
Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check.
Is this for detecting events by polling? From spec v8:
5.7.5 Event Indication Method
5.7.5.1FX_EVENT(Bit06 of Card Status)Quoted 7 lines
An event indication method is introduced from Version 4.20. Card may use Bit06 of R1 (R1b) response of any SD command to indicate event generation.
F.2 Concept of Event Detection Method
F.2.2 Host Implementation to use Event Detection MethodI think you looked at the wrong place. See spec v8
chapter 7.3.1.3 Detailed Command Description
Quoted 8 lines
Quoted 5 lines
"The card shall ignore stuff bits and reserved bits in an argument"
and Table 7-3 Commands and Arguments
CMD13 Argument [31:0] stuff bits
Indeed. Adding this information in the commit description makes things obvious ;)
I thought that's already obvious. If you search for "stuff bits" or "CMD13" in the spec, you will get the information.
Quoted 4 lines
The SPI responses are not well implemented, in this case (CMD13) it is incorrect, we should return a 2-byte R2. Your patch correctly skip the RCA check, but we still invalid data.
This is already handled in ssi-sd.c in SPI mode. As for the SD mode, that should be a separate patch instead of mixing two fixes into one.
Regards,
Bin
Quoted 48 lines · Bin Meng
Hi Philippe,
Quoted 31 lines · Philippe Mathieu-Daudé
Quoted 29 lines · Bin Meng
Hi Philippe,
Quoted 14 lines · Philippe Mathieu-Daudé
Hi Bin,
Quoted 4 lines · Bin Meng
From: Bin Meng <[email protected]>
Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check.
Is this for detecting events by polling? From spec v8:
5.7.5 Event Indication Method
5.7.5.1FX_EVENT(Bit06 of Card Status)Quoted 7 lines
An event indication method is introduced from Version 4.20. Card may use Bit06 of R1 (R1b) response of any SD command to indicate event generation.
F.2 Concept of Event Detection Method
F.2.2 Host Implementation to use Event Detection MethodI think you looked at the wrong place. See spec v8
chapter 7.3.1.3 Detailed Command Description
Quoted 8 lines
Quoted 5 lines
"The card shall ignore stuff bits and reserved bits in an argument"
and Table 7-3 Commands and Arguments
CMD13 Argument [31:0] stuff bits
Indeed. Adding this information in the commit description makes things obvious ;)
I thought that's already obvious. If you search for "stuff bits" or "CMD13" in the spec, you will get the information.
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
The SPI responses are not well implemented, in this case (CMD13) it is incorrect, we should return a 2-byte R2. Your patch correctly skip the RCA check, but we still invalid data.
This is already handled in
ssi-sd.cin SPI mode. As for the SD mode, that should be a separate patch instead of mixing two fixes into one.
Sigh, I should have checked the spec before I replied.
The CMD13 response for SD card is R1. Only SPI mode is R2. As I mentioned SPI mode R2 is already handled in ssi-sd.c, so there is nothing wrong here.
Regards,
Bin