Skip to contentSkip to conversation

4.9.254-rc1 review

PATCH In review Greg Kroah-Hartman 4 participants 9 messages Jan 29, 2021 – Jan 30, 2021

Subsystems (2)
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

cover 4.9.254-rc1 review

This is the start of the stable review cycle for the 4.9.254 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 4.9.254-rc1

Arvind Sankar <[email protected]>
x86/boot/compressed: Disable relocation relaxation

Gaurav Kohli <[email protected]>
tracing: Fix race in trace_open and buffer resize call

Wang Hai <[email protected]>
Revert "mm/slub: fix a memory leak in sysfs_slab_add()"

Dan Carpenter <[email protected]>

    net: dsa: b53: fix an off by one in checking "vlan->vid"

Eric Dumazet <[email protected]>
net_sched: avoid shift-out-of-bounds in tcindex_set_parms()

Matteo Croce <[email protected]>
ipv6: create multicast route with RTPROT_KERNEL

Alexander Lobakin <[email protected]>
skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too

Geert Uytterhoeven <[email protected]>
sh_eth: Fix power down vs. is_opened flag ordering

Necip Fazil Yildiran <[email protected]>
sh: dma: fix kconfig dependency for G2_DMA

Guillaume Nault <[email protected]>
netfilter: rpfilter: mask ecn bits before fib lookup

Will Deacon <[email protected]>
compiler.h: Raise minimum version of GCC to 5.1 for arm64

Daniel Borkmann <[email protected]>
bpf: Fix buggy rsh min/max bounds tracking

JC Kuo <[email protected]>
xhci: tegra: Delay for disabling LFPS detector

Mathias Nyman <[email protected]>
xhci: make sure TRB is fully written before giving it to the controller

Patrik Jakobsson <[email protected]>
usb: bdc: Make bdc pci driver depend on BROKEN

Thinh Nguyen <[email protected]>
usb: udc: core: Use lock when write to soft_connect

Longfang Liu <[email protected]>
USB: ehci: fix an interrupt calltrace error

Eugene Korenevsky <[email protected]>
ehci: fix EHCI host controller initialization sequence

Wang Hui <[email protected]>
stm class: Fix module init return on allocation failure

Lars-Peter Clausen <[email protected]>
iio: ad5504: Fix setting power-down state

Vincent Mailhol <[email protected]>
can: dev: can_restart: fix use after free bug

Wolfram Sang <[email protected]>
i2c: octeon: check correct size of maximum RECV_LEN packet

Ben Skeggs <[email protected]>
drm/nouveau/i2c/gm200: increase width of aux semaphore owner fields

Ben Skeggs <[email protected]>
drm/nouveau/bios: fix issue shadowing expansion ROMs

Can Guo <[email protected]>
scsi: ufs: Correct the LUN used in eh_device_reset_handler() callback

Cezary Rojewski <[email protected]>
ASoC: Intel: haswell: Add missing pm_ops

Hannes Reinecke <[email protected]>
dm: avoid filesystem lookup in dm_get_dev_t()

Hans de Goede <[email protected]>
ACPI: scan: Make acpi_bus_get_device() clear return pointer on error

Takashi Iwai <[email protected]>
ALSA: hda/via: Add minimum mute flag

Takashi Iwai <[email protected]>
ALSA: seq: oss: Fix missing error check in snd_seq_oss_synth_make_info()

-------------

Diffstat:

 Makefile                                           |  4 ++--
 arch/sh/drivers/dma/Kconfig                        |  3 +--
 arch/x86/boot/compressed/Makefile                  |  2 ++
 drivers/acpi/scan.c                                |  2 ++
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c  |  2 +-
 drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c |  8 ++++----
 drivers/hwtracing/stm/heartbeat.c                  |  6 ++++--
 drivers/i2c/busses/i2c-octeon-core.c               |  2 +-
 drivers/iio/dac/ad5504.c                           |  4 ++--
 drivers/md/dm-table.c                              | 15 ++++++++++++---
 drivers/net/can/dev.c                              |  4 ++--
 drivers/net/dsa/b53/b53_common.c                   |  2 +-
 drivers/net/ethernet/renesas/sh_eth.c              |  4 ++--
 drivers/scsi/ufs/ufshcd.c                          | 11 ++++-------
 drivers/usb/gadget/udc/bdc/Kconfig                 |  2 +-
 drivers/usb/gadget/udc/core.c                      | 13 ++++++++++---
 drivers/usb/host/ehci-hcd.c                        | 12 ++++++++++++
 drivers/usb/host/ehci-hub.c                        |  3 +++
 drivers/usb/host/xhci-ring.c                       |  2 ++
 drivers/usb/host/xhci-tegra.c                      |  7 +++++++
 include/linux/compiler-gcc.h                       |  6 ++++++
 kernel/bpf/verifier.c                              |  7 +++----
 kernel/trace/ring_buffer.c                         |  4 ++++
 mm/slub.c                                          |  4 +---
 net/core/skbuff.c                                  |  6 +++++-
 net/ipv4/netfilter/ipt_rpfilter.c                  |  2 +-
 net/ipv6/addrconf.c                                |  1 +
 net/sched/cls_tcindex.c                            |  8 ++++++--
 sound/core/seq/oss/seq_oss_synth.c                 |  3 ++-
 sound/pci/hda/patch_via.c                          |  1 +
 sound/soc/intel/boards/haswell.c                   |  1 +
 31 files changed, 106 insertions(+), 45 deletions(-)
author maintainer
#1 lore raw

PATCH 19/30 bpf: Fix buggy rsh min/max bounds tracking

From: Daniel Borkmann <[email protected]>

[ no upstream commit ]

Fix incorrect bounds tracking for RSH opcode. Commit f23cc643f9ba ("bpf: fix range arithmetic for bpf map access") had a wrong assumption about min/max bounds. The new dst_reg->min_value needs to be derived by right shifting the max_val bounds, not min_val, and likewise new dst_reg->max_value needs to be derived by right shifting the min_val bounds, not max_val. Later stable kernels than 4.9 are not affected since bounds tracking was overall reworked and they already track this similarly as in the fix.

Fixes f23cc643f9ba ("bpf: fix range arithmetic for bpf map access")
Reported-by Ryota Shiga (Flatt Security)
Cc Josef Bacik <[email protected]>
---
 kernel/bpf/verifier.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
kernel/bpf/verifier.c +3 -4
@@ -1732,12 +1732,11 @@ static void adjust_reg_min_max_vals(stru
 		 * unsigned shift, so make the appropriate casts.
 		 */
 		if (min_val < 0 || dst_reg->min_value < 0)
-			dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
+			reset_reg_range_values(regs, insn->dst_reg);
 		else
-			dst_reg->min_value =
-				(u64)(dst_reg->min_value) >> min_val;
+			dst_reg->min_value = (u64)(dst_reg->min_value) >> max_val;
 		if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
-			dst_reg->max_value >>= max_val;
+			dst_reg->max_value >>= min_val;
 		break;
 	default:
 		reset_reg_range_values(regs, insn->dst_reg);
Tested-by on the v1 series
#2 lore raw
In reply to Greg Kroah-Hartman
Quoted 8 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.254 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000. Anything received after that time might be too late.

Build results:

	total: 168 pass: 168 fail: 0
Qemu test results:
	total: 382 pass: 382 fail: 0

Guenter

maintainer Tested-by on the v1 series
#3 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.254 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

All tests passing for Tegra ...

Test results for stable-v4.9:

    8 builds:	8 pass, 0 fail
    16 boots:	16 pass, 0 fail
    30 tests:	30 pass, 0 fail

Linux version: 4.9.254-rc1-g1aa322729224
Boards tested: tegra124-jetson-tk1, tegra20-ventana,

                tegra210-p2371-2180, tegra30-cardhu-a04

Jon

maintainer
#4 lore raw
Quoted 26 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.254 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

All tests passing for Tegra ...

Test results for stable-v4.9:

    8 builds:	8 pass, 0 fail
    16 boots:	16 pass, 0 fail
    30 tests:	30 pass, 0 fail
Quoted 7 lines

Linux version: 4.9.254-rc1-g1aa322729224
Boards tested: tegra124-jetson-tk1, tegra20-ventana,

                tegra210-p2371-2180, tegra30-cardhu-a04

Jon

For some reason I don't appear to be receiving the 'review' request emails. We have a script that checks for them on lore.kernel.org/lkml but I don't seem to find them there either ...

https://lore.kernel.org/lkml/?q=%5BPATCH+4.14+00%2F50%5D+4.14.218-rc1+review

https://lore.kernel.org/lkml/?q=%5BPATCH+4.19+00%2F26%5D+4.19.172-rc1+review

I thought it was our mail server but then I would have thought I would see them on lore. I often see a delay but they usually arrive within a day.

Cheers
Jon
--
nvpublic

author maintainer
#5 lore raw
Quoted 41 lines · Jon Hunter
Quoted 26 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.254 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

All tests passing for Tegra ...

Test results for stable-v4.9:

    8 builds:	8 pass, 0 fail
    16 boots:	16 pass, 0 fail
    30 tests:	30 pass, 0 fail
Quoted 7 lines

Linux version: 4.9.254-rc1-g1aa322729224
Boards tested: tegra124-jetson-tk1, tegra20-ventana,

                tegra210-p2371-2180, tegra30-cardhu-a04

Jon

For some reason I don't appear to be receiving the 'review' request emails. We have a script that checks for them on lore.kernel.org/lkml but I don't seem to find them there either ...

Quoted 6 lines

https://lore.kernel.org/lkml/?q=%5BPATCH+4.14+00%2F50%5D+4.14.218-rc1+review

https://lore.kernel.org/lkml/?q=%5BPATCH+4.19+00%2F26%5D+4.19.172-rc1+review

I thought it was our mail server but then I would have thought I would see them on lore. I often see a delay but they usually arrive within a day.

vger.kernel.org has been having some problems for the past few days in sending messages out, which is why they wouldn't show up in lore as well if they never get sent from the server.

I can add you as a direct cc: to the -rc announcements if you want me to, to prevent this type of thing. Just let me know if you, or anyone else, wants on them.

thanks,

greg k-h

maintainer
#6 lore raw

On 30/01/2021 11:52, Greg Kroah-Hartman wrote:

...

Quoted 7 lines

vger.kernel.org has been having some problems for the past few days in sending messages out, which is why they wouldn't show up in lore as well if they never get sent from the server.

I can add you as a direct cc: to the -rc announcements if you want me to, to prevent this type of thing. Just let me know if you, or anyone else, wants on them.

Yes if you could add me to cc list that would be great.

Thanks Jon

Signature · 1 line
nvpublic
author maintainer
#7 lore raw
Quoted 9 lines · Jon Hunter

On 30/01/2021 11:52, Greg Kroah-Hartman wrote:

...

Quoted 4 lines

vger.kernel.org has been having some problems for the past few days in sending messages out, which is why they wouldn't show up in lore as well if they never get sent from the server.

Quoted 6 lines
Quoted 3 lines

I can add you as a direct cc: to the -rc announcements if you want me to, to prevent this type of thing. Just let me know if you, or anyone else, wants on them.

Yes if you could add me to cc list that would be great.

Now added:

	https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=2be9ba73cf0f6c3926f0d4caea60bb1feb141547

thanks,

greg k-h

Tested-by Linux Kernel Functional Testing on the v1 series
#8 lore raw
In reply to Greg Kroah-Hartman
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.9.254 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sun, 31 Jan 2021 10:59:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.254-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Summary
------------------------------------------------------------------------

kernel: 4.9.254-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.9.y
git commit: 1aa322729224bcf6471557d67a263fb060158de6
git describe: v4.9.253-31-g1aa322729224
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.9.y/build/v4.9.253-31-g1aa322729224

No regressions (compared to build v4.9.253-28-g02d9a5638c82)

No fixes (compared to build v4.9.253-28-g02d9a5638c82)

Ran 40883 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- juno-r2-compat
- juno-r2-kasan
- qemu-arm64-clang
- qemu-arm64-kasan
- qemu-x86_64-clang
- qemu-x86_64-kasan
- qemu_arm
- qemu_arm64
- qemu_arm64-compat
- qemu_i386
- qemu_x86_64
- qemu_x86_64-compat
- x15 - arm
- x86_64
- x86-kasan

Test Suites
-----------
* build
* install-android-platform-tools-r2600
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* perf
* v4l2-compliance
* ltp-cve-tests
* network-basic-tests
* ltp-open-posix-tests
* kvm-unit-tests

Signature · 2 lines
Linaro LKFT
https://lkft.linaro.org