Skip to contentSkip to conversation

kbuild: fix typo in Documentation/kbuild/modules.rst

PATCH NAK Nicolas Bouliane 2 participants 3 messages Jan 30, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: fix typo in Documentation/kbuild/modules.rst

---
 Documentation/kbuild/modules.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/kbuild/modules.rst +3 -3
index a1f3eb7a43e2..44a18bccdd5a 100644
@@ -205,7 +205,7 @@ module 8123.ko, which is built from the following files::
 		KDIR ?= /lib/modules/`uname -r`/build
 
 		default:
-			$(MAKE) -C $(KDIR) M=$$PWD
+			$(MAKE) -C $(KDIR) M=$PWD
 
 		# Module specific targets
 		genbin:
@@ -239,7 +239,7 @@ module 8123.ko, which is built from the following files::
 		KDIR ?= /lib/modules/`uname -r`/build
 
 		default:
-			$(MAKE) -C $(KDIR) M=$$PWD
+			$(MAKE) -C $(KDIR) M=$PWD
 
 		# Module specific targets
 		genbin:
@@ -268,7 +268,7 @@ module 8123.ko, which is built from the following files::
 		KDIR ?= /lib/modules/`uname -r`/build
 
 		default:
-			$(MAKE) -C $(KDIR) M=$$PWD
+			$(MAKE) -C $(KDIR) M=$PWD
 
 		# Module specific targets
 		genbin:
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Nicolas Bouliane

The code is correct.
'$$' is escaped '$', not a typo.

NACK.

Quoted 38 lines
---
 Documentation/kbuild/modules.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/kbuild/modules.rst +3 -4
index a1f3eb7a43e2..44a18bccdd5a 100644
@@ -205,7 +205,7 @@ module 8123.ko, which is built from the following files::
                KDIR ?= /lib/modules/`uname -r`/build
 
                default:
-                       $(MAKE) -C $(KDIR) M=$$PWD
+                       $(MAKE) -C $(KDIR) M=$PWD
 
                # Module specific targets
                genbin:
@@ -239,7 +239,7 @@ module 8123.ko, which is built from the following files::
                KDIR ?= /lib/modules/`uname -r`/build
 
                default:
-                       $(MAKE) -C $(KDIR) M=$$PWD
+                       $(MAKE) -C $(KDIR) M=$PWD
 
                # Module specific targets
                genbin:
@@ -268,7 +268,7 @@ module 8123.ko, which is built from the following files::
                KDIR ?= /lib/modules/`uname -r`/build
 
                default:
-                       $(MAKE) -C $(KDIR) M=$$PWD
+                       $(MAKE) -C $(KDIR) M=$PWD
 
                # Module specific targets
                genbin:
--

2.25.1

Signature · 2 lines
Best Regards
Masahiro Yamada