staging: qlge/qlge_ethtool.c: Switch from strlcpy to strscpy
Subsystems (3)
PATCH v2 1/1 staging: qlge/qlge_ethtool.c: Switch from strlcpy to strscpy
strlcpy is marked as deprecated in Documentation/process/deprecated.rst, and there is no functional difference when the caller expects truncation (when not checking the return value). strscpy is relatively better as it also avoids scanning the whole source string.
This silences the related checkpatch warnings from:5dbdb2d87c29 ("checkpatch: prefer strscpy to strlcpy")
Signed-off-by Kumar Kartikeya Dwivedi <[email protected]>
--- drivers/staging/qlge/qlge_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/qlge/qlge_ethtool.c +3 -3
@@ -417,15 +417,15 @@ static void ql_get_drvinfo(struct net_device *ndev, {struct ql_adapter *qdev =netdev_priv (ndev); -strlcpy (drvinfo->driver, qlge_driver_name,sizeof (drvinfo->driver)); -strlcpy (drvinfo->version, qlge_driver_version, +strscpy (drvinfo->driver, qlge_driver_name,sizeof (drvinfo->driver)); +strscpy (drvinfo->version, qlge_driver_version,sizeof (drvinfo->version));snprintf (drvinfo->fw_version,sizeof (drvinfo->fw_version),"v%d.%d.%d" , (qdev->fw_rev_id &0x00ff0000 ) >>16 , (qdev->fw_rev_id &0x0000ff00 ) >>8 , (qdev->fw_rev_id &0x000000ff )); -strlcpy (drvinfo->bus_info,pci_name (qdev->pdev), +strscpy (drvinfo->bus_info,pci_name (qdev->pdev),sizeof (drvinfo->bus_info)); }
Signature · 1 line
2.29.2