Skip to contentSkip to conversation

arm64: dts: meson-gx: remove wrong reserved BL31 memory

PATCH In review Artem Lapkin 2 participants 2 messages Jan 30, 2021 – Feb 2, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: meson-gx: remove wrong reserved BL31 memory

Kernel boot fail on Khadas VIM1 VIM2 (meson GX) boards
SOLUTION: just remove wrong mem reservation for 0x10000000 0x200000

## Booting kernel from Legacy Image at 08080000 ...

   Image Name:   kernel
   Image Type:   AArch64 Linux Kernel Image (lzma compressed)
   Data Size:    4657736 Bytes = 4.4 MiB

Load Address: 0f080000
Entry Point: 0f080000
Verifying Checksum ... OK
## Flattened Device Tree blob at 08008000
Booting using the fdt blob at 0x8008000
Uncompressing Kernel Image
ERROR: reserving fdt memory region failed (addr=10000000 size=200000)
Loading Device Tree to 000000007bf23000, end 000000007bf2d3ce ... OK

Starting kernel ...

bl31 reboot reason: 0xd
bl31 reboot reason: 0x0
system cmd 1.

---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 ------
 1 file changed, 6 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gx.dtsi +0 -6
index 726b91d3a..71083b89d 100644
@@ -32,12 +32,6 @@ hwrom_reserved: hwrom@0 {
 			no-map;
 		};
 
-		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
-		secmon_reserved: secmon@10000000 {
-			reg = <0x0 0x10000000 0x0 0x200000>;
-			no-map;
-		};
-
 		/* Alternate 3 MiB reserved for ARM Trusted Firmware (BL31) */
 		secmon_reserved_alt: secmon@5000000 {
 			reg = <0x0 0x05000000 0x0 0x300000>;
Signature · 7 lines
2.25.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
maintainer
#1 lore raw
Quoted 2 lines · Artem Lapkin

Kernel boot fail on Khadas VIM1 VIM2 (meson GX) boards
SOLUTION: just remove wrong mem reservation for 0x10000000 0x200000

You don't explain why it's wrong.

This region was added becasue there there are definitely GX devices which have secure memory in this area, and this patch will break those devices.

Quoted 4 lines

## Booting kernel from Legacy Image at 08080000 ...

   Image Name:   kernel
   Image Type:   AArch64 Linux Kernel Image (lzma compressed)
   Data Size:    4657736 Bytes = 4.4 MiB
Quoted 8 lines

Load Address: 0f080000
Entry Point: 0f080000
Verifying Checksum ... OK
## Flattened Device Tree blob at 08008000
Booting using the fdt blob at 0x8008000
Uncompressing Kernel Image
ERROR: reserving fdt memory region failed (addr=10000000 size=200000)
Loading Device Tree to 000000007bf23000, end 000000007bf2d3ce ... OK

I suspect if you change the load addresses used by u-boot to avoid this region, you'll be able to boot just fine.

Kevin

Quoted 30 lines

Starting kernel ...

bl31 reboot reason: 0xd
bl31 reboot reason: 0x0
system cmd 1.

---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 ------
 1 file changed, 6 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gx.dtsi +0 -6
index 726b91d3a..71083b89d 100644
@@ -32,12 +32,6 @@ hwrom_reserved: hwrom@0 {
 			no-map;
 		};
 
-		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
-		secmon_reserved: secmon@10000000 {
-			reg = <0x0 0x10000000 0x0 0x200000>;
-			no-map;
-		};
-
 		/* Alternate 3 MiB reserved for ARM Trusted Firmware (BL31) */
 		secmon_reserved_alt: secmon@5000000 {
 			reg = <0x0 0x05000000 0x0 0x300000>;
Signature · 1 line
2.25.1

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic