iommu/vt-d: Fix compile error [-Werror=implicit-function-declaration]
Subsystems (3)
Lu Baolu
maintainerPATCH 1/1 iommu/vt-d: Fix compile error [-Werror=implicit-function-declaration]
trace_qi_submit() could be used when interrupt remapping is supported, but DMA remapping is not. In this case, the following compile error occurs.
../drivers/iommu/intel/dmar.c: In function 'qi_submit_sync':../drivers/iommu/intel/dmar.c:1311:3: error: implicit declaration of function 'trace_qi_submit';
did you mean 'ftrace_nmi_exit'? [-Werror=implicit-function-declaration]
trace_qi_submit(iommu, desc[i].qw0, desc[i].qw1,
^~~~~~~~~~~~~~~
ftrace_nmi_exit
--- drivers/iommu/intel/Makefile | 2 +- drivers/iommu/intel/iommu.c | 1 - include/trace/events/intel_iommu.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-)
drivers/iommu/intel/Makefile +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DMAR_TABLE) += dmar.o obj-$(CONFIG_INTEL_IOMMU) += iommu.o pasid.o -obj-$(CONFIG_INTEL_IOMMU) += trace.o +obj-$(CONFIG_DMAR_TABLE) += trace.o obj-$(CONFIG_INTEL_IOMMU_DEBUGFS) += debugfs.o obj-$(CONFIG_INTEL_IOMMU_SVM) += svm.o obj-$(CONFIG_IRQ_REMAP) += irq_remapping.o
drivers/iommu/intel/iommu.c +0 -1
@@ -44,7 +44,6 @@#include <asm/irq_remapping.h> #include <asm/cacheflush.h> #include <asm/iommu.h> -#include <trace/events/intel_iommu.h> #include "../irq_remapping.h" #include "pasid.h"
include/trace/events/intel_iommu.h +0 -2
@@ -6,7 +6,6 @@* * Author: Lu Baolu <[email protected]> */ -#ifdef CONFIG_INTEL_IOMMU #undef TRACE_SYSTEM#define TRACE_SYSTEM intel_iommu
@@ -176,4 +175,3 @@ TRACE_EVENT(qi_submit,/* This part must be outside protection */ #include <trace/define_trace.h> -#endif /* CONFIG_INTEL_IOMMU */
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 15 lines · Lu Baolu
trace_qi_submit()could be used when interrupt remapping is supported, but DMA remapping is not. In this case, the following compile error occurs.
../drivers/iommu/intel/dmar.c: In function 'qi_submit_sync':../drivers/iommu/intel/dmar.c:1311:3: error: implicit declaration of function 'trace_qi_submit';
did you mean 'ftrace_nmi_exit'? [-Werror=implicit-function-declaration]
trace_qi_submit(iommu, desc[i].qw0, desc[i].qw1,
^~~~~~~~~~~~~~~
ftrace_nmi_exitFixes f2dd871799ba5 ("iommu/vt-d: Add qi_submit trace event")Reported-by kernel test robot <[email protected]>Reported-by Randy Dunlap <[email protected]>Signed-off-by Lu Baolu <[email protected]>
Quoted 5 lines
--- drivers/iommu/intel/Makefile | 2 +- drivers/iommu/intel/iommu.c | 1 - include/trace/events/intel_iommu.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-)
Thanks.
Signature · 6 lines
~Randy _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Joerg Roedel
maintainerQuoted 4 lines · Lu Baolu
drivers/iommu/intel/Makefile | 2 +- drivers/iommu/intel/iommu.c | 1 - include/trace/events/intel_iommu.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu