Skip to contentSkip to conversation

powerpc/Kconfig: Fix unmet direct dependency on NET

PATCH In review Florian Fainelli 2 participants 3 messages Jan 30, 2021 – Feb 5, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 powerpc/Kconfig: Fix unmet direct dependency on NET

The kbuild test robot was able to generate a configuration where ETHERNET and NETDEVICES was selected by the Akenobo platform but not NET, which resulted in various build failures and these Kconfig warnings:

WARNING: unmet direct dependencies detected for NETDEVICES
Depends on [n]: NET [=n]
Selected by [y]:
- AKEBONO [=y] && PPC_47x [=y]

WARNING: unmet direct dependencies detected for ETHERNET
Depends on [n]: NETDEVICES [=y] && NET [=n] Selected by [y]:
- AKEBONO [=y] && PPC_47x [=y]

---
 arch/powerpc/platforms/44x/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/44x/Kconfig +1 -0
index 78ac6d67a935..68bd647c878f 100644
@@ -206,6 +206,7 @@ config AKEBONO
 	select PPC4xx_HSTA_MSI
 	select I2C
 	select I2C_IBM_IIC
+	select NET
 	select NETDEVICES
 	select ETHERNET
 	select NET_VENDOR_IBM
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m

It is currently possible to build CONFIG_HW_RANDOM_PPC4XX=y with CONFIG_HW_RANDOM=m which would lead to the inability of linking with devm_hwrng_{register,unregister}. We cannot have the framework modular and the consumer of that framework built-in, so make that dependency explicit.

---
 drivers/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/Kconfig +1 -1
index e535f28a8028..c833ac08ea81 100644
@@ -348,7 +348,7 @@ config CRYPTO_DEV_PPC4XX
 
 config HW_RANDOM_PPC4XX
 	bool "PowerPC 4xx generic true random number generator support"
-	depends on CRYPTO_DEV_PPC4XX && HW_RANDOM
+	depends on CRYPTO_DEV_PPC4XX && HW_RANDOM=y
 	default y
 	help
 	 This option provides the kernel-side support for the TRNG hardware
Signature · 1 line
2.25.1
maintainer
#2 lore raw

Re: [PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m

Quoted 11 lines · Florian Fainelli

It is currently possible to build CONFIG_HW_RANDOM_PPC4XX=y with CONFIG_HW_RANDOM=m which would lead to the inability of linking with devm_hwrng_{register,unregister}. We cannot have the framework modular and the consumer of that framework built-in, so make that dependency explicit.

---
 drivers/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt