Skip to contentSkip to conversation

package/libgeos: depends on wchar

PATCH New Fabrice Fontaine 2 participants 2 messages Jan 31, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libgeos: depends on wchar

libgeos unconditionally uses wstring which raises the following build failure:

In file included from /srv/storage/autobuild/run/instance-3/output-1/build/libgeos-3.9.0/tools/astyle/ASLocalizer.cpp:40:
/srv/storage/autobuild/run/instance-3/output-1/build/libgeos-3.9.0/tools/astyle/ASLocalizer.h:72:34: error: 'wstring' does not name a type; did you mean 'stdin'?

  string convertToMultiByte(const wstring& wideStr) const;
                                  ^~~~~~~
                                  stdin

Fixes:
- http://autobuild.buildroot.org/results/e97d03848d9bbf1845b994f391679a1dbf49f61e

---
 package/libgeos/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/libgeos/Config.in +3 -2
index 224c30c2ad..9f02c8b13f 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBGEOS
 	bool "libgeos"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR
 	help
 	  GEOS (Geometry Engine - Open Source) is a C++ port of the
 	  JTS Topology Suite (JTS). It aims to contain the complete
@@ -10,5 +11,5 @@ config BR2_PACKAGE_LIBGEOS
 
 	  https://trac.osgeo.org/geos
 
-comment "libgeos needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "libgeos needs a toolchain w/ C++, wchar"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/libgeos: depends on wchar

Hello Fabrice,

Quoted 9 lines · On Sun, 31 Jan 2021 20:47:22 +0100 Fabrice Fontaine…

libgeos unconditionally uses wstring which raises the following build failure:

In file included from /srv/storage/autobuild/run/instance-3/output-1/build/libgeos-3.9.0/tools/astyle/ASLocalizer.cpp:40:
/srv/storage/autobuild/run/instance-3/output-1/build/libgeos-3.9.0/tools/astyle/ASLocalizer.h:72:34: error: 'wstring' does not name a type; did you mean 'stdin'?

  string convertToMultiByte(const wstring& wideStr) const;
                                  ^~~~~~~
                                  stdin
Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/e97d03848d9bbf1845b994f391679a1dbf49f61e

---
 package/libgeos/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks. However, as usual it would be good to provide more details about since when the problem occurs. Is it since the package has been introduced ? Since a version bump ?

Of course, in this case, the package has been recently introduced so you can say "it's trivial". But it means that the maintainer reviewing your patch has to look this up, and once again Peter will have to look it up when he looks at your commit and considers it for the LTS/stable branches.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com