drm/panel: simple: add SGD GKTW70SDAD1SD
Subsystems (3)
PATCH v2 1/1 drm/panel: simple: add SGD GKTW70SDAD1SD
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf
---
v2:
- changed bpc to 6
- set max value of pixelclock
- increased hfront_porch and hback_porch
- dropped connector-type
adding of bus_format = MEDIA_BUS_FMT_RGB666_1X18 results in wrong colors. omitting bus_format and using some default is good (Tux Pinguin is colored fine)
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +25 -0
@@ -3336,6 +3336,28 @@ static const struct panel_desc satoz_sat050at40h12r2 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, }; +static const struct display_timing sgd_gktw70sdad1sd_timing = { + .pixelclock = {30000000 ,30000000 ,40000000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {40 ,40 ,40 }, + .hback_porch = {40 ,40 ,40 }, + .hsync_len = {48 ,48 ,48 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {13 ,13 ,13 }, + .vback_porch = {29 ,29 ,29 }, + .vsync_len = {3 ,3 ,3 }, +}; + +static const struct panel_desc sgd_gktw70sdad1sd = { + .timings = &sgd_gktw70sdad1sd_timing, + .num_timings =1 , + .bpc =6 , + .size = { + .width =153 , + .height =86 , + }, +}; +static const struct drm_display_mode sharp_ld_d5116z01b_mode = { .clock =168480 , .hdisplay =1920 ,
@@ -4222,6 +4244,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "satoz,sat050at40h12r2", .data = &satoz_sat050at40h12r2, }, { + .compatible = "sgd,gktw70sdad1sd", + .data = &sgd_gktw70sdad1sd, + }, { .compatible = "sharp,ld-d5116z01b", .data = &sharp_ld_d5116z01b, }, {
Signature · 1 line
2.7.4
Hi Oliver,
thanks for the patch :)
Quoted 33 lines · Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdfSigned-off-by Oliver Graute <[email protected]>Cc Marco Felsch <[email protected]>Cc Fabio Estevam <[email protected]>---
v2:
- changed bpc to 6
- set max value of pixelclock
- increasedhfront_porchandhback_porch
- dropped connector-typeadding of
bus_format=MEDIA_BUS_FMT_RGB666_1X18results in wrong colors. omittingbus_formatand using some default is good (Tux Pinguin is colored fine)drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -3336,6 +3336,28 @@ static const struct panel_desc satoz_sat050at40h12r2 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, };
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc satoz_sat050at40h12r2 = { · line 3348
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+static const struct display_timing sgd_gktw70sdad1sd_timing = { + .pixelclock = {30000000 ,30000000 ,40000000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {40 ,40 ,40 }, + .hback_porch = {40 ,40 ,40 }, + .hsync_len = {48 ,48 ,48 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {13 ,13 ,13 }, + .vback_porch = {29 ,29 ,29 }, + .vsync_len = {3 ,3 ,3 },
Please add also:
.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_NEGEDGE,
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc satoz_sat050at40h12r2 = { · line 3358
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+}; + +static const struct panel_desc sgd_gktw70sdad1sd = { + .timings = &sgd_gktw70sdad1sd_timing, + .num_timings =1 , + .bpc =6 , + .size = { + .width =153 , + .height =86 , + },
and:
.delay = {
.prepare = 20 + 20 + 10 + 10, /* T0 + T2 + T3 + T4 */
.enable = 50, /* T5 */
.disable = 50, /* T5 */
.unprepare = 10 + 10 + 20 + 20, /* T4 + T3 + T2 + T0 */
};Regards,
Marco
Quoted 20 lines
drivers/gpu/drm/panel/panel-simple.c +2
-0+}; +static const struct drm_display_mode sharp_ld_d5116z01b_mode = { .clock =168480 ,drivers/gpu/drm/panel/panel-simple.c +3
-0.hdisplay = 1920,@@ -4222,6 +4244,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "satoz,sat050at40h12r2", .data = &satoz_sat050at40h12r2, }, { + .compatible = "sgd,gktw70sdad1sd", + .data = &sgd_gktw70sdad1sd, + }, { .compatible = "sharp,ld-d5116z01b", .data = &sharp_ld_d5116z01b, }, {Signature · 1 line
2.7.4
Signature · 8 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 51 lines · Marco Felsch
Hi Oliver,
thanks for the patch :)
Quoted 33 lines · Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdfSigned-off-by Oliver Graute <[email protected]>Cc Marco Felsch <[email protected]>Cc Fabio Estevam <[email protected]>---
v2:
- changed bpc to 6
- set max value of pixelclock
- increasedhfront_porchandhback_porch
- dropped connector-typeadding of
bus_format=MEDIA_BUS_FMT_RGB666_1X18results in wrong colors. omittingbus_formatand using some default is good (Tux Pinguin is colored fine)drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -3336,6 +3336,28 @@ static const struct panel_desc satoz_sat050at40h12r2 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, };drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc satoz_sat050at40h12r2 = { · line 3348
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+static const struct display_timing sgd_gktw70sdad1sd_timing = { + .pixelclock = {30000000 ,30000000 ,40000000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {40 ,40 ,40 }, + .hback_porch = {40 ,40 ,40 }, + .hsync_len = {48 ,48 ,48 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {13 ,13 ,13 }, + .vback_porch = {29 ,29 ,29 }, + .vsync_len = {3 ,3 ,3 },Please add also:
Quoted 2 lines
.flags =
DISPLAY_FLAGS_HSYNC_LOW|DISPLAY_FLAGS_VSYNC_LOW|
DISPLAY_FLAGS_DE_HIGH|DISPLAY_FLAGS_PIXDATA_NEGEDGE,
ok will do
Quoted 14 lines
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc satoz_sat050at40h12r2 = { · line 3358
Quoted 11 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+}; + +static const struct panel_desc sgd_gktw70sdad1sd = { + .timings = &sgd_gktw70sdad1sd_timing, + .num_timings =1 , + .bpc =6 , + .size = { + .width =153 , + .height =86 , + },and:
Quoted 6 lines
.delay = {
.prepare = 20 + 20 + 10 + 10, /* T0 + T2 + T3 + T4 */
.enable = 50, /* T5 */
.disable = 50, /* T5 */
.unprepare = 10 + 10 + 20 + 20, /* T4 + T3 + T2 + T0 */
};ok will do
thx for your review.
Best regards,
Oliver