Skip to contentSkip to conversation

examples/vhost: fix potentially overflowing expression

PATCH Superseded Cheng Jiang 2 participants 4 messages Feb 2, 2021 – Feb 3, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/vhost: fix potentially overflowing expression

Change the type of buff_idx from uint64_t to uint32_t to fix coverity issue.

Fixes a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")

Coverity issue: 366264

---
 examples/vhost/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/vhost/main.c +1 -1
index 233a2dc6e..e74fc8750 100644
@@ -864,7 +864,7 @@ static __rte_always_inline void
 drain_vhost(struct vhost_dev *vdev)
 {
 	uint16_t ret;
-	uint64_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
+	uint32_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
 	uint16_t nr_xmit = vhost_txbuff[buff_idx]->len;
 	struct rte_mbuf **m = vhost_txbuff[buff_idx]->m_table;
 
Signature · 1 line
2.29.2
#1 lore raw

PATCH v2 1/1 examples/vhost: fix potentially overflowing expression

Change the type of buff_idx from uint64_t to uint32_t to fix coverity issue.

Coverity issue: 366264

Fixes a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")

---
v2: fixed the format of git log

 examples/vhost/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/vhost/main.c +1 -1
index 233a2dc6e..e74fc8750 100644
@@ -864,7 +864,7 @@ static __rte_always_inline void
 drain_vhost(struct vhost_dev *vdev)
 {
 	uint16_t ret;
-	uint64_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
+	uint32_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
 	uint16_t nr_xmit = vhost_txbuff[buff_idx]->len;
 	struct rte_mbuf **m = vhost_txbuff[buff_idx]->m_table;
 

--
2.29.2

Reviewed-by on v2 1/1
#2 lore raw
Quoted 27 lines · Cheng Jiang

Change the type of buff_idx from uint64_t to uint32_t to fix coverity issue.

Coverity issue: 366264

Fixes a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")

---
v2: fixed the format of git log

 examples/vhost/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/vhost/main.c +1 -2
index 233a2dc6e..e74fc8750 100644
@@ -864,7 +864,7 @@ static __rte_always_inline void
 drain_vhost(struct vhost_dev *vdev)
 {
 	uint16_t ret;
-	uint64_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
+	uint32_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
 	uint16_t nr_xmit = vhost_txbuff[buff_idx]->len;
 	struct rte_mbuf **m = vhost_txbuff[buff_idx]->m_table;
 
--
Quoted 2 lines

2.29.2

Thanks,
Maxime

#3 lore raw
In reply to Cheng Jiang
Quoted 5 lines · Cheng Jiang

|Change the type of buff_idx from uint64_t to uint32_t to fix coverity issue. Coverity issue: 366264 Fixes: a68ba8e0a6b6 ("examples/vhost:
refactor vhost data path") Signed-off-by: Cheng Jiang <[email protected]> --- v2: fixed the format of git log examples/vhost/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)|

Applied to dpdk-next-virtio/main with typo fixed.

Thanks,
Maxime