Skip to contentSkip to conversation

devtools: fix examples external compilation for x86-default

PATCH Applied David Marchand 2 participants 2 messages Feb 2, 2021 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtools: fix examples external compilation for x86-default

Since we don't check ABI on the x86-default target anymore, installation of the target must always happen for examples external compilation check to work.

Fixes 6a426d733ec0 ("devtools: reduce ABI checks and static binaries")
---
 devtools/test-meson-builds.sh | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
devtools/test-meson-builds.sh +1 -4
index a99a177e0c..c11ae87e0d 100755
@@ -276,10 +276,7 @@ done
 load_env cc
 build_path=$(readlink -f $builds_dir/build-x86-default)
 export DESTDIR=$build_path/install
-# No need to reinstall if ABI checks are enabled
-if [ -z "$DPDK_ABI_REF_VERSION" ]; then
-	install_target $build_path $DESTDIR
-fi
+install_target $build_path $DESTDIR
 pc_file=$(find $DESTDIR -name libdpdk.pc)
 export PKG_CONFIG_PATH=$(dirname $pc_file):$PKG_CONFIG_PATH
 libdir=$(dirname $(find $DESTDIR -name librte_eal.so))
Signature · 1 line
2.23.0
Acked-by on v1 1/1 Applied
#1 lore raw

02/02/2021 11:54, David Marchand:

Quoted 3 lines

Since we don't check ABI on the x86-default target anymore, installation of the target must always happen for examples external compilation check to work.

Otherwise the error is:
find: ‘build-x86-default/install’: No such file or directory

Quoted 4 lines
Fixes 6a426d733ec0 ("devtools: reduce ABI checks and static binaries")

Applied, thanks