Skip to contentSkip to conversation

net: ipa: set error code in gsi_channel_setup()

PATCH Applied Alex Elder 2 participants 2 messages Feb 4, 2021 – Feb 5, 2021

Subsystems (3)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH v2 1/1 net: ipa: set error code in gsi_channel_setup()

In gsi_channel_setup(), we check to see if the configuration data contains any information about channels that are not supported by the hardware. If one is found, we abort the setup process, but the error code (ret) is not set in this case. Fix this bug.

Fixes 650d1603825d8 ("soc: qcom: ipa: the generic software interface")

---
v2: Added "Fixes" tag.

 drivers/net/ipa/gsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ipa/gsi.c +1 -0
index 34e5f2155d620..b77f5fef7aeca 100644
@@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi)
 		if (!channel->gsi)
 			continue;	/* Ignore uninitialized channels */
 
+		ret = -EINVAL;
 		dev_err(gsi->dev, "channel %u not supported by hardware\n",
 			channel_id - 1);
 		channel_id = gsi->channel_count;
Signature · 1 line
2.20.1
#1 lore raw
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 10 lines · On Wed, 3 Feb 2021 19:06:55 -0600 you wrote:

In gsi_channel_setup(), we check to see if the configuration data contains any information about channels that are not supported by the hardware. If one is found, we abort the setup process, but the error code (ret) is not set in this case. Fix this bug.

Fixes 650d1603825d8 ("soc: qcom: ipa: the generic software interface")

[...]

Here is the summary with links:
- [net,v2] net: ipa: set error code in gsi_channel_setup()

    https://git.kernel.org/netdev/net/c/1d23a56b0296

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html