Skip to contentSkip to conversation

FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree

DISCUSSION Catalin Marinas 2 participants 5 messages Feb 3, 2021 – Feb 4, 2021 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Greg,

Quoted 24 lines · Greg Kroah-Hartman

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
From: Vincenzo Frascino <[email protected]>
Date: Tue, 26 Jan 2021 13:40:56 +0000
Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()

Currently, the __is_lm_address() check just masks out the top 12 bits of the address, but if they are 0, it still yields a true result. This has as a side effect that virt_addr_valid() returns true even for invalid virtual addresses (e.g. 0x0).

Fix the detection checking that it's actually a kernel address starting at PAGE_OFFSET.

Quoted 9 lines
Fixes 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
Cc <[email protected]> # 5.4.x
Cc Will Deacon <[email protected]>

I sent you the 5.4 and 5.10 backports of this patch. There is another fix in this area which I'll send to Linus tonight. It should apply cleanly on 5.4 and 5.10.

Thanks.

Signature · 1 line
Catalin
maintainer
#2 lore raw
Quoted 37 lines · Catalin Marinas

Hi Greg,

Quoted 24 lines · Greg Kroah-Hartman

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
From: Vincenzo Frascino <[email protected]>
Date: Tue, 26 Jan 2021 13:40:56 +0000
Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()

Currently, the __is_lm_address() check just masks out the top 12 bits of the address, but if they are 0, it still yields a true result. This has as a side effect that virt_addr_valid() returns true even for invalid virtual addresses (e.g. 0x0).

Fix the detection checking that it's actually a kernel address starting at PAGE_OFFSET.

Quoted 9 lines
Fixes 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
Cc <[email protected]> # 5.4.x
Cc Will Deacon <[email protected]>
Quoted 3 lines

I sent you the 5.4 and 5.10 backports of this patch. There is another fix in this area which I'll send to Linus tonight. It should apply cleanly on 5.4 and 5.10.

Both now applied. What is the git id of the other fix in Linus's tree?

thanks,

greg k-h

#3 lore raw
Quoted 25 lines · Greg Kroah-Hartman
Quoted 24 lines · Catalin Marinas
Quoted 22 lines · Greg Kroah-Hartman

From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
From: Vincenzo Frascino <[email protected]>
Date: Tue, 26 Jan 2021 13:40:56 +0000
Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()

Currently, the __is_lm_address() check just masks out the top 12 bits of the address, but if they are 0, it still yields a true result. This has as a side effect that virt_addr_valid() returns true even for invalid virtual addresses (e.g. 0x0).

Fix the detection checking that it's actually a kernel address starting at PAGE_OFFSET.

Fixes 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
Cc <[email protected]> # 5.4.x
Cc Will Deacon <[email protected]>
Quoted 5 lines
Quoted 3 lines

I sent you the 5.4 and 5.10 backports of this patch. There is another fix in this area which I'll send to Linus tonight. It should apply cleanly on 5.4 and 5.10.

Both now applied. What is the git id of the other fix in Linus's tree?

Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged addresses to __is_lm_address()").

Signature · 1 line
Catalin
maintainer
#4 lore raw
Quoted 26 lines · Catalin Marinas
Quoted 25 lines · Greg Kroah-Hartman
Quoted 24 lines · Catalin Marinas
Quoted 22 lines · Greg Kroah-Hartman

From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
From: Vincenzo Frascino <[email protected]>
Date: Tue, 26 Jan 2021 13:40:56 +0000
Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()

Currently, the __is_lm_address() check just masks out the top 12 bits of the address, but if they are 0, it still yields a true result. This has as a side effect that virt_addr_valid() returns true even for invalid virtual addresses (e.g. 0x0).

Fix the detection checking that it's actually a kernel address starting at PAGE_OFFSET.

Fixes 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
Cc <[email protected]> # 5.4.x
Cc Will Deacon <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I sent you the 5.4 and 5.10 backports of this patch. There is another fix in this area which I'll send to Linus tonight. It should apply cleanly on 5.4 and 5.10.

Both now applied. What is the git id of the other fix in Linus's tree?

Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged addresses to __is_lm_address()").

Great, grabbed that now too, thanks.

greg k-h

#5 lore raw
Quoted 31 lines · Greg Kroah-Hartman
Quoted 30 lines · Catalin Marinas
Quoted 29 lines · Greg Kroah-Hartman
Quoted 27 lines · Catalin Marinas
Quoted 13 lines · Greg Kroah-Hartman

From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
From: Vincenzo Frascino <[email protected]>
Date: Tue, 26 Jan 2021 13:40:56 +0000
Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()

Currently, the __is_lm_address() check just masks out the top 12 bits of the address, but if they are 0, it still yields a true result. This has as a side effect that virt_addr_valid() returns true even for invalid virtual addresses (e.g. 0x0).

Fix the detection checking that it's actually a kernel address starting at PAGE_OFFSET.

Quoted 9 lines
Fixes 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
Cc <[email protected]> # 5.4.x
Cc Will Deacon <[email protected]>

I sent you the 5.4 and 5.10 backports of this patch. There is another fix in this area which I'll send to Linus tonight. It should apply cleanly on 5.4 and 5.10.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Both now applied. What is the git id of the other fix in Linus's tree?

Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged addresses to __is_lm_address()").

Great, grabbed that now too, thanks.

Thanks Greg.

Signature · 1 line
Catalin