net/mlx5: fix default CQE compression config
PATCH 1/1 net/mlx5: fix default CQE compression config
CQE compression must be enabled by default unless the rxq_cqe_comp_en devarg is set to 0 or FW cannot support CQE compression for some reason. The latest commit that introduced checks for FW capabilities for new CQE zipping formats disables the CQE compression unless the devarg is 1. Revert this logic and enable CQE compression by default again. Please squash this fix with the original commit.
--- drivers/net/mlx5/linux/mlx5_os.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/mlx5/linux/mlx5_os.c +2 -0
@@ -867,6 +867,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, mprq_caps.max_single_wqe_log_num_of_strides; }#endif +/* Rx CQE compression is enabled by default. */ + config->cqe_comp =1 ;#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT if (dv_attr.comp_mask &MLX5DV_CONTEXT_MASK_TUNNEL_OFFLOADS ) { tunnel_en = ((dv_attr.tunnel_offloads_caps &
Signature · 1 line
2.24.1
Quoted 15 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, February 4, 2021 18:07
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; [email protected]; Slava Ovsiienko <[email protected]>
Subject: [PATCH] net/mlx5: fix default CQE compression configCQE compression must be enabled by default unless the
rxq_cqe_comp_endevarg is set to 0 or FW cannot support CQE compression for some reason. The latest commit that introduced checks for FW capabilities for new CQE zipping formats disables the CQE compression unless the devarg is 1. Revert this logic and enable CQE compression by default again. Please squash this fix with the original commit.
Quoted 3 lines
Fixes f5ae0d46b9 ("net/mlx5: check FW miniCQE format capabilities")Signed-off-by Alexander Kozyrev <[email protected]>
Quoted 21 lines
--- drivers/net/mlx5/linux/mlx5_os.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/mlx5/linux/mlx5_os.c +2
-0@@ -867,6 +867,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, mprq_caps.max_single_wqe_log_num_of_strides; }#endif +/* Rx CQE compression is enabled by default. */ + config->cqe_comp =1 ;#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT if (dv_attr.comp_mask &MLX5DV_CONTEXT_MASK_TUNNEL_OFFLOADS ) {
tunnel_en= ((dv_attr.tunnel_offloads_caps &
--
2.24.1
Hi,
Quoted 15 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, February 4, 2021 6:07 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; [email protected]; Slava Ovsiienko <[email protected]>
Subject: [PATCH] net/mlx5: fix default CQE compression configCQE compression must be enabled by default unless the
rxq_cqe_comp_endevarg is set to 0 or FW cannot support CQE compression for some reason. The latest commit that introduced checks for FW capabilities for new CQE zipping formats disables the CQE compression unless the devarg is 1. Revert this logic and enable CQE compression by default again. Please squash this fix with the original commit.
Quoted 4 lines
Fixes f5ae0d46b9 ("net/mlx5: check FW miniCQE format capabilities")Signed-off-by Alexander Kozyrev <[email protected]>---
Patch applied to next-net-mlx,
Ferruh,
Can you kindly squash it into next-net since I see you already pulled the original patch that it fixes
Kindest regards,
Raslan Darawsheh
Quoted 19 lines · Raslan Darawsheh
Hi,
Quoted 17 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, February 4, 2021 6:07 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; [email protected]; Slava Ovsiienko <[email protected]>
Subject: [PATCH] net/mlx5: fix default CQE compression configCQE compression must be enabled by default unless the
rxq_cqe_comp_endevarg is set to 0 or FW cannot support CQE compression for some reason. The latest commit that introduced checks for FW capabilities for new CQE zipping formats disables the CQE compression unless the devarg is 1. Revert this logic and enable CQE compression by default again. Please squash this fix with the original commit.Fixes f5ae0d46b9 ("net/mlx5: check FW miniCQE format capabilities")
Quoted 8 lines
Quoted 2 lines
Signed-off-by Alexander Kozyrev <[email protected]>---
Patch applied to next-net-mlx,
Ferruh,
Can you kindly squash it into next-net since I see you already pulled the original patch that it fixes
sure,
Squashed into relevant commit in next-net, thanks.