drm/panel: simple: add SGD GKTW70SDAD1SD
Subsystems (3)
PATCH v3 1/1 drm/panel: simple: add SGD GKTW70SDAD1SD
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf
---
v3:
- added flags
- added delay
v2:
- changed bpc to 6
- set max value of pixelclock
- increased hfront_porch and hback_porch
- dropped connector-type
adding of bus_format = MEDIA_BUS_FMT_RGB666_1X18 results in wrong colors. omitting bus_format and using some default is better (Tux Pinguin is colored fine)
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +33 -0
@@ -3336,6 +3336,36 @@ static const struct panel_desc satoz_sat050at40h12r2 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, }; +static const struct display_timing sgd_gktw70sdad1sd_timing = { + .pixelclock = {30000000 ,30000000 ,40000000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {40 ,40 ,40 }, + .hback_porch = {40 ,40 ,40 }, + .hsync_len = {48 ,48 ,48 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {13 ,13 ,13 }, + .vback_porch = {29 ,29 ,29 }, + .vsync_len = {3 ,3 ,3 }, + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_NEGEDGE , +}; + +static const struct panel_desc sgd_gktw70sdad1sd = { + .timings = &sgd_gktw70sdad1sd_timing, + .num_timings =1 , + .bpc =6 , + .size = { + .width =153 , + .height =86 , + }, + .delay = { + .prepare =20 +20 +10 +10 , + .enable =50 , + .disable =50 , + .unprepare =10 +10 +20 +20 , + }, +}; +static const struct drm_display_mode sharp_ld_d5116z01b_mode = { .clock =168480 , .hdisplay =1920 ,
@@ -4222,6 +4252,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "satoz,sat050at40h12r2", .data = &satoz_sat050at40h12r2, }, { + .compatible = "sgd,gktw70sdad1sd", + .data = &sgd_gktw70sdad1sd, + }, { .compatible = "sharp,ld-d5116z01b", .data = &sharp_ld_d5116z01b, }, {
Signature · 1 line
2.7.4
Hi Oliver,
Quoted 9 lines · Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdfSigned-off-by Oliver Graute <[email protected]>Cc Marco Felsch <[email protected]>Cc Fabio Estevam <[email protected]>
Quoted 6 lines
---
v3:
- added flags
- added delay
Thanks, did you test the changes?
I just picked it from the datasheet.
Regards,
Marco
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 14 lines · Marco Felsch
Hi Oliver,
Quoted 11 lines · Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdfSigned-off-by Oliver Graute <[email protected]>Cc Marco Felsch <[email protected]>Cc Fabio Estevam <[email protected]>---
Quoted 7 lines
Quoted 4 lines
v3:
- added flags
- added delayThanks, did you test the changes?
I just picked it from the datasheet.
yes, it didn't break anything.
Best regards,
Oliver
Marco Felsch
Reviewed-byQuoted 17 lines · Oliver Graute
Quoted 16 lines · Marco Felsch
Hi Oliver,
Quoted 13 lines · Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple.
The panel spec from Variscite can be found at:
https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdfSigned-off-by Oliver Graute <[email protected]>Cc Marco Felsch <[email protected]>Cc Fabio Estevam <[email protected]>---
v3:
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
- added flags
- added delayThanks, did you test the changes?
I just picked it from the datasheet.yes, it didn't break anything.
Feel free to add my:
PS:
+1 for Fabio's comment ^^
Regards,
Marco
Quoted 5 lines
Best regards,
Oliver
Signature · 8 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Oliver,
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc satoz_sat050at40h12r2 = { · line 3362
Quoted 10 lines · Oliver Graute
drivers/gpu/drm/panel/panel-simple.c +10
-0+static const struct panel_desc sgd_gktw70sdad1sd = { + .timings = &sgd_gktw70sdad1sd_timing, + .num_timings =1 , + .bpc =6 , + .size = { + .width =153 , + .height =86 , + }, + .delay = { + .prepare =20 +20 +10 +10 ,
Adding the datasheet label like Marco suggested make it clearer where these numbers come from : /* T0 + T2 + T3 + T4 */
Glad you got it working on your imx6ul board:
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel