Skip to contentSkip to conversation

tests/kms_vrr: Update condition checks for flipline test

PATCH In review Bhanuprakash Modem 3 participants 4 messages Feb 4, 2021 – Feb 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 tests/kms_vrr: Update condition checks for flipline test

This patch includes below updates
* For Flipline test: if refresh_rate <= Vrr_min then
- Expected returned refresh rate would be vrr_max
- At least 35% of the flips should be in threshold
* Update "igt_display_commit_atomic" with "igt_display_commit2"
* Calculate the target timestamp based on the delta between event timestamps & whatever the time left to reach the expected rate.
* Add few debug prints

V2:
* Rebase
V3:
* Compute the target timestamp based on the delta (Ville) V4:
* Add a comment to justify the result with refresh rate < 40Hz (Manasi) V5:
* Align the starting point with flip completion event (Manasi)

Cc Ville Syrjälä <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
---
 tests/kms_vrr.c | 93 +++++++++++++++++++++----------------------------
 1 file changed, 39 insertions(+), 54 deletions(-)
tests/kms_vrr.c +39 -54
index beb06854f..e4ea74c17 100644
@@ -170,7 +170,7 @@ static void set_vrr_on_pipe(data_t *data, enum pipe pipe, bool enabled)
 {
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED,
 				enabled);
-	igt_display_commit_atomic(&data->display, 0, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Prepare the display for testing on the given pipe. */
@@ -208,22 +208,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 	 */
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, 0);
 
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-}
-
-/* Waits for the vblank interval. Returns the vblank timestamp in ns. */
-static uint64_t
-wait_for_vblank(data_t *data, enum pipe pipe)
-{
-	drmVBlank vbl = {};
-
-	vbl.request.type = kmstest_get_vbl_flag(pipe);
-	vbl.request.type |= DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT;
-	vbl.request.sequence = 1;
-	drmWaitVBlank(data->drm_fd, &vbl);
-
-	return get_kernel_event_ns(data, DRM_EVENT_VBLANK);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Performs an atomic non-blocking page-flip on a pipe. */
@@ -260,17 +245,18 @@ static uint32_t
 flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 uint64_t rate_ns, uint64_t duration_ns)
 {
-	uint64_t start_ns, last_event_ns;
+	uint64_t start_ns, last_event_ns, target_ns;
 	uint32_t total_flip = 0, total_pass = 0;
 	bool front = false;
 	vtest_ns_t vtest_ns = get_test_rate_ns(data, output);
 
-	/* Align with the vblank region to speed up convergence. */
-	last_event_ns = wait_for_vblank(data, pipe);
-	start_ns = get_time_ns();
+	/* Align with the flip completion event to speed up convergence. */
+	do_flip(data, &data->fb0);
+	start_ns = last_event_ns = target_ns = get_kernel_event_ns(data,
+							DRM_EVENT_FLIP_COMPLETE);
 
 	for (;;) {
-		uint64_t now_ns, event_ns, wait_ns, target_ns;
+		uint64_t event_ns, wait_ns;
 		int64_t diff_ns;
 
 		front = !front;
@@ -291,14 +277,10 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 * difference between 144Hz and 143Hz which should give this
 		 * enough accuracy for most use cases.
 		 */
-		if (rate_ns <= vtest_ns.min && rate_ns >= vtest_ns.max)
+		if ((rate_ns < vtest_ns.min) && (rate_ns >= vtest_ns.max))
 			diff_ns = rate_ns;
-		else if (rate_ns > vtest_ns.min)
-			diff_ns = vtest_ns.min;
-		else if (rate_ns < vtest_ns.max)
-			diff_ns = vtest_ns.max;
 		else
-			diff_ns = rate_ns;
+			diff_ns = vtest_ns.max;
 		diff_ns -= event_ns - last_event_ns;
 
 		if (llabs(diff_ns) < 50000ll)
@@ -307,24 +289,24 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		last_event_ns = event_ns;
 		total_flip += 1;
 
-		now_ns = get_time_ns();
-		if (now_ns - start_ns > duration_ns)
+		if (event_ns - start_ns > duration_ns)
 			break;
 
 		/*
 		 * Burn CPU until next timestamp, sleeping isn't accurate enough.
-		 * It's worth noting that the target timestamp is based on absolute
-		 * timestamp rather than a delta to avoid accumulation errors.
+		 * The target timestamp is based on the delta b/w event timestamps
+		 * and whatever the time left to reach the expected refresh rate.
 		 */
-		diff_ns = now_ns - start_ns;
+		diff_ns = event_ns - target_ns;
 		wait_ns = ((diff_ns + rate_ns - 1) / rate_ns) * rate_ns;
-		target_ns = start_ns + wait_ns - 10;
+		wait_ns -= diff_ns;
+		target_ns = event_ns + wait_ns;
 
-		while (get_time_ns() < target_ns);
+		while (get_time_ns() < target_ns - 10);
 	}
 
-	igt_info("Completed %u flips, %u were in threshold for %"PRIu64"ns.\n",
-		 total_flip, total_pass, rate_ns);
+	igt_info("Completed %u flips, %u were in threshold for (%llu Hz) %"PRIu64"ns.\n",
+		 total_flip, total_pass, (NSECS_PER_SEC/rate_ns), rate_ns);
 
 	return total_flip ? ((total_pass * 100) / total_flip) : 0;
 }
@@ -338,8 +320,8 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	range_t range = get_vrr_range(data, output);
 	uint64_t rate = vtest_ns.mid;
 
-	igt_info("VRR Test execution on %s, PIPE_%s\n",
-		 output->name, kmstest_pipe_name(pipe));
+	igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
+		 output->name, kmstest_pipe_name(pipe), range.min, range.max);
 
 	prepare_test(data, output, pipe);
 
@@ -376,40 +358,43 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	 * if refresh_rate is 50Hz:
 	 *      Flip will happen right away so returned refresh rate is 50Hz.
 	 * if refresh_rate < 40Hz:
-	 *      Flip should happen at the vmax so the returned refresh rate
-	 *      would be 40Hz.
+	 *      As the driver will terminate the vblank at Vmax, the expected
+	 *      refresh rate could be:
+	 *      	(Vmax + time left for the next flip + Vmin)
+	 *
+	 *      And it is very difficult to generalize, at least 1/3 rd of the
+	 *      flips should be at Vmin (60 Hz) is expected.
 	 */
 	if (flags & TEST_FLIPLINE) {
-		rate = rate_from_refresh(range.min - 5);
+		rate = rate_from_refresh(range.max + 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.max + 5), rate, result);
 
-		rate = rate_from_refresh(range.max + 5);
+		rate = rate_from_refresh(range.min - 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
-		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+		igt_assert_f(result > 35,
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.min - 5), rate, result);
 	}
 
 	rate = vtest_ns.mid;
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result > 75,
-		     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	set_vrr_on_pipe(data, pipe, 0);
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result < 10,
-		     "Refresh rate %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	/* Clean-up */
 	igt_plane_set_fb(data->primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	igt_remove_fb(data->drm_fd, &data->fb1);
 	igt_remove_fb(data->drm_fd, &data->fb0);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: Update condition checks for flipline test (rev5)

== Series Details ==

== Series Details ==

Series: tests/kms_vrr: Update condition checks for flipline test (rev5)
URL : https://patchwork.freedesktop.org/series/84932/
State : success

== Summary ==

CI Bug Log - changes from IGT_5991 -> IGTPW_5479
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/index.html

Known issues
------------

Here are the changes found in IGTPW_5479 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/fi-tgl-y/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-y: [PASS][3] -> [DMESG-FAIL][4] ([i915#2601] / [i915#541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html

#### Possible fixes ####

* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [DMESG-WARN][5] ([i915#402]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/fi-tgl-y/igt@debugfs_test@read_all_entries.html

* igt@i915_pm_rpm@module-reload:
- fi-kbl-7500u: [DMESG-WARN][7] ([i915#2605]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/fi-kbl-7500u/igt@[email protected]

[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (43 -> 38)
------------------------------

Missing (5): fi-jsl-1 fi-ilk-m540 fi-bsw-cyan fi-dg1-1 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5991 -> IGTPW_5479

CI-20190529: 20190529
CI_DRM_9730: a70ac209cb308e06bc397cb3a6bf5764a4917333 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5479: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/index.html
IGT_5991: a2d9c45fca85918ecf47761205555aade64b9220 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_vrr: Update condition checks for flipline test (rev5)

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: tests/kms_vrr: Update condition checks for flipline test (rev5)
URL : https://patchwork.freedesktop.org/series/84932/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5991_full -> IGTPW_5479_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5479_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5479_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5479_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_color@pipe-b-ctm-0-5:
- shard-hsw: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-hsw8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw8/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5479_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb8/igt@[email protected]

* igt@gem_ctx_persistence@engines-persistence:
- shard-hsw: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw4/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-persistence:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-snb6/igt@[email protected]

* igt@gem_ctx_persistence@smoketest:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2896])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-tglb3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb7/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][9] ([i915#2842]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl2/igt@gem_exec_fair@[email protected]
- shard-glk: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-kbl4/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-apl7/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace:
- shard-hsw: NOTRUN -> [SKIP][15] ([fdo#109271]) +39 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw6/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk9/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842]) +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: NOTRUN -> [FAIL][19] ([i915#2842]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#2389])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk1/igt@gem_exec_reloc@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk3/igt@gem_exec_reloc@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#2190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2190])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#2190])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#2190])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl1/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#768]) +4 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb1/igt@[email protected]

* igt@gem_userptr_blits@readonly-mmap-unsync@wb:
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#1704]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb8/igt@gem_userptr_blits@[email protected]
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#1704]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb6/igt@gem_userptr_blits@[email protected]

* igt@gen3_mixed_blits:
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109289]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb8/igt@gen3_mixed_blits.html
- shard-tglb: NOTRUN -> [SKIP][31] ([fdo#109289]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb6/igt@gen3_mixed_blits.html

* igt@gen9_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#112306])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb1/igt@[email protected]

* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#112306]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb6/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#1937])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl2/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: NOTRUN -> [WARN][35] ([i915#2681] / [i915#2684])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][36] ([i915#2684])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb5/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-hsw: [PASS][37] -> [INCOMPLETE][38] ([i915#2782])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-hsw1/igt@i915_selftest@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw4/igt@i915_selftest@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-kbl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl4/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-apl8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl4/igt@[email protected]

* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [PASS][43] -> [FAIL][44] ([i915#2574])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-tglb6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb3/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#110725] / [fdo#111614]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#111614]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb3/igt@[email protected]

* igt@kms_ccs@pipe-d-crc-primary-basic:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271]) +79 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl4/igt@[email protected]

* igt@kms_ccs@pipe-d-crc-primary-rotation-180:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278]) +12 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@[email protected]

* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109284] / [fdo#111827]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb7/igt@[email protected]

* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-snb5/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +4 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb4/igt@[email protected]
- shard-hsw: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw7/igt@[email protected]

* igt@kms_color@pipe-b-degamma:
- shard-tglb: NOTRUN -> [FAIL][55] ([i915#1149])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][56] ([i915#1149])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb3/igt@[email protected]

* igt@kms_color@pipe-d-ctm-red-to-blue:
- shard-hsw: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [i915#1149])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb8/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +10 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl8/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-kbl: NOTRUN -> [TIMEOUT][60] ([i915#1319])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl4/igt@[email protected]

* igt@kms_content_protection@type1:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109300] / [fdo#111066])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#111828])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [fdo#109279]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109279]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][65] -> [FAIL][66] ([i915#96])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-hsw2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw8/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109274] / [fdo#109278]) +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb5/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html

* igt@kms_flip@2x-nonexisting-fb:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109274]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb1/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][69] -> [FAIL][70] ([i915#2122])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk7/igt@kms_flip@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][71] -> [FAIL][72] ([i915#79])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk7/igt@kms_flip@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-kbl: NOTRUN -> [FAIL][73] ([i915#2641]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#2587])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb1/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][75] ([i915#2628])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk8/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-apl: NOTRUN -> [FAIL][76] ([i915#2641]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [FAIL][77] ([i915#2546])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-snb: NOTRUN -> [SKIP][78] ([fdo#109271]) +89 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-snb4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-kbl: NOTRUN -> [FAIL][79] ([i915#49])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl7/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][80] ([i915#49])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271]) +47 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109280]) +9 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#111825]) +17 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#1187])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb2/igt@[email protected]

* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#533])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl7/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][89] ([i915#265])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][90] ([fdo#108145] / [i915#265]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][91] ([fdo#108145] / [i915#265]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl6/igt@[email protected]

* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#111615])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb5/igt@[email protected]

* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-kbl: NOTRUN -> [SKIP][93] ([fdo#109271]) +89 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl1/igt@[email protected]

* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#1836])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@kms_prime@[email protected]
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#1836])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb3/igt@kms_prime@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +3 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#2920]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#658]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#658]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl6/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-glk: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#658]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk1/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-hsw: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#1072]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-hsw7/igt@kms_psr@psr2_cursor_mmap_gtt.html
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109441])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_gtt.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][103] -> [SKIP][104] ([fdo#109441]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2437])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl7/igt@[email protected]

* igt@nouveau_crc@pipe-a-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][106] ([i915#2530]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb3/igt@[email protected]

* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][107] ([i915#2530]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb7/igt@[email protected]

* igt@prime_nv_api@i915_nv_import_twice:
- shard-iclb: NOTRUN -> [SKIP][108] ([fdo#109291]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb4/igt@prime_nv_api@i915_nv_import_twice.html

* igt@prime_nv_test@nv_write_i915_gtt_mmap_read:
- shard-tglb: NOTRUN -> [SKIP][109] ([fdo#109291]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb3/igt@prime_nv_test@nv_write_i915_gtt_mmap_read.html

* igt@sysfs_clients@recycle:
- shard-apl: [PASS][110] -> [FAIL][111] ([i915#3028])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-apl7/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl1/igt@[email protected]
- shard-tglb: [PASS][112] -> [FAIL][113] ([i915#3028])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-tglb7/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb8/igt@[email protected]

* igt@sysfs_clients@split-10@bcs0:
- shard-glk: [PASS][114] -> [SKIP][115] ([fdo#109271] / [i915#3026])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk2/igt@sysfs_clients@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk9/igt@sysfs_clients@[email protected]
- shard-tglb: [PASS][116] -> [SKIP][117] ([i915#3026])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-tglb6/igt@sysfs_clients@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb7/igt@sysfs_clients@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][118] ([i915#2842]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-kbl2/igt@gem_exec_fair@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][120] ([i915#2842]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-apl7/igt@gem_exec_fair@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][122] ([i915#2842]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-tglb3/igt@gem_exec_fair@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-tglb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds:
- shard-glk: [DMESG-WARN][124] ([i915#118] / [i915#95]) -> [PASS][125] +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk7/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [INCOMPLETE][126] ([i915#2880]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-snb4/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-snb5/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-iclb: [INCOMPLETE][128] ([i915#189]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-iclb4/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-iclb: [FAIL][130] ([i915#79]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-iclb7/igt@kms_flip@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [DMESG-WARN][132] ([i915#180]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-apl8/igt@kms_flip@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][134] ([i915#180] / [i915#533]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-kbl4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-kbl7/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][136] ([fdo#109441]) -> [PASS][137] +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [FAIL][138] ([i915#43]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-glk7/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-glk2/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-iclb: [FAIL][140] ([i915#1542]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5991/shard-iclb1/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/shard-iclb4/igt@[email protected]

* igt@prime_vge

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5479/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v5 1/1
#3 lore raw
In reply to Bhanuprakash Modem
Quoted 9 lines · Bhanuprakash Modem

This patch includes below updates
* For Flipline test: if refresh_rate <= Vrr_min then
- Expected returned refresh rate would be vrr_max
- At least 35% of the flips should be in threshold
* Update "igt_display_commit_atomic" with "igt_display_commit2"
* Calculate the target timestamp based on the delta between event timestamps & whatever the time left to reach the expected rate.
* Add few debug prints

Quoted 8 lines

V2:
* Rebase
V3:
* Compute the target timestamp based on the delta (Ville) V4:
* Add a comment to justify the result with refresh rate < 40Hz (Manasi) V5:
* Align the starting point with flip completion event (Manasi)

This looks good to me,

Manasi

Quoted 194 lines
Cc Ville Syrjälä <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
---
 tests/kms_vrr.c | 93 +++++++++++++++++++++----------------------------
 1 file changed, 39 insertions(+), 54 deletions(-)
tests/kms_vrr.c +39 -54
index beb06854f..e4ea74c17 100644
@@ -170,7 +170,7 @@ static void set_vrr_on_pipe(data_t *data, enum pipe pipe, bool enabled)
 {
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED,
 				enabled);
-	igt_display_commit_atomic(&data->display, 0, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Prepare the display for testing on the given pipe. */
@@ -208,22 +208,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 	 */
 	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, 0);
 
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-}
-
-/* Waits for the vblank interval. Returns the vblank timestamp in ns. */
-static uint64_t
-wait_for_vblank(data_t *data, enum pipe pipe)
-{
-	drmVBlank vbl = {};
-
-	vbl.request.type = kmstest_get_vbl_flag(pipe);
-	vbl.request.type |= DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT;
-	vbl.request.sequence = 1;
-	drmWaitVBlank(data->drm_fd, &vbl);
-
-	return get_kernel_event_ns(data, DRM_EVENT_VBLANK);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Performs an atomic non-blocking page-flip on a pipe. */
@@ -260,17 +245,18 @@ static uint32_t
 flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 uint64_t rate_ns, uint64_t duration_ns)
 {
-	uint64_t start_ns, last_event_ns;
+	uint64_t start_ns, last_event_ns, target_ns;
 	uint32_t total_flip = 0, total_pass = 0;
 	bool front = false;
 	vtest_ns_t vtest_ns = get_test_rate_ns(data, output);
 
-	/* Align with the vblank region to speed up convergence. */
-	last_event_ns = wait_for_vblank(data, pipe);
-	start_ns = get_time_ns();
+	/* Align with the flip completion event to speed up convergence. */
+	do_flip(data, &data->fb0);
+	start_ns = last_event_ns = target_ns = get_kernel_event_ns(data,
+							DRM_EVENT_FLIP_COMPLETE);
 
 	for (;;) {
-		uint64_t now_ns, event_ns, wait_ns, target_ns;
+		uint64_t event_ns, wait_ns;
 		int64_t diff_ns;
 
 		front = !front;
@@ -291,14 +277,10 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		 * difference between 144Hz and 143Hz which should give this
 		 * enough accuracy for most use cases.
 		 */
-		if (rate_ns <= vtest_ns.min && rate_ns >= vtest_ns.max)
+		if ((rate_ns < vtest_ns.min) && (rate_ns >= vtest_ns.max))
 			diff_ns = rate_ns;
-		else if (rate_ns > vtest_ns.min)
-			diff_ns = vtest_ns.min;
-		else if (rate_ns < vtest_ns.max)
-			diff_ns = vtest_ns.max;
 		else
-			diff_ns = rate_ns;
+			diff_ns = vtest_ns.max;
 		diff_ns -= event_ns - last_event_ns;
 
 		if (llabs(diff_ns) < 50000ll)
@@ -307,24 +289,24 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		last_event_ns = event_ns;
 		total_flip += 1;
 
-		now_ns = get_time_ns();
-		if (now_ns - start_ns > duration_ns)
+		if (event_ns - start_ns > duration_ns)
 			break;
 
 		/*
 		 * Burn CPU until next timestamp, sleeping isn't accurate enough.
-		 * It's worth noting that the target timestamp is based on absolute
-		 * timestamp rather than a delta to avoid accumulation errors.
+		 * The target timestamp is based on the delta b/w event timestamps
+		 * and whatever the time left to reach the expected refresh rate.
 		 */
-		diff_ns = now_ns - start_ns;
+		diff_ns = event_ns - target_ns;
 		wait_ns = ((diff_ns + rate_ns - 1) / rate_ns) * rate_ns;
-		target_ns = start_ns + wait_ns - 10;
+		wait_ns -= diff_ns;
+		target_ns = event_ns + wait_ns;
 
-		while (get_time_ns() < target_ns);
+		while (get_time_ns() < target_ns - 10);
 	}
 
-	igt_info("Completed %u flips, %u were in threshold for %"PRIu64"ns.\n",
-		 total_flip, total_pass, rate_ns);
+	igt_info("Completed %u flips, %u were in threshold for (%llu Hz) %"PRIu64"ns.\n",
+		 total_flip, total_pass, (NSECS_PER_SEC/rate_ns), rate_ns);
 
 	return total_flip ? ((total_pass * 100) / total_flip) : 0;
 }
@@ -338,8 +320,8 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	range_t range = get_vrr_range(data, output);
 	uint64_t rate = vtest_ns.mid;
 
-	igt_info("VRR Test execution on %s, PIPE_%s\n",
-		 output->name, kmstest_pipe_name(pipe));
+	igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
+		 output->name, kmstest_pipe_name(pipe), range.min, range.max);
 
 	prepare_test(data, output, pipe);
 
@@ -376,40 +358,43 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	 * if refresh_rate is 50Hz:
 	 *      Flip will happen right away so returned refresh rate is 50Hz.
 	 * if refresh_rate < 40Hz:
-	 *      Flip should happen at the vmax so the returned refresh rate
-	 *      would be 40Hz.
+	 *      As the driver will terminate the vblank at Vmax, the expected
+	 *      refresh rate could be:
+	 *      	(Vmax + time left for the next flip + Vmin)
+	 *
+	 *      And it is very difficult to generalize, at least 1/3 rd of the
+	 *      flips should be at Vmin (60 Hz) is expected.
 	 */
 	if (flags & TEST_FLIPLINE) {
-		rate = rate_from_refresh(range.min - 5);
+		rate = rate_from_refresh(range.max + 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.max + 5), rate, result);
 
-		rate = rate_from_refresh(range.max + 5);
+		rate = rate_from_refresh(range.min - 5);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
-		igt_assert_f(result > 75,
-			     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-			     rate, result);
+		igt_assert_f(result > 35,
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+			     (range.min - 5), rate, result);
 	}
 
 	rate = vtest_ns.mid;
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result > 75,
-		     "Refresh rate %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	set_vrr_on_pipe(data, pipe, 0);
 	result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 	igt_assert_f(result < 10,
-		     "Refresh rate %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
-		     rate, result);
+		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
+		     ((range.max + range.min) / 2), rate, result);
 
 	/* Clean-up */
 	igt_plane_set_fb(data->primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
-	igt_display_commit_atomic(&data->display,
-				  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	igt_remove_fb(data->drm_fd, &data->fb1);
 	igt_remove_fb(data->drm_fd, &data->fb0);
Signature · 1 line
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev