Skip to contentSkip to conversation

xfs: fix unused variable build warning in xfs_log.c

PATCH In review John Hubbard 3 participants 4 messages Feb 5, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: fix unused variable build warning in xfs_log.c

Delete the unused "log" variable in xfs_log_cover().

Fixes 303591a0a9473 ("xfs: cover the log during log quiesce")
Cc Brian Foster <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Darrick J. Wong <[email protected]>
Cc Allison Henderson <[email protected]>

---
Hi,

I just ran into this on today's linux-next, so here you go!

thanks,
John Hubbard
NVIDIA

 fs/xfs/xfs_log.c | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_log.c +0 -1
index 58699881c100..5a9cca3f7cbf 100644
@@ -1108,7 +1108,6 @@ static int
 xfs_log_cover(
 	struct xfs_mount	*mp)
 {
-	struct xlog		*log = mp->m_log;
 	int			error = 0;
 	bool			need_covered;
 

base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f

Signature · 1 line
2.30.0
#1 lore raw
Quoted 8 lines · John Hubbard

Delete the unused "log" variable in xfs_log_cover().

Fixes 303591a0a9473 ("xfs: cover the log during log quiesce")
Cc Brian Foster <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Darrick J. Wong <[email protected]>
Cc Allison Henderson <[email protected]>
Quoted 4 lines

---
Hi,

I just ran into this on today's linux-next, so here you go!

Thanks for the tipoff, I just realized with horror that I got the git push wrong and never actually updated xfs-linux.git#for-next. This (and all the other gcc warnings) are fixed in "xfs-for-next" which ... is not for-next.

Sigh..... so much for trying to get things in for testing. :(

--D

Quoted 25 lines

thanks,
John Hubbard
NVIDIA

 fs/xfs/xfs_log.c | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_log.c +0 -1
index 58699881c100..5a9cca3f7cbf 100644
@@ -1108,7 +1108,6 @@ static int
 xfs_log_cover(
 	struct xfs_mount	*mp)
 {
-	struct xlog		*log = mp->m_log;
 	int			error = 0;
 	bool			need_covered;
 

base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f

Signature · 1 line
2.30.0
#2 lore raw
Quoted 12 lines · Darrick J. Wong
Quoted 11 lines · John Hubbard

Delete the unused "log" variable in xfs_log_cover().

Fixes 303591a0a9473 ("xfs: cover the log during log quiesce")
Cc Brian Foster <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Darrick J. Wong <[email protected]>
Cc Allison Henderson <[email protected]>

---
Hi,

Quoted 9 lines
Quoted 1 line

I just ran into this on today's linux-next, so here you go!

Thanks for the tipoff, I just realized with horror that I got the git push wrong and never actually updated xfs-linux.git#for-next. This (and all the other gcc warnings) are fixed in "xfs-for-next" which ... is not for-next.

Sigh..... so much for trying to get things in for testing. :(

Well, if it's any consolation, this is the *only* warning that fired during my particular build, in linux-next. :)

thanks,

Signature · 2 lines
John Hubbard
NVIDIA
Reviewed-by on v1 1/1
#3 lore raw
In reply to John Hubbard
Quoted 8 lines · John Hubbard

Delete the unused "log" variable in xfs_log_cover().

Fixes 303591a0a9473 ("xfs: cover the log during log quiesce")
Cc Brian Foster <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Darrick J. Wong <[email protected]>
Cc Allison Henderson <[email protected]>

Looks good.