Skip to contentSkip to conversation

Make fw_devlink=on more forgiving

PATCH In review Saravana Kannan 11 participants 61 messages Feb 6, 2021 – Apr 21, 2021 5 messages not in the archive

Subsystems (12)
lore
Share & tools
lore
#0 lore raw

v4 cover Make fw_devlink=on more forgiving

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

 .../admin-guide/kernel-parameters.txt         |  5 ++
 drivers/base/core.c                           | 58 ++++++++++++++++++-
 drivers/base/power/domain.c                   |  2 +
 drivers/clk/clk.c                             |  3 +
 drivers/of/property.c                         | 16 +++--
 include/linux/fwnode.h                        | 20 ++++++-
 kernel/irq/irqdomain.c                        |  2 +
 7 files changed, 98 insertions(+), 8 deletions(-)
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#1 lore raw

PATCH v4 1/8 driver core: fw_devlink: Detect supplier devices that will never be added

During the initial parsing of firmware by fw_devlink, fw_devlink might infer that some supplier firmware nodes would get populated as devices. But the inference is not always correct. This patch tries to logically detect and fix such mistakes as boot progresses or more devices probe.

fw_devlink makes a fundamental assumption that once a device binds to a driver, it will populate (i.e: add as struct devices) all the child firmware nodes that could be populated as devices (if they aren't populated already).

So, whenever a device probes, we check all its child firmware nodes. If a child firmware node has a corresponding device populated, we don't modify the child node or its descendants. However, if a child firmware node has not been populated as a device, we delete all the fwnode links where the child node or its descendants are suppliers. This ensures that no other device is blocked on a firmware node that will never be populated as a device. We also mark such fwnodes as NOT_DEVICE, so that no new fwnode links are created with these nodes as suppliers.

Fixes e590474768f1 ("driver core: Set fw_devlink=on by default")
---
 drivers/base/core.c    | 31 ++++++++++++++++++++++++++++---
 include/linux/fwnode.h |  2 ++
 2 files changed, 30 insertions(+), 3 deletions(-)
drivers/base/core.c +28 -3
index 484a942884ba..c95b1daabac7 100644
@@ -148,6 +148,21 @@ void fwnode_links_purge(struct fwnode_handle *fwnode)
 	fwnode_links_purge_consumers(fwnode);
 }
 
+static void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode)
+{
+	struct fwnode_handle *child;
+
+	/* Don't purge consumer links of an added child */
+	if (fwnode->dev)
+		return;
+
+	fwnode->flags |= FWNODE_FLAG_NOT_DEVICE;
+	fwnode_links_purge_consumers(fwnode);
+
+	fwnode_for_each_available_child_node(fwnode, child)
+		fw_devlink_purge_absent_suppliers(child);
+}
+
 #ifdef CONFIG_SRCU
 static DEFINE_MUTEX(device_links_lock);
 DEFINE_STATIC_SRCU(device_links_srcu);
@@ -1154,12 +1169,22 @@ void device_links_driver_bound(struct device *dev)
 	LIST_HEAD(sync_list);
 
 	/*
-	 * If a device probes successfully, it's expected to have created all
+	 * If a device binds successfully, it's expected to have created all
 	 * the device links it needs to or make new device links as it needs
-	 * them. So, it no longer needs to wait on any suppliers.
+	 * them. So, fw_devlink no longer needs to create device links to any
+	 * of the device's suppliers.
+	 *
+	 * Also, if a child firmware node of this bound device is not added as
+	 * a device by now, assume it is never going to be added and make sure
+	 * other devices don't defer probe indefinitely by waiting for such a
+	 * child device.
 	 */
-	if (dev->fwnode && dev->fwnode->dev == dev)
+	if (dev->fwnode && dev->fwnode->dev == dev) {
+		struct fwnode_handle *child;
 		fwnode_links_purge_suppliers(dev->fwnode);
+		fwnode_for_each_available_child_node(dev->fwnode, child)
+			fw_devlink_purge_absent_suppliers(child);
+	}
 	device_remove_file(dev, &dev_attr_waiting_for_supplier);
 
 	device_links_write_lock();
include/linux/fwnode.h +2 -0
index fde4ad97564c..21082f11473f 100644
@@ -19,8 +19,10 @@ struct device;
  * fwnode link flags
  *
  * LINKS_ADDED: The fwnode has already be parsed to add fwnode links.
+ * NOT_DEVICE: The fwnode will never be populated as a struct device.
  */
 #define FWNODE_FLAG_LINKS_ADDED		BIT(0)
+#define FWNODE_FLAG_NOT_DEVICE		BIT(1)
 
 struct fwnode_handle {
 	struct fwnode_handle *secondary;
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#2 lore raw

PATCH v4 2/8 of: property: Don't add links to absent suppliers

In reply to Saravana Kannan

If driver core marks a firmware node as not a device, don't add fwnode links where it's a supplier.

Fixes e590474768f1 ("driver core: Set fw_devlink=on by default")
---
 drivers/of/property.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/of/property.c +3 -1
index 6287c6d60bb7..53d163c8d39b 100644
@@ -1103,7 +1103,9 @@ static int of_link_to_phandle(struct device_node *con_np,
 	 * created for them.
 	 */
 	sup_dev = get_dev_from_fwnode(&sup_np->fwnode);
-	if (!sup_dev && of_node_check_flag(sup_np, OF_POPULATED)) {
+	if (!sup_dev &&
+	    (of_node_check_flag(sup_np, OF_POPULATED) ||
+	     sup_np->fwnode.flags & FWNODE_FLAG_NOT_DEVICE)) {
 		pr_debug("Not linking %pOFP to %pOFP - No struct device\n",
 			 con_np, sup_np);
 		of_node_put(sup_np);
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
maintainer Acked-by on v4 2/8
#3 lore raw

Re: [PATCH v4 2/8] of: property: Don't add links to absent suppliers

Quoted 9 lines · Saravana Kannan

If driver core marks a firmware node as not a device, don't add fwnode links where it's a supplier.

Fixes e590474768f1 ("driver core: Set fw_devlink=on by default")
---
 drivers/of/property.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
#4 lore raw

PATCH v4 3/8 driver core: Add fw_devlink.strict kernel param

In reply to Saravana Kannan

This param allows forcing all dependencies to be treated as mandatory. This will be useful for boards in which all optional dependencies like IOMMUs and DMAs need to be treated as mandatory dependencies.

---
 Documentation/admin-guide/kernel-parameters.txt |  5 +++++
 drivers/base/core.c                             | 12 ++++++++++++
 include/linux/fwnode.h                          |  1 +
 3 files changed, 18 insertions(+)
Documentation/admin-guide/kernel-parameters.txt +5 -0
index a10b545c2070..692b63644133 100644
@@ -1433,6 +1433,11 @@
 				to enforce probe and suspend/resume ordering.
 			rpm --	Like "on", but also use to order runtime PM.
 
+	fw_devlink.strict=<bool>
+			[KNL] Treat all inferred dependencies as mandatory
+			dependencies. This only applies for fw_devlink=on|rpm.
+			Format: <bool>
+
 	gamecon.map[2|3]=
 			[HW,JOY] Multisystem joystick and NES/SNES/PSX pad
 			support via parallel port (up to 5 devices per port)
drivers/base/core.c +12 -0
index c95b1daabac7..f466ab4f1c35 100644
@@ -1521,6 +1521,13 @@ static int __init fw_devlink_setup(char *arg)
 }
 early_param("fw_devlink", fw_devlink_setup);
 
+static bool fw_devlink_strict;
+static int __init fw_devlink_strict_setup(char *arg)
+{
+	return strtobool(arg, &fw_devlink_strict);
+}
+early_param("fw_devlink.strict", fw_devlink_strict_setup);
+
 u32 fw_devlink_get_flags(void)
 {
 	return fw_devlink_flags;
@@ -1531,6 +1538,11 @@ static bool fw_devlink_is_permissive(void)
 	return fw_devlink_flags == FW_DEVLINK_FLAGS_PERMISSIVE;
 }
 
+bool fw_devlink_is_strict(void)
+{
+	return fw_devlink_strict && !fw_devlink_is_permissive();
+}
+
 static void fw_devlink_parse_fwnode(struct fwnode_handle *fwnode)
 {
 	if (fwnode->flags & FWNODE_FLAG_LINKS_ADDED)
include/linux/fwnode.h +1 -0
index 21082f11473f..d5caefe39d93 100644
@@ -162,6 +162,7 @@ static inline void fwnode_init(struct fwnode_handle *fwnode,
 }
 
 extern u32 fw_devlink_get_flags(void);
+extern bool fw_devlink_is_strict(void);
 int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
 void fwnode_links_purge(struct fwnode_handle *fwnode);
 
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#5 lore raw

PATCH v4 4/8 of: property: Add fw_devlink support for optional properties

In reply to Saravana Kannan

Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings.

---
 drivers/of/property.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/of/property.c +9 -3
index 53d163c8d39b..962109082df1 100644
@@ -1235,6 +1235,7 @@ static struct device_node *parse_##fname(struct device_node *np,	     \
 struct supplier_bindings {
 	struct device_node *(*parse_prop)(struct device_node *np,
 					  const char *prop_name, int index);
+	bool optional;
 };
 
 DEFINE_SIMPLE_PROP(clocks, "clocks", "#clock-cells")
@@ -1308,12 +1309,12 @@ static struct device_node *parse_interrupts(struct device_node *np,
 static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_clocks, },
 	{ .parse_prop = parse_interconnects, },
-	{ .parse_prop = parse_iommus, },
-	{ .parse_prop = parse_iommu_maps, },
+	{ .parse_prop = parse_iommus, .optional = true, },
+	{ .parse_prop = parse_iommu_maps, .optional = true, },
 	{ .parse_prop = parse_mboxes, },
 	{ .parse_prop = parse_io_channels, },
 	{ .parse_prop = parse_interrupt_parent, },
-	{ .parse_prop = parse_dmas, },
+	{ .parse_prop = parse_dmas, .optional = true, },
 	{ .parse_prop = parse_power_domains, },
 	{ .parse_prop = parse_hwlocks, },
 	{ .parse_prop = parse_extcon, },
@@ -1368,6 +1369,11 @@ static int of_link_property(struct device_node *con_np, const char *prop_name)
 
 	/* Do not stop at first failed link, link all available suppliers. */
 	while (!matched && s->parse_prop) {
+		if (s->optional && !fw_devlink_is_strict()) {
+			s++;
+			continue;
+		}
+
 		while ((phandle = s->parse_prop(con_np, prop_name, i))) {
 			matched = true;
 			i++;
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
maintainer
#6 lore raw

Re: [PATCH v4 4/8] of: property: Add fw_devlink support for optional properties

Quoted 2 lines · Saravana Kannan

Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings.

I don't think we can say these are optional or not. It's got to be a driver decision somehow.

For example, if IOMMU is optional, what happens with this sequence:

driver probes without IOMMU
driver calls dma_map_?()
IOMMU driver probes
h/w accesses DMA buffer --> BOOM!

#7 lore raw

Re: [PATCH v4 4/8] of: property: Add fw_devlink support for optional properties

Quoted 7 lines · Rob Herring
Quoted 2 lines · Saravana Kannan

Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings.

I don't think we can say these are optional or not. It's got to be a driver decision somehow.

Right, so maybe the word "optional" isn't a good name for it. I can change that if you want.

The point being, fw_devlink can't block the probe of this driver based on iommu property. We let the driver decide if it wants to -EPROBE_DEFER or not or however it wants to handle this.

Quoted 6 lines

For example, if IOMMU is optional, what happens with this sequence:

driver probes without IOMMU
driver calls dma_map_?()
IOMMU driver probes
h/w accesses DMA buffer --> BOOM!

Right. But how is this really related to fw_devlink? AFAICT, this is an issue even today. If the driver needs the IOMMU, then it needs to make sure the IOMMU has probed? What am I missing?

-Saravana

#8 lore raw

Re: [PATCH v4 4/8] of: property: Add fw_devlink support for optional properties

Hi Saravana,

CC iommu

Quoted 8 lines · Saravana Kannan
Quoted 6 lines · Rob Herring
Quoted 2 lines · Saravana Kannan

Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings.

I don't think we can say these are optional or not. It's got to be a driver decision somehow.

Quoted 6 lines

Right, so maybe the word "optional" isn't a good name for it. I can change that if you want.

The point being, fw_devlink can't block the probe of this driver based on iommu property. We let the driver decide if it wants to -EPROBE_DEFER or not or however it wants to handle this.

The driver cannot make that decision, cfr. below.

Quoted 6 lines
Quoted 6 lines

For example, if IOMMU is optional, what happens with this sequence:

driver probes without IOMMU
driver calls dma_map_?()
IOMMU driver probes
h/w accesses DMA buffer --> BOOM!

Does it really behave that way? Or does it continue without IOMMU?

Quoted 3 lines

Right. But how is this really related to fw_devlink? AFAICT, this is an issue even today. If the driver needs the IOMMU, then it needs to make sure the IOMMU has probed? What am I missing?

Individual I/O (IOMMU slave) drivers are completely unaware of the presence or absence of an IOMMU; they just use the DMA API, which is the same regardless of an IOMMU being used or not.
While for GPIO/IRQ/CLK/DMA/... have request/get_{gpio,irq,clk,dma,...} APIs for a driver to get a reference, which can return -EPROBE_DEFER, no such thing exists for IOMMUs. This is handled by the IOMMU core instead.

Using the IOMMU or not is more like a system policy decision.

Gr{oetje,eeting}s,

Geert

Signature · 9 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
#9 lore raw

PATCH v4 5/8 driver core: fw_devlink: Handle suppliers that don't use driver core

In reply to Saravana Kannan

Device links only work between devices that use the driver core to match and bind a driver to a device. So, add an API for frameworks to let the driver core know that a fwnode has been initialized by a driver without using the driver core.

Then use this information to make sure that fw_devlink doesn't make the consumers wait indefinitely on suppliers that'll never bind to a driver.

---
 drivers/base/core.c    | 15 +++++++++++++++
 include/linux/fwnode.h | 19 +++++++++++++++++--
 2 files changed, 32 insertions(+), 2 deletions(-)
drivers/base/core.c +15 -0
index f466ab4f1c35..ea710b33bda6 100644
@@ -1636,6 +1636,17 @@ static int fw_devlink_create_devlink(struct device *con,
 
 	sup_dev = get_dev_from_fwnode(sup_handle);
 	if (sup_dev) {
+		/*
+		 * If it's one of those drivers that don't actually bind to
+		 * their device using driver core, then don't wait on this
+		 * supplier device indefinitely.
+		 */
+		if (sup_dev->links.status == DL_DEV_NO_DRIVER &&
+		    sup_handle->flags & FWNODE_FLAG_INITIALIZED) {
+			ret = -EINVAL;
+			goto out;
+		}
+
 		/*
 		 * If this fails, it is due to cycles in device links.  Just
 		 * give up on this link and treat it as invalid.
@@ -1655,6 +1666,10 @@ static int fw_devlink_create_devlink(struct device *con,
 		goto out;
 	}
 
+	/* Supplier that's already initialized without a struct device. */
+	if (sup_handle->flags & FWNODE_FLAG_INITIALIZED)
+		return -EINVAL;
+
 	/*
 	 * DL_FLAG_SYNC_STATE_ONLY doesn't block probing and supports
 	 * cycles. So cycle detection isn't necessary and shouldn't be
include/linux/fwnode.h +17 -2
index d5caefe39d93..dfefd43a737c 100644
@@ -11,6 +11,7 @@
 
 #include <linux/types.h>
 #include <linux/list.h>
+#include <linux/err.h>
 
 struct fwnode_operations;
 struct device;
@@ -18,11 +19,13 @@ struct device;
 /*
  * fwnode link flags
  *
- * LINKS_ADDED: The fwnode has already be parsed to add fwnode links.
- * NOT_DEVICE: The fwnode will never be populated as a struct device.
+ * LINKS_ADDED:	The fwnode has already be parsed to add fwnode links.
+ * NOT_DEVICE:	The fwnode will never be populated as a struct device.
+ * INITIALIZED: The hardware corresponding to fwnode has been initialized.
  */
 #define FWNODE_FLAG_LINKS_ADDED		BIT(0)
 #define FWNODE_FLAG_NOT_DEVICE		BIT(1)
+#define FWNODE_FLAG_INITIALIZED		BIT(2)
 
 struct fwnode_handle {
 	struct fwnode_handle *secondary;
@@ -161,6 +164,18 @@ static inline void fwnode_init(struct fwnode_handle *fwnode,
 	INIT_LIST_HEAD(&fwnode->suppliers);
 }
 
+static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
+					  bool initialized)
+{
+	if (IS_ERR_OR_NULL(fwnode))
+		return;
+
+	if (initialized)
+		fwnode->flags |= FWNODE_FLAG_INITIALIZED;
+	else
+		fwnode->flags &= ~FWNODE_FLAG_INITIALIZED;
+}
+
 extern u32 fw_devlink_get_flags(void);
 extern bool fw_devlink_is_strict(void);
 int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#10 lore raw

PATCH v4 6/8 irqdomain: Mark fwnodes when their irqdomain is added/removed

In reply to Saravana Kannan

This allows fw_devlink to recognize irqdomain drivers that don't use the device-driver model to initialize the device. fw_devlink will use this information to make sure consumers of such irqdomain aren't indefinitely blocked from probing, waiting for the irqdomain device to appear and bind to a driver.

---
 kernel/irq/irqdomain.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/irq/irqdomain.c +2 -0
index 6aacd342cd14..288151393a06 100644
@@ -205,6 +205,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
 	}
 
 	fwnode_handle_get(fwnode);
+	fwnode_dev_initialized(fwnode, true);
 
 	/* Fill structure */
 	INIT_RADIX_TREE(&domain->revmap_tree, GFP_KERNEL);
@@ -253,6 +254,7 @@ void irq_domain_remove(struct irq_domain *domain)
 
 	pr_debug("Removed domain %s\n", domain->name);
 
+	fwnode_dev_initialized(domain->fwnode, false);
 	fwnode_handle_put(domain->fwnode);
 	if (domain->flags & IRQ_DOMAIN_NAME_ALLOCATED)
 		kfree(domain->name);
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#11 lore raw

PATCH v4 7/8 PM: domains: Mark fwnodes when their powerdomain is added/removed

In reply to Saravana Kannan

This allows fw_devlink to recognize power domain drivers that don't use the device-driver model to initialize the device. fw_devlink will use this information to make sure consumers of such power domain aren't indefinitely blocked from probing, waiting for the power domain device to appear and bind to a driver.

---
 drivers/base/power/domain.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/base/power/domain.c +2 -0
index 9a14eedacb92..6ac52a038bb9 100644
@@ -2164,6 +2164,7 @@ static int genpd_add_provider(struct device_node *np, genpd_xlate_t xlate,
 	cp->node = of_node_get(np);
 	cp->data = data;
 	cp->xlate = xlate;
+	fwnode_dev_initialized(&np->fwnode, true);
 
 	mutex_lock(&of_genpd_mutex);
 	list_add(&cp->link, &of_genpd_providers);
@@ -2353,6 +2354,7 @@ void of_genpd_del_provider(struct device_node *np)
 				}
 			}
 
+			fwnode_dev_initialized(&cp->node->fwnode, false);
 			list_del(&cp->link);
 			of_node_put(cp->node);
 			kfree(cp);
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#12 lore raw

PATCH v4 8/8 clk: Mark fwnodes when their clock provider is added/removed

In reply to Saravana Kannan

This allows fw_devlink to recognize clock provider drivers that don't use the device-driver model to initialize the device. fw_devlink will use this information to make sure consumers of such clock providers aren't indefinitely blocked from probing, waiting for the power domain device to appear and bind to a driver.

---
 drivers/clk/clk.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/clk.c +3 -0
index 8c1d04db990d..27ff90eacb1f 100644
@@ -4555,6 +4555,8 @@ int of_clk_add_provider(struct device_node *np,
 	if (ret < 0)
 		of_clk_del_provider(np);
 
+	fwnode_dev_initialized(&np->fwnode, true);
+
 	return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_provider);
@@ -4672,6 +4674,7 @@ void of_clk_del_provider(struct device_node *np)
 	list_for_each_entry(cp, &of_clk_providers, link) {
 		if (cp->node == np) {
 			list_del(&cp->link);
+			fwnode_dev_initialized(&np->fwnode, false);
 			of_node_put(cp->node);
 			kfree(cp);
 			break;
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
#13 lore raw

Re: [PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed

Quoted 6 lines · Saravana Kannan

This allows fw_devlink to recognize clock provider drivers that don't use the device-driver model to initialize the device. fw_devlink will use this information to make sure consumers of such clock providers aren't indefinitely blocked from probing, waiting for the power domain device to appear and bind to a driver.

Don't we have cases that are a mixture? IOW, a subset of the clock provider is initialized early, then the full driver takes over. You'd want consumers that are not a driver to succeed, but drivers to defer until the full driver is up.

Quoted 30 lines
---
 drivers/clk/clk.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/clk.c +3 -1
index 8c1d04db990d..27ff90eacb1f 100644
@@ -4555,6 +4555,8 @@ int of_clk_add_provider(struct device_node *np,
        if (ret < 0)
                of_clk_del_provider(np);
 
+       fwnode_dev_initialized(&np->fwnode, true);
+
        return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_provider);
@@ -4672,6 +4674,7 @@ void of_clk_del_provider(struct device_node *np)
        list_for_each_entry(cp, &of_clk_providers, link) {
                if (cp->node == np) {
                        list_del(&cp->link);
+                       fwnode_dev_initialized(&np->fwnode, false);
                        of_node_put(cp->node);
                        kfree(cp);
                        break;
--

2.30.0.478.g8a0d178c01-goog

#14 lore raw

Re: [PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed

Quoted 9 lines · Rob Herring
Quoted 6 lines · Saravana Kannan

This allows fw_devlink to recognize clock provider drivers that don't use the device-driver model to initialize the device. fw_devlink will use this information to make sure consumers of such clock providers aren't indefinitely blocked from probing, waiting for the power domain device to appear and bind to a driver.

Quoted 4 lines

Don't we have cases that are a mixture? IOW, a subset of the clock provider is initialized early, then the full driver takes over. You'd want consumers that are not a driver to succeed, but drivers to defer until the full driver is up.

You probably just made a typo, but to clarify, this is about ignoring suppliers that never bind. So, in your case the clock device is the supplier.

To answer your question, consumer devices added after the full supplier driver takes over will still have device links created to the supplier clock device. But consumers added before the full driver takes over won't. So, nothing is worse off with fw_devlink=on and we get way more dependency tracking (device links) created than what we have today.

-Saravana

#15 lore raw

PATCH 1/1 clk: Mark fwnodes when their clock provider is added

In reply to Saravana Kannan

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/clk.c +2 -0
index 27ff90eacb1f..9370e4dfecae 100644
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
 	if (ret < 0)
 		of_clk_del_provider(np);
 
+	fwnode_dev_initialized(&np->fwnode, true);
+
 	return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
Signature · 1 line
2.25.1
#16 lore raw

PATCH 1/1 clk: Mark fwnodes when their clock provider is added

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/clk.c +2 -0
index 27ff90eacb1f..9370e4dfecae 100644
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
 	if (ret < 0)
 		of_clk_del_provider(np);
 
+	fwnode_dev_initialized(&np->fwnode, true);
+
 	return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
Signature · 1 line
2.25.1
maintainer
#17 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoted 28 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/clk.c +2 -0
index 27ff90eacb1f..9370e4dfecae 100644
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
 	if (ret < 0)
 		of_clk_del_provider(np);
 
+	fwnode_dev_initialized(&np->fwnode, true);
+
 	return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
Signature · 1 line
2.25.1

Any objection for me taking this in my tree as well?

thanks,

greg k-h

maintainer Acked-by
#18 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoting Greg KH (2021-02-11 05:00:51)

Quoted 10 lines · Tudor Ambarus
Quoted 9 lines

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

---

#19 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

In reply to Tudor Ambarus

Hi

Quoted 8 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch, which landed in linux-next as commit 6579c8d97ad7 ("clk:
Mark fwnodes when their clock provider is added") causes the following NULL pointer dereference on Raspberry Pi 3b+ boards:

--->8---

raspberrypi-firmware soc:firmware: Attached to firmware from 2020-01-06T13:05:25

Unable to handle kernel NULL pointer dereference at virtual address 

0000000000000050
Mem abort info:
  ESR = 0x96000004
  EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0
  EA = 0, S1PTW = 0
Data abort info:
  ISV = 0, ISS = 0x00000004
  CM = 0, WnR = 0
[0000000000000050] user address but active_mm is swapper

Internal error: Oops: 96000004 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 10 Comm: kworker/0:1 Not tainted 5.12.0-rc4+ #2764
Hardware name: Raspberry Pi 3 Model B (DT)
Workqueue: events deferred_probe_work_func
pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--)
pc : of_clk_add_hw_provider+0xac/0xe8
lr : of_clk_add_hw_provider+0x94/0xe8

sp : ffff8000130936b0
x29: ffff8000130936b0 x28: ffff800012494e04
x27: ffff00003b18cb05 x26: ffff00003aa5c010
x25: 0000000000000000 x24: 0000000000000000
x23: ffff00003aa1e380 x22: ffff8000106830d0
x21: ffff80001233f180 x20: 0000000000000018
x19: 0000000000000000 x18: ffff8000124d38b0
x17: 0000000000000013 x16: 0000000000000014
x15: ffff8000125758b0 x14: 00000000000184e0
x13: 000000000000292e x12: ffff80001258dd98
x11: 0000000000000001 x10: 0101010101010101
x9 : ffff80001233f288 x8 : 7f7f7f7f7f7f7f7f
x7 : fefefefeff6c626f x6 : 5d636d8080808080
x5 : 00000000006d635d x4 : 0000000000000000
x3 : 0000000000000000 x2 : 540eb5edae191600
x1 : 0000000000000000 x0 : 0000000000000000

Call trace:
  of_clk_add_hw_provider+0xac/0xe8
  devm_of_clk_add_hw_provider+0x5c/0xb8
  raspberrypi_clk_probe+0x110/0x210
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  device_add+0x47c/0x780
  platform_device_add+0x110/0x248
  platform_device_register_full+0x120/0x150
  rpi_firmware_probe+0x158/0x1f8
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  deferred_probe_work_func+0x70/0xa8
  process_one_work+0x2a8/0x718
  worker_thread+0x48/0x460
  kthread+0x134/0x160
  ret_from_fork+0x10/0x18
Code: b1006294 540000c0 b140069f 54000088 (3940e280)
---[ end trace 7ead5ec2f0c51cfe ]---

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

Quoted 9 lines
---
  drivers/clk/clk.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/clk/clk.c +0 -0
index 27ff90eacb1f..9370e4dfecae 100644

drivers/clk/clk.c int of_clk_add_hw_provider(struct device_node *np, · line 4601

Quoted 8 lines
drivers/clk/clk.c +2 -0
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
  	if (ret < 0)
  		of_clk_del_provider(np);
 
+	fwnode_dev_initialized(&np->fwnode, true);
+
  	return ret;
  }
  EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
#20 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Hi Marek,

Quoted 70 lines · Marek Szyprowski
Quoted 8 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch, which landed in linux-next as commit 6579c8d97ad7 ("clk:
Mark fwnodes when their clock provider is added") causes the following NULL pointer dereference on Raspberry Pi 3b+ boards:

--->8---

raspberrypi-firmware soc:firmware: Attached to firmware from 2020-01-06T13:05:25

Unable to handle kernel NULL pointer dereference at virtual address
0000000000000050
Mem abort info:
   ESR = 0x96000004
   EC = 0x25: DABT (current EL), IL = 32 bits
   SET = 0, FnV = 0
   EA = 0, S1PTW = 0
Data abort info:
   ISV = 0, ISS = 0x00000004
   CM = 0, WnR = 0
[0000000000000050] user address but active_mm is swapper
Internal error: Oops: 96000004 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 10 Comm: kworker/0:1 Not tainted 5.12.0-rc4+ #2764
Hardware name: Raspberry Pi 3 Model B (DT)
Workqueue: events deferred_probe_work_func
pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--)
pc : of_clk_add_hw_provider+0xac/0xe8
lr : of_clk_add_hw_provider+0x94/0xe8

sp : ffff8000130936b0
x29: ffff8000130936b0 x28: ffff800012494e04
x27: ffff00003b18cb05 x26: ffff00003aa5c010
x25: 0000000000000000 x24: 0000000000000000
x23: ffff00003aa1e380 x22: ffff8000106830d0
x21: ffff80001233f180 x20: 0000000000000018
x19: 0000000000000000 x18: ffff8000124d38b0
x17: 0000000000000013 x16: 0000000000000014
x15: ffff8000125758b0 x14: 00000000000184e0
x13: 000000000000292e x12: ffff80001258dd98
x11: 0000000000000001 x10: 0101010101010101
x9 : ffff80001233f288 x8 : 7f7f7f7f7f7f7f7f
x7 : fefefefeff6c626f x6 : 5d636d8080808080
x5 : 00000000006d635d x4 : 0000000000000000
x3 : 0000000000000000 x2 : 540eb5edae191600
x1 : 0000000000000000 x0 : 0000000000000000

Call trace:
  of_clk_add_hw_provider+0xac/0xe8
  devm_of_clk_add_hw_provider+0x5c/0xb8
  raspberrypi_clk_probe+0x110/0x210
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  device_add+0x47c/0x780
  platform_device_add+0x110/0x248
  platform_device_register_full+0x120/0x150
  rpi_firmware_probe+0x158/0x1f8
Quoted 4 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

raspberrypi_clk_probe():

/*
* We can be probed either through the an old-fashioned
* platform device registration or through a DT node that is a
* child of the firmware node. Handle both cases. */

So the real issue is rpi_register_clk_driver() creating a platform device for the firmware clocks if they're missing in DT.

Then, the clock driver calls devm_of_clk_add_hw_provider(), regardless of a DT node being present or not.
I'm wondering how power consumers are supposed to refer to these firmware clocks, without a DT node?

Quoted 11 lines

drivers/clk/clk.c int of_clk_add_hw_provider(struct device_node *np, · line 4601

Quoted 11 lines
drivers/clk/clk.c +2 -0
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
      if (ret < 0)
              of_clk_del_provider(np);
 
+     fwnode_dev_initialized(&np->fwnode, true);
+
      return ret;
  }
  EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#21 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

In reply to Marek Szyprowski
Quoted 87 lines · Marek Szyprowski

Hi

Quoted 8 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch, which landed in linux-next as commit 6579c8d97ad7 ("clk:
Mark fwnodes when their clock provider is added") causes the following NULL pointer dereference on Raspberry Pi 3b+ boards:

--->8---

raspberrypi-firmware soc:firmware: Attached to firmware from 2020-01-06T13:05:25

Unable to handle kernel NULL pointer dereference at virtual address 

0000000000000050
Mem abort info:
   ESR = 0x96000004
   EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0
   EA = 0, S1PTW = 0
Data abort info:
   ISV = 0, ISS = 0x00000004
   CM = 0, WnR = 0
[0000000000000050] user address but active_mm is swapper

Internal error: Oops: 96000004 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 10 Comm: kworker/0:1 Not tainted 5.12.0-rc4+ #2764
Hardware name: Raspberry Pi 3 Model B (DT)
Workqueue: events deferred_probe_work_func
pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--)
pc : of_clk_add_hw_provider+0xac/0xe8
lr : of_clk_add_hw_provider+0x94/0xe8

sp : ffff8000130936b0
x29: ffff8000130936b0 x28: ffff800012494e04
x27: ffff00003b18cb05 x26: ffff00003aa5c010
x25: 0000000000000000 x24: 0000000000000000
x23: ffff00003aa1e380 x22: ffff8000106830d0
x21: ffff80001233f180 x20: 0000000000000018
x19: 0000000000000000 x18: ffff8000124d38b0
x17: 0000000000000013 x16: 0000000000000014
x15: ffff8000125758b0 x14: 00000000000184e0
x13: 000000000000292e x12: ffff80001258dd98
x11: 0000000000000001 x10: 0101010101010101
x9 : ffff80001233f288 x8 : 7f7f7f7f7f7f7f7f
x7 : fefefefeff6c626f x6 : 5d636d8080808080
x5 : 00000000006d635d x4 : 0000000000000000
x3 : 0000000000000000 x2 : 540eb5edae191600
x1 : 0000000000000000 x0 : 0000000000000000

Call trace:
  of_clk_add_hw_provider+0xac/0xe8
  devm_of_clk_add_hw_provider+0x5c/0xb8
  raspberrypi_clk_probe+0x110/0x210
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  device_add+0x47c/0x780
  platform_device_add+0x110/0x248
  platform_device_register_full+0x120/0x150
  rpi_firmware_probe+0x158/0x1f8
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  deferred_probe_work_func+0x70/0xa8
  process_one_work+0x2a8/0x718
  worker_thread+0x48/0x460
  kthread+0x134/0x160
  ret_from_fork+0x10/0x18
Code: b1006294 540000c0 b140069f 54000088 (3940e280)
---[ end trace 7ead5ec2f0c51cfe ]---
Quoted 4 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock is used, and it's defined and queried later through devm_clk_hw_register_clkdev().

@Marek, I don't mind taking care of it if it's OK with you.

Regards,
Nicolas

maintainer
#22 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24)

Quoted 93 lines · Marek Szyprowski
Quoted 87 lines

Hi

Quoted 8 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch, which landed in linux-next as commit 6579c8d97ad7 ("clk:
Mark fwnodes when their clock provider is added") causes the following NULL pointer dereference on Raspberry Pi 3b+ boards:

--->8---

raspberrypi-firmware soc:firmware: Attached to firmware from 2020-01-06T13:05:25

Unable to handle kernel NULL pointer dereference at virtual address 

0000000000000050
Mem abort info:
   ESR = 0x96000004
   EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0
   EA = 0, S1PTW = 0
Data abort info:
   ISV = 0, ISS = 0x00000004
   CM = 0, WnR = 0
[0000000000000050] user address but active_mm is swapper

Internal error: Oops: 96000004 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 10 Comm: kworker/0:1 Not tainted 5.12.0-rc4+ #2764
Hardware name: Raspberry Pi 3 Model B (DT)
Workqueue: events deferred_probe_work_func
pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--)
pc : of_clk_add_hw_provider+0xac/0xe8
lr : of_clk_add_hw_provider+0x94/0xe8

sp : ffff8000130936b0
x29: ffff8000130936b0 x28: ffff800012494e04
x27: ffff00003b18cb05 x26: ffff00003aa5c010
x25: 0000000000000000 x24: 0000000000000000
x23: ffff00003aa1e380 x22: ffff8000106830d0
x21: ffff80001233f180 x20: 0000000000000018
x19: 0000000000000000 x18: ffff8000124d38b0
x17: 0000000000000013 x16: 0000000000000014
x15: ffff8000125758b0 x14: 00000000000184e0
x13: 000000000000292e x12: ffff80001258dd98
x11: 0000000000000001 x10: 0101010101010101
x9 : ffff80001233f288 x8 : 7f7f7f7f7f7f7f7f
x7 : fefefefeff6c626f x6 : 5d636d8080808080
x5 : 00000000006d635d x4 : 0000000000000000
x3 : 0000000000000000 x2 : 540eb5edae191600
x1 : 0000000000000000 x0 : 0000000000000000

Call trace:
  of_clk_add_hw_provider+0xac/0xe8
  devm_of_clk_add_hw_provider+0x5c/0xb8
  raspberrypi_clk_probe+0x110/0x210
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  device_add+0x47c/0x780
  platform_device_add+0x110/0x248
  platform_device_register_full+0x120/0x150
  rpi_firmware_probe+0x158/0x1f8
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  deferred_probe_work_func+0x70/0xa8
  process_one_work+0x2a8/0x718
  worker_thread+0x48/0x460
  kthread+0x134/0x160
  ret_from_fork+0x10/0x18
Code: b1006294 540000c0 b140069f 54000088 (3940e280)
---[ end trace 7ead5ec2f0c51cfe ]---
Quoted 4 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

Quoted 7 lines

I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock is used, and it's defined and queried later through devm_clk_hw_register_clkdev().

@Marek, I don't mind taking care of it if it's OK with you.

Ah I see this is related to the patch I just reviewed. Can you reference this in the commit text? And instead of putting the change into the clk provider let's check for NULL 'np' in of_clk_add_hw_provider() instead and return 0 if there's nothing to do. That way we don't visit this problem over and over again.

#23 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Hi Stephen,

Quoted 97 lines · Stephen Boyd

Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24)

Quoted 96 lines · Marek Szyprowski
Quoted 85 lines · Tudor Ambarus
Quoted 8 lines

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch, which landed in linux-next as commit 6579c8d97ad7 ("clk:
Mark fwnodes when their clock provider is added") causes the following NULL pointer dereference on Raspberry Pi 3b+ boards:

--->8---

raspberrypi-firmware soc:firmware: Attached to firmware from 2020-01-06T13:05:25

Unable to handle kernel NULL pointer dereference at virtual address
0000000000000050
Mem abort info:
   ESR = 0x96000004
   EC = 0x25: DABT (current EL), IL = 32 bits
   SET = 0, FnV = 0
   EA = 0, S1PTW = 0
Data abort info:
   ISV = 0, ISS = 0x00000004
   CM = 0, WnR = 0
[0000000000000050] user address but active_mm is swapper
Internal error: Oops: 96000004 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 10 Comm: kworker/0:1 Not tainted 5.12.0-rc4+ #2764
Hardware name: Raspberry Pi 3 Model B (DT)
Workqueue: events deferred_probe_work_func
pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--)
pc : of_clk_add_hw_provider+0xac/0xe8
lr : of_clk_add_hw_provider+0x94/0xe8

sp : ffff8000130936b0
x29: ffff8000130936b0 x28: ffff800012494e04
x27: ffff00003b18cb05 x26: ffff00003aa5c010
x25: 0000000000000000 x24: 0000000000000000
x23: ffff00003aa1e380 x22: ffff8000106830d0
x21: ffff80001233f180 x20: 0000000000000018
x19: 0000000000000000 x18: ffff8000124d38b0
x17: 0000000000000013 x16: 0000000000000014
x15: ffff8000125758b0 x14: 00000000000184e0
x13: 000000000000292e x12: ffff80001258dd98
x11: 0000000000000001 x10: 0101010101010101
x9 : ffff80001233f288 x8 : 7f7f7f7f7f7f7f7f
x7 : fefefefeff6c626f x6 : 5d636d8080808080
x5 : 00000000006d635d x4 : 0000000000000000
x3 : 0000000000000000 x2 : 540eb5edae191600
x1 : 0000000000000000 x0 : 0000000000000000

Call trace:
  of_clk_add_hw_provider+0xac/0xe8
  devm_of_clk_add_hw_provider+0x5c/0xb8
  raspberrypi_clk_probe+0x110/0x210
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  device_add+0x47c/0x780
  platform_device_add+0x110/0x248
  platform_device_register_full+0x120/0x150
  rpi_firmware_probe+0x158/0x1f8
  platform_probe+0x90/0xd8
  really_probe+0x108/0x3c0
  driver_probe_device+0x60/0xc0
  __device_attach_driver+0x9c/0xd0
  bus_for_each_drv+0x70/0xc8
  __device_attach+0xec/0x150
  device_initial_probe+0x10/0x18
  bus_probe_device+0x94/0xa0
  deferred_probe_work_func+0x70/0xa8
  process_one_work+0x2a8/0x718
  worker_thread+0x48/0x460
  kthread+0x134/0x160
  ret_from_fork+0x10/0x18
Code: b1006294 540000c0 b140069f 54000088 (3940e280)
---[ end trace 7ead5ec2f0c51cfe ]---
Quoted 4 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock is used, and it's defined and queried later through devm_clk_hw_register_clkdev().

Quoted 8 lines
Quoted 2 lines

@Marek, I don't mind taking care of it if it's OK with you.

Ah I see this is related to the patch I just reviewed. Can you reference this in the commit text? And instead of putting the change into the clk provider let's check for NULL 'np' in of_clk_add_hw_provider() instead and return 0 if there's nothing to do. That way we don't visit this problem over and over again.

I'm not sure the latter is what we reall want: shouldn't calling *of*_clk_add_hw_provider() with a NULL np be a bug in the provider?

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

A message that is not in the archive (sent off-list or not yet received): 161705310317.3012082.15148238105608149214@swboyd.mtv.corp.google.com

#25 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoted 24 lines · Stephen Boyd

Quoting Geert Uytterhoeven (2021-03-26 11:29:55)

Quoted 22 lines · Stephen Boyd
Quoted 20 lines

Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24)

Quoted 6 lines
Quoted 5 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

Quoted 7 lines

I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock is used, and it's defined and queried later through devm_clk_hw_register_clkdev().

@Marek, I don't mind taking care of it if it's OK with you.

Ah I see this is related to the patch I just reviewed. Can you reference this in the commit text? And instead of putting the change into the clk provider let's check for NULL 'np' in of_clk_add_hw_provider() instead and return 0 if there's nothing to do. That way we don't visit this problem over and over again.

Quoted 6 lines
Quoted 3 lines

I'm not sure the latter is what we reall want: shouldn't calling *of*_clk_add_hw_provider() with a NULL np be a bug in the provider?

I don't have a strong opinion either way. Would it be useful if the function returned an error when 'np' is NULL?

I lean towards returning an error. Not a strong opinion either.

-Saravana

Quoted 12 lines

I guess the caller could
use that to figure out that it should register a clkdev. But it shouldn't hurt to register both a clkdev lookup and a DT provider for the same clk. The framework will try the DT path first and then fallback to a clkdev lookup otherwise, so we'll be wasting memory for clkdev but otherwise be fine.

Really it feels like we should try to unify around a devm_clk_add_hw_provider() API that figures out what to do based on if the device has an of_node or not. That would mean implementing something like clkdev but for a whole provider instead of a single clk. Then this question of returning an error would be moot here.

A message that is not in the archive (sent off-list or not yet received): 161706920822.3012082.10047587064612237296@swboyd.mtv.corp.google.com

#27 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Hi Stephen,

Quoted 29 lines · Stephen Boyd

Quoting Saravana Kannan (2021-03-29 16:28:20)

Quoted 28 lines · Stephen Boyd
Quoted 27 lines

Quoting Geert Uytterhoeven (2021-03-26 11:29:55)

Quoted 25 lines · Stephen Boyd
Quoted 12 lines

Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24)

Quoted 11 lines
Quoted 5 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock is used, and it's defined and queried later through devm_clk_hw_register_clkdev().

Quoted 8 lines
Quoted 2 lines

@Marek, I don't mind taking care of it if it's OK with you.

Ah I see this is related to the patch I just reviewed. Can you reference this in the commit text? And instead of putting the change into the clk provider let's check for NULL 'np' in of_clk_add_hw_provider() instead and return 0 if there's nothing to do. That way we don't visit this problem over and over again.

I'm not sure the latter is what we reall want: shouldn't calling *of*_clk_add_hw_provider() with a NULL np be a bug in the provider?

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

I don't have a strong opinion either way. Would it be useful if the function returned an error when 'np' is NULL?

I lean towards returning an error. Not a strong opinion either.

Does it have any use?

of_clk_del_provider() removes the first provider found with node == NULL. If there are two drivers calling of_clk_add_hw_provider(), and one of hem calls of_clk_del_provider() later, the wrong provider may be removed from the list.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

A message that is not in the archive (sent off-list or not yet received): 161715734080.2260335.881350237641202575@swboyd.mtv.corp.google.com

#29 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Hi Stephen,

Quoted 44 lines · Stephen Boyd

Quoting Geert Uytterhoeven (2021-03-29 23:58:23)

Quoted 33 lines · Stephen Boyd
Quoted 32 lines

Quoting Saravana Kannan (2021-03-29 16:28:20)

Quoted 31 lines · Stephen Boyd
Quoted 29 lines

Quoting Geert Uytterhoeven (2021-03-26 11:29:55)

Quoted 16 lines · Stephen Boyd
Quoted 15 lines

Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24)

Quoted 13 lines
Quoted 5 lines

This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL dev->of_node. I'm not sure if adding a check for a NULL np in of_clk_add_hw_provider() is a right fix, though.

I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock is used, and it's defined and queried later through devm_clk_hw_register_clkdev().

@Marek, I don't mind taking care of it if it's OK with you.

Quoted 9 lines
Quoted 5 lines

Ah I see this is related to the patch I just reviewed. Can you reference this in the commit text? And instead of putting the change into the clk provider let's check for NULL 'np' in of_clk_add_hw_provider() instead and return 0 if there's nothing to do. That way we don't visit this problem over and over again.

I'm not sure the latter is what we reall want: shouldn't calling *of*_clk_add_hw_provider() with a NULL np be a bug in the provider?

I don't have a strong opinion either way. Would it be useful if the function returned an error when 'np' is NULL?

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

I lean towards returning an error. Not a strong opinion either.

Does it have any use?

of_clk_del_provider() removes the first provider found with node == NULL. If there are two drivers calling of_clk_add_hw_provider(), and one of hem calls of_clk_del_provider() later, the wrong provider may be removed from the list.

Quoted 5 lines

So you're saying we shouldn't add a NULL device node pointer to the list so that this can't happen? That doesn't mean returning an error from of_clk_add_hw_provider() would be useful though. of_clk_add_hw_provider() can return 0 if np == NULL and of_clk_del_provider() can return early if np == NULL too.

I don't know if I grasp all meanings of the above.

The main question is if it is valid for a driver to call of_clk_add_hw_provider()
with np == NULL.
- If yes, should that register the provider?
- If yes, how to handle two drivers calling of_clk_add_hw_provider() with np = NULL, as their unregistration order is not guaranteed to be correct.

If no, is that something to ignore (0), or a bug (error)?

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

A message that is not in the archive (sent off-list or not yet received): 161721871083.2260335.2392646934517115770@swboyd.mtv.corp.google.com

#31 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoted 36 lines · Stephen Boyd

Quoting Geert Uytterhoeven (2021-03-31 00:05:00)

Quoted 15 lines · Stephen Boyd
Quoted 8 lines
Quoted 7 lines
Quoted 1 line

Does it have any use?

of_clk_del_provider() removes the first provider found with node == NULL. If there are two drivers calling of_clk_add_hw_provider(), and one of hem calls of_clk_del_provider() later, the wrong provider may be removed from the list.

Quoted 5 lines

So you're saying we shouldn't add a NULL device node pointer to the list so that this can't happen? That doesn't mean returning an error from of_clk_add_hw_provider() would be useful though. of_clk_add_hw_provider() can return 0 if np == NULL and of_clk_del_provider() can return early if np == NULL too.

Quoted 6 lines

I don't know if I grasp all meanings of the above.

The main question is if it is valid for a driver to call of_clk_add_hw_provider()
with np == NULL.
  - If yes, should that register the provider?

No it should not register the provider. That would be bad as you pointed out.

Quoted 5 lines

      - If yes, how to handle two drivers calling of_clk_add_hw_provider() with np = NULL, as their unregistration order is not guaranteed to be correct.

If no, is that something to ignore (0), or a bug (error)?

This is my question above. Is there a use to having of_clk_add_hw_provider() return an error value when np == NULL? I doubt it.

Quoted 8 lines

Returning 0 would reduce the if conditions in driver code in this case and be consistent with the CONFIG_OF=n inline stub that returns 0 when CONFIG_OF is disabled. The only case an error would be returned is if we couldn't allocate memory or if the assigned clocks code failed. Seems sane to me. The downside is that drivers would maybe register clkdev lookups when they don't need to and waste some memory. I'm fine with that until we have some sort of non-DT based clk provider lookup mechanism that could unify the two methods.

What about devm_of_clk_add_hw_provider() users, do we care that a seemingly empty managed resource will be created?

Regards,
Nicolas

#32 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

In reply to Tudor Ambarus

Hi,

Quoted 8 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch still causes a crash when booting a raspi2 image in linux-next.

[   21.456500] Unable to handle kernel NULL pointer dereference at virtual address 00000028
[   21.456750] pgd = (ptrval)
[   21.456927] [00000028] *pgd=00000000
[   21.457567] Internal error: Oops: 5 [#1] SMP ARM
[   21.457882] Modules linked in:
[   21.458077] CPU: 0 PID: 77 Comm: kworker/u8:10 Not tainted 5.12.0-rc8-next-20210420 #1
[   21.458291] Hardware name: BCM2835
[   21.458525] Workqueue: events_unbound deferred_probe_work_func
[   21.458997] PC is at of_clk_add_hw_provider+0xbc/0xe8
[   21.459176] LR is at of_clk_add_hw_provider+0xa8/0xe8
...
[   21.477603] [<c0a32aec>] (of_clk_add_hw_provider) from [<c0a32b60>] (devm_of_clk_add_hw_provider+0x48/0x80)
[   21.477861] [<c0a32b60>] (devm_of_clk_add_hw_provider) from [<c0a471e4>] (raspberrypi_clk_probe+0x260/0x388)
[   21.478087] [<c0a471e4>] (raspberrypi_clk_probe) from [<c0c1c4d0>] (platform_probe+0x5c/0xb8)
[   21.478287] [<c0c1c4d0>] (platform_probe) from [<c0c19d84>] (really_probe+0xf0/0x39c)
[   21.478471] [<c0c19d84>] (really_probe) from [<c0c1a098>] (driver_probe_device+0x68/0xc0)
[   21.478659] [<c0c1a098>] (driver_probe_device) from [<c0c17f54>] (bus_for_each_drv+0x84/0xc8)
[   21.478860] [<c0c17f54>] (bus_for_each_drv) from [<c0c19c20>] (__device_attach+0xec/0x158)
[   21.479050] [<c0c19c20>] (__device_attach) from [<c0c18de8>] (bus_probe_device+0x88/0x90)
[   21.479236] [<c0c18de8>] (bus_probe_device) from [<c0c16a68>] (device_add+0x398/0x8ac)
[   21.479421] [<c0c16a68>] (device_add) from [<c0c1c1b4>] (platform_device_add+0xf0/0x200)
[   21.479607] [<c0c1c1b4>] (platform_device_add) from [<c0c1ccc0>] (platform_device_register_full+0xd0/0x110)
[   21.479836] [<c0c1ccc0>] (platform_device_register_full) from [<c104c130>] (rpi_firmware_probe+0x1a4/0x20c)
[   21.480061] [<c104c130>] (rpi_firmware_probe) from [<c0c1c4d0>] (platform_probe+0x5c/0xb8)
[   21.480255] [<c0c1c4d0>] (platform_probe) from [<c0c19d84>] (really_probe+0xf0/0x39c)
[   21.480437] [<c0c19d84>] (really_probe) from [<c0c1a098>] (driver_probe_device+0x68/0xc0)
[   21.480626] [<c0c1a098>] (driver_probe_device) from [<c0c17f54>] (bus_for_each_drv+0x84/0xc8)
[   21.480829] [<c0c17f54>] (bus_for_each_drv) from [<c0c19c20>] (__device_attach+0xec/0x158)
[   21.481018] [<c0c19c20>] (__device_attach) from [<c0c18de8>] (bus_probe_device+0x88/0x90)
[   21.481205] [<c0c18de8>] (bus_probe_device) from [<c0c192bc>] (deferred_probe_work_func+0x8c/0xbc)
[   21.481413] [<c0c192bc>] (deferred_probe_work_func) from [<c036802c>] (process_one_work+0x268/0x798)
[   21.481624] [<c036802c>] (process_one_work) from [<c0368774>] (worker_thread+0x218/0x4f4)
[   21.481822] [<c0368774>] (worker_thread) from [<c0370f28>] (kthread+0x140/0x174)
[   21.481999] [<c0370f28>] (kthread) from [<c030017c>] (ret_from_fork+0x14/0x38)
[   21.482185] Exception stack(0xc42b7fb0 to 0xc42b7ff8)

Updated bisect log is attached.

Guenter

---
# bad: [50b8b1d699ac313c0a07a3c185ffb23aecab8abb] Add linux-next specific files for 20210419
# good: [bf05bf16c76bb44ab5156223e1e58e26dfe30a88] Linux 5.12-rc8
git bisect start 'HEAD' 'v5.12-rc8'
# good: [c4bb91fc07e59241cde97f913d7a2fbedc248f0d] Merge remote-tracking branch 'crypto/master'
git bisect good c4bb91fc07e59241cde97f913d7a2fbedc248f0d
# good: [f15bbf170b40b48a43ed7076ce9f8ac9380e5752] Merge remote-tracking branch 'edac/edac-for-next' git bisect good f15bbf170b40b48a43ed7076ce9f8ac9380e5752
# bad: [550a78090dcc4061e191312a757a127f0b6e6323] Merge remote-tracking branch 'vfio/next'
git bisect bad 550a78090dcc4061e191312a757a127f0b6e6323
# bad: [9f074d2a7bf49b2c9e1609703757b18de7611aef] Merge remote-tracking branch 'usb/usb-next'
git bisect bad 9f074d2a7bf49b2c9e1609703757b18de7611aef
# good: [855b2fdb7c543c94e7623e6ad0b492f04a5317db] Merge remote-tracking branch 'percpu/for-next'
git bisect good 855b2fdb7c543c94e7623e6ad0b492f04a5317db
# good: [1d08ed588c6a85a35a24c82eb4cf0807ec2b366a] usbip: vudc: fix missing unlock on error in usbip_sockfd_store() git bisect good 1d08ed588c6a85a35a24c82eb4cf0807ec2b366a
# good: [1b7ce8fab5fd0c406dbf165b12d44b301decf589] Merge remote-tracking branch 'ipmi/for-next'
git bisect good 1b7ce8fab5fd0c406dbf165b12d44b301decf589
# good: [fe8e488058c47e9a8a2c85321f7198a0a17b0131] dt-bindings: usb: mtk-xhci: add wakeup interrupt
git bisect good fe8e488058c47e9a8a2c85321f7198a0a17b0131
# bad: [3c652132ce9052e626bf509932fcacfebed1ccb4] platform-msi: fix kernel-doc warnings
git bisect bad 3c652132ce9052e626bf509932fcacfebed1ccb4
# bad: [7f2fac70b729d68a34e5eba8d1fb68eb69b05169] device property: Add test cases for fwnode_property_count_*() APIs git bisect bad 7f2fac70b729d68a34e5eba8d1fb68eb69b05169
# good: [38f087de8947700d3b06d3d1594490e0f611c5d1] devtmpfs: fix placement of complete() call
git bisect good 38f087de8947700d3b06d3d1594490e0f611c5d1
# good: [b6f617df4fa936c1ab1831c2b23563f6c1add6c4] driver core: Update device link status properly for device_bind_driver() git bisect good b6f617df4fa936c1ab1831c2b23563f6c1add6c4
# bad: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added git bisect bad 6579c8d97ad7fc5671ee60234f3b8388abee5f77
# good: [ea718c699055c8566eb64432388a04974c43b2ea] Revert "Revert "driver core: Set fw_devlink=on by default"" git bisect good ea718c699055c8566eb64432388a04974c43b2ea

# first bad commit: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added
#33 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoted 7 lines · Guenter Roeck

Hi,

Quoted 3 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

Quoted 7 lines
Quoted 5 lines

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

This patch still causes a crash when booting a raspi2 image in linux-next.

Stephen,

Can we please just pick any one of the proposed fixes? This bug has been unfixed for so long!

-Saravana

Quoted 74 lines
[   21.456500] Unable to handle kernel NULL pointer dereference at virtual address 00000028
[   21.456750] pgd = (ptrval)
[   21.456927] [00000028] *pgd=00000000
[   21.457567] Internal error: Oops: 5 [#1] SMP ARM
[   21.457882] Modules linked in:
[   21.458077] CPU: 0 PID: 77 Comm: kworker/u8:10 Not tainted 5.12.0-rc8-next-20210420 #1
[   21.458291] Hardware name: BCM2835
[   21.458525] Workqueue: events_unbound deferred_probe_work_func
[   21.458997] PC is at of_clk_add_hw_provider+0xbc/0xe8
[   21.459176] LR is at of_clk_add_hw_provider+0xa8/0xe8
...
[   21.477603] [<c0a32aec>] (of_clk_add_hw_provider) from [<c0a32b60>] (devm_of_clk_add_hw_provider+0x48/0x80)
[   21.477861] [<c0a32b60>] (devm_of_clk_add_hw_provider) from [<c0a471e4>] (raspberrypi_clk_probe+0x260/0x388)
[   21.478087] [<c0a471e4>] (raspberrypi_clk_probe) from [<c0c1c4d0>] (platform_probe+0x5c/0xb8)
[   21.478287] [<c0c1c4d0>] (platform_probe) from [<c0c19d84>] (really_probe+0xf0/0x39c)
[   21.478471] [<c0c19d84>] (really_probe) from [<c0c1a098>] (driver_probe_device+0x68/0xc0)
[   21.478659] [<c0c1a098>] (driver_probe_device) from [<c0c17f54>] (bus_for_each_drv+0x84/0xc8)
[   21.478860] [<c0c17f54>] (bus_for_each_drv) from [<c0c19c20>] (__device_attach+0xec/0x158)
[   21.479050] [<c0c19c20>] (__device_attach) from [<c0c18de8>] (bus_probe_device+0x88/0x90)
[   21.479236] [<c0c18de8>] (bus_probe_device) from [<c0c16a68>] (device_add+0x398/0x8ac)
[   21.479421] [<c0c16a68>] (device_add) from [<c0c1c1b4>] (platform_device_add+0xf0/0x200)
[   21.479607] [<c0c1c1b4>] (platform_device_add) from [<c0c1ccc0>] (platform_device_register_full+0xd0/0x110)
[   21.479836] [<c0c1ccc0>] (platform_device_register_full) from [<c104c130>] (rpi_firmware_probe+0x1a4/0x20c)
[   21.480061] [<c104c130>] (rpi_firmware_probe) from [<c0c1c4d0>] (platform_probe+0x5c/0xb8)
[   21.480255] [<c0c1c4d0>] (platform_probe) from [<c0c19d84>] (really_probe+0xf0/0x39c)
[   21.480437] [<c0c19d84>] (really_probe) from [<c0c1a098>] (driver_probe_device+0x68/0xc0)
[   21.480626] [<c0c1a098>] (driver_probe_device) from [<c0c17f54>] (bus_for_each_drv+0x84/0xc8)
[   21.480829] [<c0c17f54>] (bus_for_each_drv) from [<c0c19c20>] (__device_attach+0xec/0x158)
[   21.481018] [<c0c19c20>] (__device_attach) from [<c0c18de8>] (bus_probe_device+0x88/0x90)
[   21.481205] [<c0c18de8>] (bus_probe_device) from [<c0c192bc>] (deferred_probe_work_func+0x8c/0xbc)
[   21.481413] [<c0c192bc>] (deferred_probe_work_func) from [<c036802c>] (process_one_work+0x268/0x798)
[   21.481624] [<c036802c>] (process_one_work) from [<c0368774>] (worker_thread+0x218/0x4f4)
[   21.481822] [<c0368774>] (worker_thread) from [<c0370f28>] (kthread+0x140/0x174)
[   21.481999] [<c0370f28>] (kthread) from [<c030017c>] (ret_from_fork+0x14/0x38)
[   21.482185] Exception stack(0xc42b7fb0 to 0xc42b7ff8)

Updated bisect log is attached.

Guenter

---
# bad: [50b8b1d699ac313c0a07a3c185ffb23aecab8abb] Add linux-next specific files for 20210419
# good: [bf05bf16c76bb44ab5156223e1e58e26dfe30a88] Linux 5.12-rc8
git bisect start 'HEAD' 'v5.12-rc8'
# good: [c4bb91fc07e59241cde97f913d7a2fbedc248f0d] Merge remote-tracking branch 'crypto/master'
git bisect good c4bb91fc07e59241cde97f913d7a2fbedc248f0d
# good: [f15bbf170b40b48a43ed7076ce9f8ac9380e5752] Merge remote-tracking branch 'edac/edac-for-next' git bisect good f15bbf170b40b48a43ed7076ce9f8ac9380e5752
# bad: [550a78090dcc4061e191312a757a127f0b6e6323] Merge remote-tracking branch 'vfio/next'
git bisect bad 550a78090dcc4061e191312a757a127f0b6e6323
# bad: [9f074d2a7bf49b2c9e1609703757b18de7611aef] Merge remote-tracking branch 'usb/usb-next'
git bisect bad 9f074d2a7bf49b2c9e1609703757b18de7611aef
# good: [855b2fdb7c543c94e7623e6ad0b492f04a5317db] Merge remote-tracking branch 'percpu/for-next'
git bisect good 855b2fdb7c543c94e7623e6ad0b492f04a5317db
# good: [1d08ed588c6a85a35a24c82eb4cf0807ec2b366a] usbip: vudc: fix missing unlock on error in usbip_sockfd_store() git bisect good 1d08ed588c6a85a35a24c82eb4cf0807ec2b366a
# good: [1b7ce8fab5fd0c406dbf165b12d44b301decf589] Merge remote-tracking branch 'ipmi/for-next'
git bisect good 1b7ce8fab5fd0c406dbf165b12d44b301decf589
# good: [fe8e488058c47e9a8a2c85321f7198a0a17b0131] dt-bindings: usb: mtk-xhci: add wakeup interrupt
git bisect good fe8e488058c47e9a8a2c85321f7198a0a17b0131
# bad: [3c652132ce9052e626bf509932fcacfebed1ccb4] platform-msi: fix kernel-doc warnings
git bisect bad 3c652132ce9052e626bf509932fcacfebed1ccb4
# bad: [7f2fac70b729d68a34e5eba8d1fb68eb69b05169] device property: Add test cases for fwnode_property_count_*() APIs git bisect bad 7f2fac70b729d68a34e5eba8d1fb68eb69b05169
# good: [38f087de8947700d3b06d3d1594490e0f611c5d1] devtmpfs: fix placement of complete() call
git bisect good 38f087de8947700d3b06d3d1594490e0f611c5d1
# good: [b6f617df4fa936c1ab1831c2b23563f6c1add6c4] driver core: Update device link status properly for device_bind_driver() git bisect good b6f617df4fa936c1ab1831c2b23563f6c1add6c4
# bad: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added git bisect bad 6579c8d97ad7fc5671ee60234f3b8388abee5f77
# good: [ea718c699055c8566eb64432388a04974c43b2ea] Revert "Revert "driver core: Set fw_devlink=on by default"" git bisect good ea718c699055c8566eb64432388a04974c43b2ea

# first bad commit: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added
#34 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

In reply to Tudor Ambarus
I love your patch! Yet something to improve:

Hi Tudor,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tudor-Ambarus/clk-Mark-fwnodes-when-their-clock-provider-is-added/20210210-195223
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: nds32-randconfig-r014-20210209 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/383fe519868d52331467f2a7f00c0cf258ea142d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tudor-Ambarus/clk-Mark-fwnodes-when-their-clock-provider-is-added/20210210-195223 git checkout 383fe519868d52331467f2a7f00c0cf258ea142d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

drivers/clk/clk.c: In function 'of_clk_add_hw_provider':

>> drivers/clk/clk.c:4595:2: error: implicit declaration of function 'fwnode_dev_initialized'; did you mean 'zone_is_initialized'? [-Werror=implicit-function-declaration]
    4595 |  fwnode_dev_initialized(&np->fwnode, true);
         |  ^~~~~~~~~~~~~~~~~~~~~~
         |  zone_is_initialized

cc1: some warnings being treated as errors

vim +4595 drivers/clk/clk.c

4561
4562 /**
4563 * of_clk_add_hw_provider() - Register a clock provider for a node
4564 * @np: Device node pointer associated with clock provider
4565 * @get: callback for decoding clk_hw
4566 * @data: context pointer for @get callback.
4567 */
4568 int of_clk_add_hw_provider(struct device_node *np,
4569 struct clk_hw *(*get)(struct of_phandle_args *clkspec,
4570 void *data),
4571 void *data)
4572 {
4573 struct of_clk_provider *cp;
4574 int ret;
4575
4576 cp = kzalloc(sizeof(*cp), GFP_KERNEL);
4577 if (!cp)
4578 return -ENOMEM;
4579
4580 cp->node = of_node_get(np);
4581 cp->data = data;
4582 cp->get_hw = get;
4583
4584 mutex_lock(&of_clk_mutex);
4585 list_add(&cp->link, &of_clk_providers);
4586 mutex_unlock(&of_clk_mutex);
4587 pr_debug("Added clk_hw provider from %pOF\n", np);
4588
4589 clk_core_reparent_orphans();
4590
4591 ret = of_clk_set_defaults(np, true);
4592 if (ret < 0)
4593 of_clk_del_provider(np);
4594

> 4595		fwnode_dev_initialized(&np->fwnode, true);

4596
4597 return ret;
4598 }
4599 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
4600

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#35 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoted 6 lines · kernel test robot

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hi Tudor,

I love your patch! Yet something to improve:

Quoted 8 lines

[auto build test ERROR on clk/clk-next]
[also build test ERROR on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tudor-Ambarus/clk-Mark-fwnodes-when-their-clock-provider-is-added/20210210-195223
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next

The base of the patch is:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-next

We are fine.

Cheers,
ta

Quoted 72 lines

config: nds32-randconfig-r014-20210209 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/383fe519868d52331467f2a7f00c0cf258ea142d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tudor-Ambarus/clk-Mark-fwnodes-when-their-clock-provider-is-added/20210210-195223 git checkout 383fe519868d52331467f2a7f00c0cf258ea142d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

drivers/clk/clk.c: In function 'of_clk_add_hw_provider':

Quoted 1 line
Quoted 1 line

drivers/clk/clk.c:4595:2: error: implicit declaration of function 'fwnode_dev_initialized'; did you mean 'zone_is_initialized'? [-Werror=implicit-function-declaration]

    4595 |  fwnode_dev_initialized(&np->fwnode, true);
         |  ^~~~~~~~~~~~~~~~~~~~~~
         |  zone_is_initialized

cc1: some warnings being treated as errors

vim +4595 drivers/clk/clk.c

4561
4562 /**

  4563   * of_clk_add_hw_provider() - Register a clock provider for a node
  4564   * @np: Device node pointer associated with clock provider
  4565   * @get: callback for decoding clk_hw
  4566   * @data: context pointer for @get callback.
  4567   */
  4568  int of_clk_add_hw_provider(struct device_node *np,
  4569                             struct clk_hw *(*get)(struct of_phandle_args *clkspec,
  4570                                                   void *data),
  4571                             void *data)
  4572  {
  4573          struct of_clk_provider *cp;
  4574          int ret;
  4575
  4576          cp = kzalloc(sizeof(*cp), GFP_KERNEL);
  4577          if (!cp)
  4578                  return -ENOMEM;
  4579
  4580          cp->node = of_node_get(np);
  4581          cp->data = data;
  4582          cp->get_hw = get;
  4583
  4584          mutex_lock(&of_clk_mutex);
  4585          list_add(&cp->link, &of_clk_providers);
  4586          mutex_unlock(&of_clk_mutex);
  4587          pr_debug("Added clk_hw provider from %pOF\n", np);

4588
4589 clk_core_reparent_orphans();
4590
4591 ret = of_clk_set_defaults(np, true);
4592 if (ret < 0)
4593 of_clk_del_provider(np);
4594

Quoted 1 line

4595 fwnode_dev_initialized(&np->fwnode, true);

4596
4597 return ret;
4598 }
4599 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider); 4600

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

author Reviewed-by on v1 1/1
#36 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

In reply to Tudor Ambarus
Quoted 7 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

Thanks Tudor! Good catch!

I checked to make sure the deregistration path undoes this one. So, it looks good to me.

-Saravana

Quoted 22 lines
---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/clk.c +2 -1
index 27ff90eacb1f..9370e4dfecae 100644
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
        if (ret < 0)
                of_clk_del_provider(np);
 
+       fwnode_dev_initialized(&np->fwnode, true);
+
        return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
--

2.25.1

#37 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

In reply to Tudor Ambarus
Quoted 18 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/clk.c +0 -0
index 27ff90eacb1f..9370e4dfecae 100644

drivers/clk/clk.c int of_clk_add_hw_provider(struct device_node *np, · line 4598

Quoted 5 lines
drivers/clk/clk.c +2 -0
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
 	if (ret < 0)
 		of_clk_del_provider(np);
 
+	fwnode_dev_initialized(&np->fwnode, true);
+

This causes a crash when booting raspi2 images in qemu.

[   22.123618] Unable to handle kernel NULL pointer dereference at virtual address 00000028
[   22.123830] pgd = (ptrval)
[   22.123992] [00000028] *pgd=00000000
[   22.124579] Internal error: Oops: 5 [#1] SMP ARM
...
[   22.141624] [<c0a2f4d8>] (of_clk_add_hw_provider) from [<c0a2f54c>] (devm_of_clk_add_hw_provider+0x48/0x80)
[   22.141819] [<c0a2f54c>] (devm_of_clk_add_hw_provider) from [<c0a43ad8>] (raspberrypi_clk_probe+0x25c/0x384)
[   22.141976] [<c0a43ad8>] (raspberrypi_clk_probe) from [<c0c18da0>] (platform_probe+0x5c/0xb8)
[   22.142114] [<c0c18da0>] (platform_probe) from [<c0c16654>] (really_probe+0xf0/0x39c)
[   22.142246] [<c0c16654>] (really_probe) from [<c0c16968>] (driver_probe_device+0x68/0xc0)
[   22.142377] [<c0c16968>] (driver_probe_device) from [<c0c14834>] (bus_for_each_drv+0x84/0xc8)...

np can (and will) be NULL here. See of_clk_set_defaults().

Guenter

---
Bisect log:

# bad: [9d49ed9ca93b8c564033c1d6808017bc9052b5db] Add linux-next specific files for 20210329
# good: [0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b] Linux 5.12-rc4
git bisect start 'HEAD' 'v5.12-rc4'
# good: [4b15c5b50e5ec7f2d80275d5a150807b7b9a0a0c] Merge remote-tracking branch 'crypto/master' git bisect good 4b15c5b50e5ec7f2d80275d5a150807b7b9a0a0c
# good: [c92ad2dfc1a3bc31afc3d41af82c38accf2c3783] Merge remote-tracking branch 'ftrace/for-next' git bisect good c92ad2dfc1a3bc31afc3d41af82c38accf2c3783
# bad: [103c8000962c33e274244a02a0383d20fab734c9] Merge remote-tracking branch 'staging/staging-next' git bisect bad 103c8000962c33e274244a02a0383d20fab734c9
# bad: [05ee9b17ef7af7d47395caa48db55d0e2dae64a2] Merge remote-tracking branch 'tty/tty-next'
git bisect bad 05ee9b17ef7af7d47395caa48db55d0e2dae64a2
# good: [bd91c862df59c0290c8a2e2ee6467c0ed5fb6432] Merge remote-tracking branch 'workqueues/for-next' git bisect good bd91c862df59c0290c8a2e2ee6467c0ed5fb6432
# good: [24327c478b2fc17a01b21a4721f35f22a51fe12b] usb: mtu3: drop CONFIG_OF
git bisect good 24327c478b2fc17a01b21a4721f35f22a51fe12b
# bad: [04c49226ac79b3e5bd0f89da69a64ba2e0cccb91] Merge remote-tracking branch 'usb-serial/usb-next' git bisect bad 04c49226ac79b3e5bd0f89da69a64ba2e0cccb91
# good: [21a292d73a6e69f31c57d36288482c40b355daf0] Merge remote-tracking branch 'drivers-x86/for-next' git bisect good 21a292d73a6e69f31c57d36288482c40b355daf0
# bad: [b6688015151857ed3f61fa2344c4b220bc9dc4d7] regulator: qcom_spmi-regulator: Clean-up by using managed work init git bisect bad b6688015151857ed3f61fa2344c4b220bc9dc4d7
# good: [ea718c699055c8566eb64432388a04974c43b2ea] Revert "Revert "driver core: Set fw_devlink=on by default"" git bisect good ea718c699055c8566eb64432388a04974c43b2ea
# bad: [0341ce5443949588e93581b49b934cdde2befbf8] workqueue: Add resource managed version of delayed work init git bisect bad 0341ce5443949588e93581b49b934cdde2befbf8
# bad: [0b8bf06f67191e6a3184802a690d3f521c6d7e78] device property: Sync descriptions of swnode array and group APIs git bisect bad 0b8bf06f67191e6a3184802a690d3f521c6d7e78
# bad: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added git bisect bad 6579c8d97ad7fc5671ee60234f3b8388abee5f77

# first bad commit: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added
#38 lore raw

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

Quoted 40 lines · Guenter Roeck
Quoted 18 lines · Tudor Ambarus

This is a follow-up for:
commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")

The above commit updated the deprecated of_clk_add_provider(), but missed to update the preferred of_clk_add_hw_provider(). Update it now.

---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/clk.c +0 -0
index 27ff90eacb1f..9370e4dfecae 100644

drivers/clk/clk.c int of_clk_add_hw_provider(struct device_node *np, · line 4598

Quoted 5 lines
drivers/clk/clk.c +2 -0
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
      if (ret < 0)
              of_clk_del_provider(np);
 
+     fwnode_dev_initialized(&np->fwnode, true);
+

This causes a crash when booting raspi2 images in qemu.

[   22.123618] Unable to handle kernel NULL pointer dereference at virtual address 00000028
[   22.123830] pgd = (ptrval)
[   22.123992] [00000028] *pgd=00000000
[   22.124579] Internal error: Oops: 5 [#1] SMP ARM
...
[   22.141624] [<c0a2f4d8>] (of_clk_add_hw_provider) from [<c0a2f54c>] (devm_of_clk_add_hw_provider+0x48/0x80)
[   22.141819] [<c0a2f54c>] (devm_of_clk_add_hw_provider) from [<c0a43ad8>] (raspberrypi_clk_probe+0x25c/0x384)
[   22.141976] [<c0a43ad8>] (raspberrypi_clk_probe) from [<c0c18da0>] (platform_probe+0x5c/0xb8)
[   22.142114] [<c0c18da0>] (platform_probe) from [<c0c16654>] (really_probe+0xf0/0x39c)
[   22.142246] [<c0c16654>] (really_probe) from [<c0c16968>] (driver_probe_device+0x68/0xc0)
[   22.142377] [<c0c16968>] (driver_probe_device) from [<c0c14834>] (bus_for_each_drv+0x84/0xc8)...
Quoted 1 line

np can (and will) be NULL here. See of_clk_set_defaults().

Thanks for the report. It was reported earlier by Marek and there's a discussion going on about it in the thread.

-Saravana

A message that is not in the archive (sent off-list or not yet received): 161317679292.1254594.15797939257637374295@swboyd.mtv.corp.google.com

#40 lore raw

Re: [PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed

Quoted 11 lines · Stephen Boyd

Quoting Saravana Kannan (2021-02-05 14:26:44)

Quoted 5 lines

This allows fw_devlink to recognize clock provider drivers that don't use the device-driver model to initialize the device. fw_devlink will use this information to make sure consumers of such clock providers aren't indefinitely blocked from probing, waiting for the power domain device to appear and bind to a driver.

The "power domain" part of this commit text doesn't make any sense. Is it copy/pasted from some other patch? Should probably say "waiting for the clk providing device"?

Yeah, copy-pasta.

Quoted 6 lines
Quoted 4 lines

---

Thanks,
Saravana

#41 lore raw
In reply to Saravana Kannan
Quoted 16 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Quoted 8 lines

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Forgot to add version history:

v1 -> v2:
Patch 1: Added a flag to fwnodes that aren't devices.
Patch 3: New patch to ise the flag set in patch 1 to not create bad links.

v2 -> v3:
- Patch 1: Added Rafael's Ack
- New patches 3 and 4

v3 -> v4:
- No changes to patches 1-4.
- New patches 5-8.

-Saravana

Quoted 23 lines

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

 .../admin-guide/kernel-parameters.txt         |  5 ++
 drivers/base/core.c                           | 58 ++++++++++++++++++-
 drivers/base/power/domain.c                   |  2 +
 drivers/clk/clk.c                             |  3 +
 drivers/of/property.c                         | 16 +++--
 include/linux/fwnode.h                        | 20 ++++++-
 kernel/irq/irqdomain.c                        |  2 +
 7 files changed, 98 insertions(+), 8 deletions(-)

--
2.30.0.478.g8a0d178c01-goog

#42 lore raw
In reply to Saravana Kannan

Hi Saravana,

Quoted 7 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Thanks for your series!

Quoted 9 lines

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

I take it this is an automatic alternative for letting drivers set the OF_POPULATED flag manually?

Is this actually safe? It's not uncommon for a driver to register multiple providers, sometimes even of different types (clock, genpd, irq, reset[1], ...).
Can you be sure consumer drivers do not start probing while their dependency is still busy registering providers?

[1] Which brings my attention to the fact that devlink does not consider "resets" properties yet.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#43 lore raw
Quoted 19 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 7 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Thanks for your series!

Quoted 4 lines

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Quoted 7 lines
Quoted 4 lines

driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

I take it this is an automatic alternative for letting drivers set the OF_POPULATED flag manually?

The frameworks can still continue setting it to avoid creating dead "struct devices" that'll never be used. This new flag handles cases where the device is already created, but will never bind to a driver. So, they are meant to do slightly different things, but the end result is removing the need for individual drivers to set OF_POPULATED (and Rob hates that too).

Quoted 3 lines

Is this actually safe? It's not uncommon for a driver to register multiple providers, sometimes even of different types (clock, genpd, irq, reset[1], ...).

This flag is just an indication that the fwnode has been initialized by a driver. It's okay if the flag gets set multiple times when a driver is registering with multiple frameworks. It's also okay if the flag is cleared multiple times as the driver is uninitializing the hardware (although, this is very unlikely for drivers that don't use device-driver model). When we actually try to create device links, we just check if this happened without a driver actually binding to this device. There's no "probing" race because the "status" I check goes through NO_DRIVER -> PROBING -(registering happens)-> BOUND -> UNBINDING -(deregistering happens) -> NO_DRIVER. So if the fwnode flag is getting set as part of the driver's probe function, the "status" value will never be NO_DRIVER.

Quoted 2 lines

Can you be sure consumer drivers do not start probing while their dependency is still busy registering providers?

The code only acts on that flag when trying to create device links from the consumer to the supplier. This is just a way to tell "hey, don't bother creating a device link, this supplier will never bind". So it just avoids blocking the consumer. Doesn't really make the consumers probe earlier than they would have.

Quoted 3 lines

[1] Which brings my attention to the fact that devlink does not consider "resets" properties yet.

Yeah, we can add that and other bindings as we go.

-Saravana

Tested-by on the v4 series
#44 lore raw
In reply to Saravana Kannan

Hi Saravana,

Quoted 13 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Quoted 6 lines

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

This patchset fixes probing issue observed on various Exynos based boards even with commit c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") reverted. Thanks!

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
#45 lore raw
Quoted 22 lines · Marek Szyprowski

Hi Saravana,

Quoted 18 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Quoted 8 lines
Quoted 1 line

Patch 6 through 8 update different frameworks to use the new API.

This patchset fixes probing issue observed on various Exynos based boards even with commit c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") reverted. Thanks!

Thanks for testing!

-Saravana

#46 lore raw
In reply to Saravana Kannan

Hi, Saravana,

Quoted 34 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

Quoted 9 lines
 .../admin-guide/kernel-parameters.txt         |  5 ++
 drivers/base/core.c                           | 58 ++++++++++++++++++-
 drivers/base/power/domain.c                   |  2 +
 drivers/clk/clk.c                             |  3 +
 drivers/of/property.c                         | 16 +++--
 include/linux/fwnode.h                        | 20 ++++++-
 kernel/irq/irqdomain.c                        |  2 +
 7 files changed, 98 insertions(+), 8 deletions(-)

Even with this patch set applied, sama5d2_xplained can not boot. Patch at [1] makes sama5d2_xplained boot again. Stephen applied it to clk-next.

Cheers,
ta

[1] https://lore.kernel.org/lkml/[email protected]/

#47 lore raw
Quoted 48 lines · On Wed, Feb 10, 2021 at 12:19 AM <[email protected]> wrote:

Hi, Saravana,

Quoted 34 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

Quoted 9 lines
 .../admin-guide/kernel-parameters.txt         |  5 ++
 drivers/base/core.c                           | 58 ++++++++++++++++++-
 drivers/base/power/domain.c                   |  2 +
 drivers/clk/clk.c                             |  3 +
 drivers/of/property.c                         | 16 +++--
 include/linux/fwnode.h                        | 20 ++++++-
 kernel/irq/irqdomain.c                        |  2 +
 7 files changed, 98 insertions(+), 8 deletions(-)
Quoted 3 lines

Even with this patch set applied, sama5d2_xplained can not boot. Patch at [1] makes sama5d2_xplained boot again. Stephen applied it to clk-next.

I'm glad you won't actually have any boot issues in 5.12, but the fact you need [1] with this series doesn't make a lot of sense to me because:

1. The FWNODE_FLAG_INITIALIZED flag will be set for the clock fwnode in question way before any consumer devices are added.
2. Any consumer device added after (1) will stop trying to link to the clock device.

Are you somehow adding a consumer to the clock fwnode before (1)?

Can you try this patch without your clk fix? I was trying to avoid looping through a list, but looks like your case might somehow need it?

-Saravana

+++ b/drivers/base/core.c
@@ -943,6 +943,31 @@ static void device_links_missing_supplier(struct device *dev)

        }

}

+static int fw_devlink_check_suppliers(struct device *dev) +{
+ struct fwnode_link *link;
+ int ret = 0;
+
+ if (!dev->fwnode ||fw_devlink_is_permissive())
+ return 0;
+
+ /*

+        * Device waiting for supplier to become available is not allowed to
+        * probe.
+        */

+ mutex_lock(&fwnode_link_lock);
+ list_for_each_entry(link, &dev->fwnode->suppliers, c_hook) {
+ if (link->supplier->flags & FWNODE_FLAG_INITIALIZED)
+ continue;
+
+ ret = -EPROBE_DEFER;
+ break;
+ }
+ mutex_unlock(&fwnode_link_lock);
+
+ return ret;
+}
+
/**
* device_links_check_suppliers - Check presence of supplier drivers.
* @dev: Consumer device.
@@ -964,21 +989,13 @@ int device_links_check_suppliers(struct device *dev)

        struct device_link *link;
        int ret = 0;

- /*

-        * Device waiting for supplier to become available is not allowed to
-        * probe.
-        */
-       mutex_lock(&fwnode_link_lock);
-       if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) &&
-           !fw_devlink_is_permissive()) {
+       if (fw_devlink_check_suppliers(dev)) {
                dev_dbg(dev, "probe deferral - wait for supplier %pfwP\n",
                        list_first_entry(&dev->fwnode->suppliers,
                        struct fwnode_link,
                        c_hook)->supplier);
-               mutex_unlock(&fwnode_link_lock);
                return -EPROBE_DEFER;
        }

- mutex_unlock(&fwnode_link_lock);

        device_links_write_lock();
Quoted 5 lines

Cheers,
ta

[1] https://lore.kernel.org/lkml/[email protected]/

#48 lore raw
Quoted 55 lines · Saravana Kannan

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 48 lines · On Wed, Feb 10, 2021 at 12:19 AM <[email protected]> wrote:

Hi, Saravana,

Quoted 34 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

Quoted 9 lines
 .../admin-guide/kernel-parameters.txt         |  5 ++
 drivers/base/core.c                           | 58 ++++++++++++++++++-
 drivers/base/power/domain.c                   |  2 +
 drivers/clk/clk.c                             |  3 +
 drivers/of/property.c                         | 16 +++--
 include/linux/fwnode.h                        | 20 ++++++-
 kernel/irq/irqdomain.c                        |  2 +
 7 files changed, 98 insertions(+), 8 deletions(-)
Quoted 3 lines

Even with this patch set applied, sama5d2_xplained can not boot. Patch at [1] makes sama5d2_xplained boot again. Stephen applied it to clk-next.

Quoted 6 lines

I'm glad you won't actually have any boot issues in 5.12, but the fact you need [1] with this series doesn't make a lot of sense to me because:

1. The FWNODE_FLAG_INITIALIZED flag will be set for the clock fwnode in question way before any consumer devices are added.

Looks like in my case FWNODE_FLAG_INITIALIZED is not set, because drivers/clk/at91/sama5d2.c uses of_clk_add_hw_provider().

Quoted 9 lines

2. Any consumer device added after (1) will stop trying to link to the clock device.

Are you somehow adding a consumer to the clock fwnode before (1)?

Can you try this patch without your clk fix? I was trying to avoid looping through a list, but looks like your case might somehow need it?

I tried it, didn't solve my boot problem. The following patch makes the sama5d2_xplained boot again, even without the patch from [1]:

drivers/clk/clk.c +2 -0
index 27ff90eacb1f..9370e4dfecae 100644
@@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np,
        if (ret < 0)
                of_clk_del_provider(np);
 
+       fwnode_dev_initialized(&np->fwnode, true);
+
        return ret;
 }
 EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);

Cheers,
ta

Quoted 66 lines
(quoted diff) +26 -1
-Saravana
 
+++ b/drivers/base/core.c
@@ -943,6 +943,31 @@ static void device_links_missing_supplier(struct
 device *dev)
        }
 }
 
+static int fw_devlink_check_suppliers(struct device *dev)
+{
+       struct fwnode_link *link;
+       int ret = 0;
+
+       if (!dev->fwnode ||fw_devlink_is_permissive())
+               return 0;
+
+       /*
+        * Device waiting for supplier to become available is not allowed to
+        * probe.
+        */
+       mutex_lock(&fwnode_link_lock);
+       list_for_each_entry(link, &dev->fwnode->suppliers, c_hook) {
+               if (link->supplier->flags & FWNODE_FLAG_INITIALIZED)
+                       continue;
+
+               ret = -EPROBE_DEFER;
+               break;
+       }
+       mutex_unlock(&fwnode_link_lock);
+
+       return ret;
+}
+
 /**
  * device_links_check_suppliers - Check presence of supplier drivers.

* @dev: Consumer device.

(quoted diff) +1 -9
@@ -964,21 +989,13 @@ int device_links_check_suppliers(struct device *dev)
        struct device_link *link;
        int ret = 0;
 
-       /*
-        * Device waiting for supplier to become available is not allowed to
-        * probe.
-        */
-       mutex_lock(&fwnode_link_lock);
-       if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) &&
-           !fw_devlink_is_permissive()) {
+       if (fw_devlink_check_suppliers(dev)) {
                dev_dbg(dev, "probe deferral - wait for supplier %pfwP\n",
                        list_first_entry(&dev->fwnode->suppliers,
                        struct fwnode_link,
                        c_hook)->supplier);
-               mutex_unlock(&fwnode_link_lock);
                return -EPROBE_DEFER;
        }
-       mutex_unlock(&fwnode_link_lock);
 
        device_links_write_lock();
 
Quoted 7 lines

Cheers,
ta

[1] https://lore.kernel.org/lkml/[email protected]/

#49 lore raw
Quoted 61 lines · On Wed, Feb 10, 2021 at 2:02 AM <[email protected]> wrote:
Quoted 59 lines · Saravana Kannan

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 48 lines · On Wed, Feb 10, 2021 at 12:19 AM <[email protected]> wrote:

Hi, Saravana,

Quoted 34 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

Quoted 9 lines
 .../admin-guide/kernel-parameters.txt         |  5 ++
 drivers/base/core.c                           | 58 ++++++++++++++++++-
 drivers/base/power/domain.c                   |  2 +
 drivers/clk/clk.c                             |  3 +
 drivers/of/property.c                         | 16 +++--
 include/linux/fwnode.h                        | 20 ++++++-
 kernel/irq/irqdomain.c                        |  2 +
 7 files changed, 98 insertions(+), 8 deletions(-)
Quoted 3 lines

Even with this patch set applied, sama5d2_xplained can not boot. Patch at [1] makes sama5d2_xplained boot again. Stephen applied it to clk-next.

I'm glad you won't actually have any boot issues in 5.12, but the fact you need [1] with this series doesn't make a lot of sense to me because:

Quoted 5 lines
Quoted 2 lines

1. The FWNODE_FLAG_INITIALIZED flag will be set for the clock fwnode in question way before any consumer devices are added.

Looks like in my case FWNODE_FLAG_INITIALIZED is not set, because drivers/clk/at91/sama5d2.c uses of_clk_add_hw_provider().

Ah, that explains it.

Quoted 11 lines
Quoted 9 lines

2. Any consumer device added after (1) will stop trying to link to the clock device.

Are you somehow adding a consumer to the clock fwnode before (1)?

Can you try this patch without your clk fix? I was trying to avoid looping through a list, but looks like your case might somehow need it?

I tried it, didn't solve my boot problem.

Thanks! I should stop coding past midnight!

Quoted 2 lines

The following patch makes the
sama5d2_xplained boot again, even without the patch from [1]:

Great! I gave a reviewed-by.

-Saravana

#50 lore raw
In reply to Saravana Kannan

Hi Saravana,

Quoted 23 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Quoted 10 lines

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

Thanks for your series, which is now part of driver-core-next. I gave driver-core-next + [1] a try on various Renesas boards. Test results are below.
In general, the result looks much better than before.

[1] - https://lore.kernel.org/lkml/[email protected]/

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

- Some devices are reprobed, despite their drivers returning a real error code, and not -EPROBE_DEFER:

renesas_wdt e6020000.watchdog: Watchdog blacklisted on r8a7791 ES1.* (rwdt_probe() returns -ENODEV)

sh-pfc e6060000.pinctrl: pin GP_7_23 already requested by
ee090000.pci; cannot claim for e6590000.usb

            sh-pfc e6060000.pinctrl: pin-247 (e6590000.usb) status -22
            sh-pfc e6060000.pinctrl: could not request pin 247
(GP_7_23) from group usb0  on device sh-pfc
            renesas_usbhs e6590000.usb: Error applying setting,
reverse things back
            renesas_usbhs: probe of e6590000.usb failed with error -22

            rcar-pcie fe000000.pcie: host bridge /soc/pcie@fe000000 ranges:
            rcar-pcie fe000000.pcie:       IO
0x00fe100000..0x00fe1fffff -> 0x0000000000
            rcar-pcie fe000000.pcie:      MEM
0x00fe200000..0x00fe3fffff -> 0x00fe200000
            rcar-pcie fe000000.pcie:      MEM
0x0030000000..0x0037ffffff -> 0x0030000000
            rcar-pcie fe000000.pcie:      MEM
0x0038000000..0x003fffffff -> 0x0038000000
            rcar-pcie fe000000.pcie:   IB MEM
0x0040000000..0x00bfffffff -> 0x0040000000
            rcar-pcie fe000000.pcie:   IB MEM

0x0200000000..0x02ffffffff -> 0x0200000000
rcar-pcie fe000000.pcie: PCIe link down (rcar_pcie_probe() returns -ENODEV)

xhci-hcd ee000000.usb: xHCI Host Controller
xhci-hcd ee000000.usb: new USB bus registered, assigned bus number 7 xhci-hcd ee000000.usb: Direct firmware load for
r8a779x_usb3_v3.dlmem failed with error -2
xhci-hcd ee000000.usb: can't setup: -2
xhci-hcd ee000000.usb: USB bus 7 deregistered
xhci-hcd: probe of ee000000.usb failed with error -2

- The PCI reprobing leads to a memory leak, for which I've sent a fix "[PATCH] PCI: Fix memory leak in pci_register_io_range()"
https://lore.kernel.org/linux-pci/[email protected]/

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

-dma4chan0 | e66d8000.i2c:tx
-dma4chan1 | e66d8000.i2c:rx
-dma5chan0 | e6510000.i2c:tx

- Disabling CONFIG_IPMMU_VMSA (IOMMU) now works, good!

ignoring dependency for device, assuming no driver

- Disabling CONFIG_RCAR_DMAC works for most devices, except for sound:

-rcar_sound ec500000.sound: probed

ALSA device list:
- #0: rcar-sound
+ No soundcards found.

# cat /sys/kernel/debug/devices_deferred 2-0010
sound
ec500000.sound

platform e6510000.i2c: Linked as a sync state only
consumer to ec500000.sound
platform ec500000.sound: Linked as a consumer to e6060000.pinctrl platform ec500000.sound: Linked as a consumer to
e6150000.clock-controller

            i2c 2-0010: Linked as a consumer to ec500000.sound
            platform ec500000.sound: Linked as a consumer to 2-004f
            cs2000-cp 2-004f: revision - C1
            i2c-rcar e6510000.i2c: probed
            i2c-rcar e6510000.i2c: Dropping the link to ec500000.sound
            i2c 2-0010: probe deferral - supplier ec500000.sound not ready

        With CONFIG_RCAR_DMAC=y, ec500000.sound is probed quite early.

            arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts

            ak4613: codec@10 {
                    clocks = <&rcar_sound 3>;

                    port {
                            ak4613_endpoint: endpoint {
                                    remote-endpoint = <&rsnd_endpoint0>;
                            };
                    };
            };

            sound_card: sound {
                    dais = <&rsnd_port0     /* ak4613 */
                            &rsnd_port1     /* HDMI0  */
                            &rsnd_port2>;   /* HDMI1  */
            };

            rcar_sound: sound@ec500000 {
                    ports {
                            rsnd_port0: port@0 {
                                    rsnd_endpoint0: endpoint {
                                            remote-endpoint =
<&ak4613_endpoint>;
                                    }
                            }
                    }
            };

2. SH/R-Mobile AG5 (kzm9g), APE6 (ape6evm), A1 (armadillo800-eva)

- "PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling" is no longer needed
https://lore.kernel.org/linux-arm-kernel/[email protected]/

- On R-Mobile A1, I get a BUG and a memory leak:

BUG: spinlock bad magic on CPU#0, swapper/1
lock: lcdc0_device+0x10c/0x308, .magic: 00000000, .owner:
<none>/-1, .owner_cpu: 0

            CPU: 0 PID: 1 Comm: swapper Not tainted
5.11.0-rc5-armadillo-00032-gf0a85c26907e #266
            Hardware name: Generic R8A7740 (Flattened Device Tree)
            [<c010c3c8>] (unwind_backtrace) from [<c010a49c>]
(show_stack+0x10/0x14)
            [<c010a49c>] (show_stack) from [<c0159534>]
(do_raw_spin_lock+0x20/0x94)
            [<c0159534>] (do_raw_spin_lock) from [<c04089d8>]
(dev_pm_get_subsys_data+0x30/0xa0)
            [<c04089d8>] (dev_pm_get_subsys_data) from [<c0413698>]
(genpd_add_device+0x34/0x1c0)
            [<c0413698>] (genpd_add_device) from [<c041389c>]
(of_genpd_add_device+0x34/0x4c)
            [<c041389c>] (of_genpd_add_device) from [<c0a1e9bc>]
(board_staging_register_device+0xf8/0x118)
            [<c0a1e9bc>] (board_staging_register_device) from
[<c0a1ea00>] (board_staging_register_devices+0x24/0x28)
            [<c0a1ea00>] (board_staging_register_devices) from
[<c0a1ea30>] (runtime_board_check+0x2c/0x40)
            [<c0a1ea30>] (runtime_board_check) from [<c0101fac>]
(do_one_initcall+0xe0/0x278)
            [<c0101fac>] (do_one_initcall) from [<c0a01034>]
(kernel_init_freeable+0x174/0x1c0)
            [<c0a01034>] (kernel_init_freeable) from [<c05fd568>]
(kernel_init+0x8/0x118)
            [<c05fd568>] (kernel_init) from [<c010011c>]
(ret_from_fork+0x14/0x38)
            Exception stack(0xc19c9fb0 to 0xc19c9ff8)
            9fa0:                                     00000000
00000000 00000000 00000000
            9fc0: 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000
            9fe0: 00000000 00000000 00000000 00000000 00000013 00000000

            unreferenced object 0xc4134e00 (size 512):
              comm "swapper", pid 1, jiffies 4294937296 (age 3541.930s)
              hex dump (first 32 bytes):
                00 4e 13 c4 00 4e 13 c4 ff ff ff 7f ff ff ff 7f
.N...N..........
                ff ff ff 7f 02 00 00 00 00 5f 13 c4 1c 4e 13 c4
........._...N..
              backtrace:
                [<de1a3c34>] dev_pm_qos_constraints_allocate+0x10/0xcc
                [<d21cf6e4>] dev_pm_qos_add_notifier+0x6c/0xd0
                [<e04bbc90>] genpd_add_device+0x178/0x1c0
                [<95067303>] of_genpd_add_device+0x34/0x4c
                [<c334b97a>] board_staging_register_device+0xf8/0x118
                [<01bd495a>] board_staging_register_devices+0x24/0x28
                [<fb25a5d8>] runtime_board_check+0x2c/0x40
                [<65aed679>] do_one_initcall+0xe0/0x278
                [<97e3f4f7>] kernel_init_freeable+0x174/0x1c0
                [<63c8fed0>] kernel_init+0x8/0x118
                [<f704d96c>] ret_from_fork+0x14/0x38
                [<00000000>] 0x0

3. RZ/A1 and RZ/A2: No issues.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#51 lore raw

Hi Saravana,

Quoted 2 lines · Geert Uytterhoeven

- Disabling CONFIG_RCAR_DMAC works for most devices, except for sound:

Please ignore. DMA is mandatory for sound, and thus fails in the same way on v5.11-rc5.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#52 lore raw
In reply to Geert Uytterhoeven
Quoted 38 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 23 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

Patch 1 and 2 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will never actually have struct devices added for them. For example, DT nodes with a compatible property that don't have devices added for them.

Patch 3 and 4 allow for handling optional DT bindings.

Patch 5 sets up a generic API to handle drivers that never bind with their devices.

Patch 6 through 8 update different frameworks to use the new API.

Thanks,
Saravana

Quoted 10 lines

Saravana Kannan (8):
driver core: fw_devlink: Detect supplier devices that will never be
added
of: property: Don't add links to absent suppliers
driver core: Add fw_devlink.strict kernel param
of: property: Add fw_devlink support for optional properties driver core: fw_devlink: Handle suppliers that don't use driver core
irqdomain: Mark fwnodes when their irqdomain is added/removed
PM: domains: Mark fwnodes when their powerdomain is added/removed
clk: Mark fwnodes when their clock provider is added/removed

Quoted 2 lines

Thanks for your series, which is now part of driver-core-next. I gave driver-core-next + [1] a try on various Renesas boards.

Thanks!

Quoted 2 lines

Test results are below.
In general, the result looks much better than before.

Ah, good to hear this.

Quoted 7 lines

[1] - https://lore.kernel.org/lkml/[email protected]/

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

Rob doesn't like the proliferation of OF_POPULATED and we don't need it anymore, so maybe work it out with him? It's a balance between some wasted memory (struct device(s)) vs not proliferating OF_POPULATED.

Quoted 2 lines

- Some devices are reprobed, despite their drivers returning a real error code, and not -EPROBE_DEFER:

Sorry, it's not obvious from the logs below where "reprobing" is happening. Can you give more pointers please?

Also, thinking more about this, the only way I could see this happen is:
1. Device fails with error that's not -EPROBE_DEFER
2. It somehow gets added to a device link (with AUTOPROBE_CONSUMER flag) where it's a consumer.
3. The supplier probes and the device gets added to the deferred probe list again.

But I can't see how this sequence can happen. Device links are created only when a device is added. And is the supplier isn't added yet, the consumer wouldn't have probed in the first place.

Other than "annoying waste of time" is this causing any other problems?

Quoted 36 lines
            renesas_wdt e6020000.watchdog: Watchdog blacklisted on r8a7791 ES1.*
            (rwdt_probe() returns -ENODEV)

            sh-pfc e6060000.pinctrl: pin GP_7_23 already requested by
ee090000.pci; cannot claim for e6590000.usb
            sh-pfc e6060000.pinctrl: pin-247 (e6590000.usb) status -22
            sh-pfc e6060000.pinctrl: could not request pin 247
(GP_7_23) from group usb0  on device sh-pfc
            renesas_usbhs e6590000.usb: Error applying setting,
reverse things back
            renesas_usbhs: probe of e6590000.usb failed with error -22

            rcar-pcie fe000000.pcie: host bridge /soc/pcie@fe000000 ranges:
            rcar-pcie fe000000.pcie:       IO
0x00fe100000..0x00fe1fffff -> 0x0000000000
            rcar-pcie fe000000.pcie:      MEM
0x00fe200000..0x00fe3fffff -> 0x00fe200000
            rcar-pcie fe000000.pcie:      MEM
0x0030000000..0x0037ffffff -> 0x0030000000
            rcar-pcie fe000000.pcie:      MEM
0x0038000000..0x003fffffff -> 0x0038000000
            rcar-pcie fe000000.pcie:   IB MEM
0x0040000000..0x00bfffffff -> 0x0040000000
            rcar-pcie fe000000.pcie:   IB MEM

0x0200000000..0x02ffffffff -> 0x0200000000
rcar-pcie fe000000.pcie: PCIe link down (rcar_pcie_probe() returns -ENODEV)

xhci-hcd ee000000.usb: xHCI Host Controller
xhci-hcd ee000000.usb: new USB bus registered, assigned bus number 7 xhci-hcd ee000000.usb: Direct firmware load for
r8a779x_usb3_v3.dlmem failed with error -2
xhci-hcd ee000000.usb: can't setup: -2
xhci-hcd ee000000.usb: USB bus 7 deregistered
xhci-hcd: probe of ee000000.usb failed with error -2

Quoted 3 lines

- The PCI reprobing leads to a memory leak, for which I've sent a fix "[PATCH] PCI: Fix memory leak in pci_register_io_range()"
https://lore.kernel.org/linux-pci/[email protected]/

Wrt PCI reprobing,
1. Is this PCI never expected to probe, but it's being reattempted despite the NOT EPROBE_DEFER error? Or
2. The PCI was deferred probe when it should have probed and then when it's finally reattemped and it could succeed, we are hitting this mem leak issue?

I'm basically trying to distinguish between "this stuff should never be retried" vs "this/it's suppliers got probe deferred with fw_devlink=on vs but didn't get probe deferred with fw_devlink=permissive and that's causing issues"

Quoted 6 lines
      - I2C on R-Car Gen3 does not seem to use DMA, according to
        /sys/kernel/debug/dmaengine/summary:

            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

Quoted 23 lines

- Disabling CONFIG_IPMMU_VMSA (IOMMU) now works, good!

ignoring dependency for device, assuming no driver

- Disabling CONFIG_RCAR_DMAC works for most devices, except for sound:

-rcar_sound ec500000.sound: probed

ALSA device list:
- #0: rcar-sound
+ No soundcards found.

# cat /sys/kernel/debug/devices_deferred 2-0010
sound
ec500000.sound

platform e6510000.i2c: Linked as a sync state only
consumer to ec500000.sound
platform ec500000.sound: Linked as a consumer to e6060000.pinctrl platform ec500000.sound: Linked as a consumer to
e6150000.clock-controller

Quoted 8 lines
            i2c 2-0010: Linked as a consumer to ec500000.sound
            platform ec500000.sound: Linked as a consumer to 2-004f
            cs2000-cp 2-004f: revision - C1
            i2c-rcar e6510000.i2c: probed
            i2c-rcar e6510000.i2c: Dropping the link to ec500000.sound
            i2c 2-0010: probe deferral - supplier ec500000.sound not ready

        With CONFIG_RCAR_DMAC=y, ec500000.sound is probed quite early.

I saw your other reply, so I'll ignore this sound/DMA issue.

Quoted 31 lines
            arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts

            ak4613: codec@10 {
                    clocks = <&rcar_sound 3>;

                    port {
                            ak4613_endpoint: endpoint {
                                    remote-endpoint = <&rsnd_endpoint0>;
                            };
                    };
            };

            sound_card: sound {
                    dais = <&rsnd_port0     /* ak4613 */
                            &rsnd_port1     /* HDMI0  */
                            &rsnd_port2>;   /* HDMI1  */
            };

            rcar_sound: sound@ec500000 {
                    ports {
                            rsnd_port0: port@0 {
                                    rsnd_endpoint0: endpoint {
                                            remote-endpoint =
<&ak4613_endpoint>;
                                    }
                            }
                    }
            };
Quoted 5 lines

2. SH/R-Mobile AG5 (kzm9g), APE6 (ape6evm), A1 (armadillo800-eva)

- "PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling" is no longer needed
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Good to see more evidence that this series is fixing things at a more generic level.

Quoted 51 lines

- On R-Mobile A1, I get a BUG and a memory leak:

BUG: spinlock bad magic on CPU#0, swapper/1
lock: lcdc0_device+0x10c/0x308, .magic: 00000000, .owner:
<none>/-1, .owner_cpu: 0

            CPU: 0 PID: 1 Comm: swapper Not tainted
5.11.0-rc5-armadillo-00032-gf0a85c26907e #266
            Hardware name: Generic R8A7740 (Flattened Device Tree)
            [<c010c3c8>] (unwind_backtrace) from [<c010a49c>]
(show_stack+0x10/0x14)
            [<c010a49c>] (show_stack) from [<c0159534>]
(do_raw_spin_lock+0x20/0x94)
            [<c0159534>] (do_raw_spin_lock) from [<c04089d8>]
(dev_pm_get_subsys_data+0x30/0xa0)
            [<c04089d8>] (dev_pm_get_subsys_data) from [<c0413698>]
(genpd_add_device+0x34/0x1c0)
            [<c0413698>] (genpd_add_device) from [<c041389c>]
(of_genpd_add_device+0x34/0x4c)
            [<c041389c>] (of_genpd_add_device) from [<c0a1e9bc>]
(board_staging_register_device+0xf8/0x118)
            [<c0a1e9bc>] (board_staging_register_device) from
[<c0a1ea00>] (board_staging_register_devices+0x24/0x28)
            [<c0a1ea00>] (board_staging_register_devices) from
[<c0a1ea30>] (runtime_board_check+0x2c/0x40)
            [<c0a1ea30>] (runtime_board_check) from [<c0101fac>]
(do_one_initcall+0xe0/0x278)
            [<c0101fac>] (do_one_initcall) from [<c0a01034>]
(kernel_init_freeable+0x174/0x1c0)
            [<c0a01034>] (kernel_init_freeable) from [<c05fd568>]
(kernel_init+0x8/0x118)
            [<c05fd568>] (kernel_init) from [<c010011c>]
(ret_from_fork+0x14/0x38)
            Exception stack(0xc19c9fb0 to 0xc19c9ff8)
            9fa0:                                     00000000
00000000 00000000 00000000
            9fc0: 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000
            9fe0: 00000000 00000000 00000000 00000000 00000013 00000000

            unreferenced object 0xc4134e00 (size 512):
              comm "swapper", pid 1, jiffies 4294937296 (age 3541.930s)
              hex dump (first 32 bytes):
                00 4e 13 c4 00 4e 13 c4 ff ff ff 7f ff ff ff 7f
.N...N..........
                ff ff ff 7f 02 00 00 00 00 5f 13 c4 1c 4e 13 c4
........._...N..
              backtrace:
                [<de1a3c34>] dev_pm_qos_constraints_allocate+0x10/0xcc
                [<d21cf6e4>] dev_pm_qos_add_notifier+0x6c/0xd0
                [<e04bbc90>] genpd_add_device+0x178/0x1c0
                [<95067303>] of_genpd_add_device+0x34/0x4c
Quoted 8 lines
                [<c334b97a>] board_staging_register_device+0xf8/0x118
                [<01bd495a>] board_staging_register_devices+0x24/0x28
                [<fb25a5d8>] runtime_board_check+0x2c/0x40
                [<65aed679>] do_one_initcall+0xe0/0x278
                [<97e3f4f7>] kernel_init_freeable+0x174/0x1c0
                [<63c8fed0>] kernel_init+0x8/0x118
                [<f704d96c>] ret_from_fork+0x14/0x38
                [<00000000>] 0x0

Hmm... I looked at this in bits and pieces throughout the day. At least spent an hour looking at this. This doesn't make a lot of sense to me. I don't even touch anything in this code path AFAICT. Are modules/kernel mixed up somehow? I need more info before I can help. Does reverting my pm domain change make any difference (assume it boots this far without it).

Quoted 2 lines

3. RZ/A1 and RZ/A2: No issues.

Great!

-Saravana

#53 lore raw

Hi Saravana,

Quoted 10 lines · Saravana Kannan
Quoted 5 lines · Geert Uytterhoeven

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

Rob doesn't like the proliferation of OF_POPULATED and we don't need it anymore, so maybe work it out with him? It's a balance between some wasted memory (struct device(s)) vs not proliferating OF_POPULATED.

Rob: should it be reverted? For v5.13?
I guess other similar "fixes" went in in the mean time.

Quoted 5 lines
Quoted 2 lines

- Some devices are reprobed, despite their drivers returning a real error code, and not -EPROBE_DEFER:

Sorry, it's not obvious from the logs below where "reprobing" is happening. Can you give more pointers please?

My log was indeed not a full log, but just the reprobes happening. I'll send you a full log by private email.

Quoted 10 lines

Also, thinking more about this, the only way I could see this happen is:
1. Device fails with error that's not -EPROBE_DEFER
2. It somehow gets added to a device link (with AUTOPROBE_CONSUMER flag) where it's a consumer.
3. The supplier probes and the device gets added to the deferred probe list again.

But I can't see how this sequence can happen. Device links are created only when a device is added. And is the supplier isn't added yet, the consumer wouldn't have probed in the first place.

The full log doesn't show any evidence of the device being added to a list in between the two probes.

Quoted 1 line

Other than "annoying waste of time" is this causing any other problems?

Probably not. But see below.

Quoted 7 lines
Quoted 3 lines

- The PCI reprobing leads to a memory leak, for which I've sent a fix "[PATCH] PCI: Fix memory leak in pci_register_io_range()"
https://lore.kernel.org/linux-pci/[email protected]/

Wrt PCI reprobing,
1. Is this PCI never expected to probe, but it's being reattempted despite the NOT EPROBE_DEFER error? Or

There is no PCIe card present, so the failure is expected. Later it is reprobed, which of course fails again.

Quoted 3 lines

2. The PCI was deferred probe when it should have probed and then when it's finally reattemped and it could succeed, we are hitting this mem leak issue?

I think the leak has always been there, but it was just exposed by this unneeded reprobe. I don't think a reprobe after that specific error path had ever happened before.

Quoted 4 lines

I'm basically trying to distinguish between "this stuff should never be retried" vs "this/it's suppliers got probe deferred with fw_devlink=on vs but didn't get probe deferred with fw_devlink=permissive and that's causing issues"

There should not be a probe deferral, as no -EPROBE_DEFER was returned.

Quoted 11 lines
Quoted 6 lines
      - I2C on R-Car Gen3 does not seem to use DMA, according to
        /sys/kernel/debug/dmaengine/summary:

            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

Yes, I plan to dig deeper to see what really happens...

Quoted 11 lines
Quoted 3 lines

- On R-Mobile A1, I get a BUG and a memory leak:

BUG: spinlock bad magic on CPU#0, swapper/1

Hmm... I looked at this in bits and pieces throughout the day. At least spent an hour looking at this. This doesn't make a lot of sense to me. I don't even touch anything in this code path AFAICT. Are modules/kernel mixed up somehow? I need more info before I can help. Does reverting my pm domain change make any difference (assume it boots this far without it).

I plan to dig deeper to see what really happens...

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#54 lore raw
Quoted 79 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 10 lines · Saravana Kannan
Quoted 5 lines · Geert Uytterhoeven

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

Rob doesn't like the proliferation of OF_POPULATED and we don't need it anymore, so maybe work it out with him? It's a balance between some wasted memory (struct device(s)) vs not proliferating OF_POPULATED.

Rob: should it be reverted? For v5.13?
I guess other similar "fixes" went in in the mean time.

Quoted 5 lines
Quoted 2 lines

- Some devices are reprobed, despite their drivers returning a real error code, and not -EPROBE_DEFER:

Sorry, it's not obvious from the logs below where "reprobing" is happening. Can you give more pointers please?

My log was indeed not a full log, but just the reprobes happening. I'll send you a full log by private email.

Quoted 10 lines

Also, thinking more about this, the only way I could see this happen is:
1. Device fails with error that's not -EPROBE_DEFER
2. It somehow gets added to a device link (with AUTOPROBE_CONSUMER flag) where it's a consumer.
3. The supplier probes and the device gets added to the deferred probe list again.

But I can't see how this sequence can happen. Device links are created only when a device is added. And is the supplier isn't added yet, the consumer wouldn't have probed in the first place.

The full log doesn't show any evidence of the device being added to a list in between the two probes.

Quoted 1 line

Other than "annoying waste of time" is this causing any other problems?

Probably not. But see below.

Quoted 7 lines
Quoted 3 lines

- The PCI reprobing leads to a memory leak, for which I've sent a fix "[PATCH] PCI: Fix memory leak in pci_register_io_range()"
https://lore.kernel.org/linux-pci/[email protected]/

Wrt PCI reprobing,
1. Is this PCI never expected to probe, but it's being reattempted despite the NOT EPROBE_DEFER error? Or

There is no PCIe card present, so the failure is expected. Later it is reprobed, which of course fails again.

Quoted 3 lines

2. The PCI was deferred probe when it should have probed and then when it's finally reattemped and it could succeed, we are hitting this mem leak issue?

I think the leak has always been there, but it was just exposed by this unneeded reprobe. I don't think a reprobe after that specific error path had ever happened before.

Quoted 4 lines

I'm basically trying to distinguish between "this stuff should never be retried" vs "this/it's suppliers got probe deferred with fw_devlink=on vs but didn't get probe deferred with fw_devlink=permissive and that's causing issues"

There should not be a probe deferral, as no -EPROBE_DEFER was returned.

Quoted 7 lines
Quoted 6 lines
      - I2C on R-Car Gen3 does not seem to use DMA, according to
        /sys/kernel/debug/dmaengine/summary:

            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx
Quoted 6 lines
Quoted 4 lines

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

Yes, I plan to dig deeper to see what really happens...

Try fw_devlink.strict (you'll need IOMMU enabled too). If that fixes it and you also don't see this issue with fw_devlink=permissive, then it means there's probably some unnecessary probe deferral that we should try to avoid. At least, that's my hunch right now.

Thanks,
Saravana

Quoted 25 lines
Quoted 6 lines
Quoted 4 lines

- On R-Mobile A1, I get a BUG and a memory leak:

BUG: spinlock bad magic on CPU#0, swapper/1

Quoted 6 lines

Hmm... I looked at this in bits and pieces throughout the day. At least spent an hour looking at this. This doesn't make a lot of sense to me. I don't even touch anything in this code path AFAICT. Are modules/kernel mixed up somehow? I need more info before I can help. Does reverting my pm domain change make any difference (assume it boots this far without it).

I plan to dig deeper to see what really happens...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#55 lore raw
In reply to Saravana Kannan

Hi Saravana,

Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

More detailed log:

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller
platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver. Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#56 lore raw
Quoted 17 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

Quoted 6 lines

More detailed log:

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

Because fw_devlink.strict=1 is not set and dma/iommu is considered an "optional"/"driver decides" dependency.

Quoted 2 lines

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller

Is this the only supplier of dma-controller?

Quoted 48 lines

platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

Quoted 7 lines

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

This seems like a race? I'm guessing it's two different threads probing those two devices? And it just happens to work for "permissive" assuming the boot timing doesn't change?

Quoted 5 lines

Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

That's because fw_devlink.strict=1 isn't set. If you need DMA to be treated as a mandatory supplier, you'll need to set the flag.

Is fw_devlink=on really breaking anything here? It just seems like "permissive" got lucky with the timing and it could break at any point in the future. Thought?

-Saravana

#57 lore raw

Hi Saravana,

Quoted 17 lines · Saravana Kannan
Quoted 16 lines · Geert Uytterhoeven
Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

More detailed log:

Quoted 7 lines
Quoted 4 lines

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

Because fw_devlink.strict=1 is not set and dma/iommu is considered an "optional"/"driver decides" dependency.

Oh, I thought dma/iommu were considered mandatory initially, but dropped as dependencies in the late boot process?

Quoted 5 lines
Quoted 3 lines

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller

Is this the only supplier of dma-controller?

No, e6180000.system-controller is also a supplier.

Quoted 66 lines
Quoted 48 lines

platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

Quoted 7 lines

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

This seems like a race? I'm guessing it's two different threads probing those two devices? And it just happens to work for "permissive" assuming the boot timing doesn't change?

Quoted 5 lines

Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

Quoted 6 lines

That's because fw_devlink.strict=1 isn't set. If you need DMA to be treated as a mandatory supplier, you'll need to set the flag.

Is fw_devlink=on really breaking anything here? It just seems like "permissive" got lucky with the timing and it could break at any point in the future. Thought?

I don't think there is a race. fw_devlinks calling driver_deferred_probe_add() on all consumers has a big impact on probe order.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#58 lore raw
Quoted 24 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 20 lines · Saravana Kannan
Quoted 19 lines · Geert Uytterhoeven
Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

More detailed log:

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

Because fw_devlink.strict=1 is not set and dma/iommu is considered an "optional"/"driver decides" dependency.

Oh, I thought dma/iommu were considered mandatory initially, but dropped as dependencies in the late boot process?

No, I didn't do that in case the drivers that didn't need the IOMMU/DMA were sensitive to probe order.

My goal was for fw_devlink=on to not affect probe order for devices that currently don't need to defer probe. But see below...

Quoted 75 lines
Quoted 6 lines
Quoted 4 lines

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller

Is this the only supplier of dma-controller?

No, e6180000.system-controller is also a supplier.

Quoted 66 lines
Quoted 48 lines

platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

Quoted 7 lines

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

This seems like a race? I'm guessing it's two different threads probing those two devices? And it just happens to work for "permissive" assuming the boot timing doesn't change?

Quoted 5 lines

Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

Quoted 8 lines
Quoted 6 lines

That's because fw_devlink.strict=1 isn't set. If you need DMA to be treated as a mandatory supplier, you'll need to set the flag.

Is fw_devlink=on really breaking anything here? It just seems like "permissive" got lucky with the timing and it could break at any point in the future. Thought?

I don't think there is a race.

Can you explain more please? This below makes it sound like DMA just sneaks in at the last minute.

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

fw_devlinks calling driver_deferred_probe_add()
on all consumers has a big impact on probe order.

Ugh... yeah. That's the real issue. This is really a device links issue that fw_devlink is exposing. I already have a bunch of things in my TODO list to improve deferred probing and probe ordering. Since this is not causing boot issues (only DMA issue) with fw_devlink=on, can we treat this as not a blocking item for fw_devlink=on? Once I go through my TODO list, it should be fixed (by not changing probe ordering unnecessarily). And if not, I can help find out a different solution at that point.

Also, if you have IOMMU drivers, then fw_devlink.strict is also another solution that's available. On a separate note (not a final fix), I was wondering if we should have a config for fw_devlink.strict default value and then have it selected when IOMMU drivers configs are enabled.

-Saravana

#59 lore raw

Hi Saravana,

Quoted 115 lines · Saravana Kannan
Quoted 21 lines · Geert Uytterhoeven
Quoted 20 lines · Saravana Kannan
Quoted 19 lines · Geert Uytterhoeven
Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

More detailed log:

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

Because fw_devlink.strict=1 is not set and dma/iommu is considered an "optional"/"driver decides" dependency.

Oh, I thought dma/iommu were considered mandatory initially, but dropped as dependencies in the late boot process?

No, I didn't do that in case the drivers that didn't need the IOMMU/DMA were sensitive to probe order.

My goal was for fw_devlink=on to not affect probe order for devices that currently don't need to defer probe. But see below...

Quoted 78 lines
Quoted 6 lines
Quoted 4 lines

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller

Is this the only supplier of dma-controller?

No, e6180000.system-controller is also a supplier.

Quoted 69 lines
Quoted 48 lines

platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

Quoted 7 lines

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

This seems like a race? I'm guessing it's two different threads probing those two devices? And it just happens to work for "permissive" assuming the boot timing doesn't change?

Quoted 5 lines

Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

That's because fw_devlink.strict=1 isn't set. If you need DMA to be treated as a mandatory supplier, you'll need to set the flag.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Is fw_devlink=on really breaking anything here? It just seems like "permissive" got lucky with the timing and it could break at any point in the future. Thought?

I don't think there is a race.

Can you explain more please? This below makes it sound like DMA just sneaks in at the last minute.

Yes it does, as the DMAC also has a consumer link to the IOMMU. If you ignore the consumer link from I2C to DMAC, the I2C device has less dependencies than the DMAC, so the I2C device, and the devices on the I2C bus, are probed much earlier than the DMAC.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#60 lore raw
Quoted 125 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 121 lines · Saravana Kannan
Quoted 21 lines · Geert Uytterhoeven
Quoted 20 lines · Saravana Kannan
Quoted 19 lines · Geert Uytterhoeven
Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

More detailed log:

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

Because fw_devlink.strict=1 is not set and dma/iommu is considered an "optional"/"driver decides" dependency.

Oh, I thought dma/iommu were considered mandatory initially, but dropped as dependencies in the late boot process?

No, I didn't do that in case the drivers that didn't need the IOMMU/DMA were sensitive to probe order.

My goal was for fw_devlink=on to not affect probe order for devices that currently don't need to defer probe. But see below...

Quoted 83 lines
Quoted 6 lines
Quoted 4 lines

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller

Is this the only supplier of dma-controller?

No, e6180000.system-controller is also a supplier.

Quoted 66 lines
Quoted 48 lines

platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

Quoted 7 lines

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

This seems like a race? I'm guessing it's two different threads probing those two devices? And it just happens to work for "permissive" assuming the boot timing doesn't change?

Quoted 5 lines

Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

Quoted 6 lines

That's because fw_devlink.strict=1 isn't set. If you need DMA to be treated as a mandatory supplier, you'll need to set the flag.

Is fw_devlink=on really breaking anything here? It just seems like "permissive" got lucky with the timing and it could break at any point in the future. Thought?

I don't think there is a race.

Quoted 7 lines
Quoted 2 lines

Can you explain more please? This below makes it sound like DMA just sneaks in at the last minute.

Yes it does, as the DMAC also has a consumer link to the IOMMU. If you ignore the consumer link from I2C to DMAC, the I2C device has less dependencies than the DMAC, so the I2C device, and the devices on the I2C bus, are probed much earlier than the DMAC.

Can you give this a shot?
https://lore.kernel.org/lkml/[email protected]/T/#u

It should make sure fw_devlink doesn't add a device to the deferred probe list too soon and change the probe ordering unnecessarily.

-Saravana

#61 lore raw

Hi Saravana,

Quoted 132 lines · Saravana Kannan
Quoted 122 lines · Geert Uytterhoeven
Quoted 121 lines · Saravana Kannan
Quoted 21 lines · Geert Uytterhoeven
Quoted 20 lines · Saravana Kannan
Quoted 19 lines · Geert Uytterhoeven
Quoted 4 lines · Saravana Kannan
Quoted 3 lines · Geert Uytterhoeven

- I2C on R-Car Gen3 does not seem to use DMA, according to /sys/kernel/debug/dmaengine/summary:

Quoted 8 lines
Quoted 3 lines
            -dma4chan0    | e66d8000.i2c:tx
            -dma4chan1    | e66d8000.i2c:rx
            -dma5chan0    | e6510000.i2c:tx

I think I need more context on the problem before I can try to fix it. I'm also very unfamiliar with that file. With fw_devlink=permissive, I2C was using DMA? If so, the next step is to see if the I2C relative probe order with DMA is getting changed and if so, why.

More detailed log:

platform e66d8000.i2c: Linked as a consumer to e6150000.clock-controller platform e66d8000.i2c: Linked as a sync state only consumer to e6055400.gpio

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Why is e66d8000.i2c not linked as a consumer to e6700000.dma-controller?

Because fw_devlink.strict=1 is not set and dma/iommu is considered an "optional"/"driver decides" dependency.

Oh, I thought dma/iommu were considered mandatory initially, but dropped as dependencies in the late boot process?

No, I didn't do that in case the drivers that didn't need the IOMMU/DMA were sensitive to probe order.

My goal was for fw_devlink=on to not affect probe order for devices that currently don't need to defer probe. But see below...

Quoted 83 lines
Quoted 6 lines
Quoted 4 lines

platform e6700000.dma-controller: Linked as a consumer to
e6150000.clock-controller

Is this the only supplier of dma-controller?

No, e6180000.system-controller is also a supplier.

Quoted 66 lines
Quoted 48 lines

platform e66d8000.i2c: Added to deferred list platform e6700000.dma-controller: Added to deferred list

bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral

bus: 'platform': driver_probe_device: matched device e66d8000.i2c
with driver i2c-rcar
bus: 'platform': really_probe: probing driver i2c-rcar with device
e66d8000.i2c

I2C becomes available...

    i2c-rcar e66d8000.i2c: request_channel failed for tx (-517)
    [...]

but DMA is not available yet, so the driver falls back to PIO.

driver: 'i2c-rcar': driver_bound: bound to device 'e66d8000.i2c'
bus: 'platform': really_probe: bound device e66d8000.i2c to driver i2c-rcar

platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
platform e6700000.dma-controller: Driver rcar-dmac requests probe deferral platform e6700000.dma-controller: Added to deferred list platform e6700000.dma-controller: Retrying from deferred list
bus: 'platform': driver_probe_device: matched device
e6700000.dma-controller with driver rcar-dmac
bus: 'platform': really_probe: probing driver rcar-dmac with
device e6700000.dma-controller
driver: 'rcar-dmac': driver_bound: bound to device 'e6700000.dma-controller'
bus: 'platform': really_probe: bound device
e6700000.dma-controller to driver rcar-dmac

DMA becomes available.

Here userspace is entered. /sys/kernel/debug/dmaengine/summary shows that the I2C controllers do not have DMA channels allocated, as the kernel has performed no more I2C transfers after DMA became available.

Using i2cdetect shows that DMA is used, which is good:

Quoted 7 lines

i2c-rcar e66d8000.i2c: got DMA channel for rx

With permissive devlinks, the clock controller consumers are not added to the deferred probing list, and probe order is slightly different. The I2C controllers are still probed before the DMA controllers. But DMA becomes available a bit earlier, before the probing of the last I2C slave driver.

This seems like a race? I'm guessing it's two different threads probing those two devices? And it just happens to work for "permissive" assuming the boot timing doesn't change?

Quoted 5 lines

Hence /sys/kernel/debug/dmaengine/summary shows that some I2C transfers did use DMA.

So the real issue is that e66d8000.i2c not linked as a consumer to e6700000.dma-controller.

Quoted 6 lines

That's because fw_devlink.strict=1 isn't set. If you need DMA to be treated as a mandatory supplier, you'll need to set the flag.

Is fw_devlink=on really breaking anything here? It just seems like "permissive" got lucky with the timing and it could break at any point in the future. Thought?

I don't think there is a race.

Quoted 7 lines
Quoted 2 lines

Can you explain more please? This below makes it sound like DMA just sneaks in at the last minute.

Yes it does, as the DMAC also has a consumer link to the IOMMU. If you ignore the consumer link from I2C to DMAC, the I2C device has less dependencies than the DMAC, so the I2C device, and the devices on the I2C bus, are probed much earlier than the DMAC.

Quoted 5 lines

Can you give this a shot?
https://lore.kernel.org/lkml/[email protected]/T/#u

It should make sure fw_devlink doesn't add a device to the deferred probe list too soon and change the probe ordering unnecessarily.

(FTR, to keep all info in this thread)
Yes, this makes I2C use DMA again on Salvator-XS during kernel boot-up. I haven't run any more elaborate tests on other platforms.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#62 lore raw
In reply to Saravana Kannan

Hi Saravana,

Quoted 11 lines · Saravana Kannan
Quoted 5 lines · Geert Uytterhoeven

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

Rob doesn't like the proliferation of OF_POPULATED and we don't need it anymore, so maybe work it out with him? It's a balance between some wasted memory (struct device(s)) vs not proliferating OF_POPULATED.

Quoted 8 lines
Quoted 5 lines

2. SH/R-Mobile AG5 (kzm9g), APE6 (ape6evm), A1 (armadillo800-eva)

- "PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling" is no longer needed
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Good to see more evidence that this series is fixing things at a more generic level.

I spoke too soon: if CONFIG_POWER_RESET_RMOBILE=n,
booting fails again, as everything is waiting on the system controller, which never becomes available.
Rcar-sysc doesn't suffer from this problem, cfr. above. Perhaps because the rmobile-sysc bindings use a hierarchical instead of a linear PM domain description, and thus consumers point to the children of the system controller node?
Cfr. system-controller@e6180000 in arch/arm/boot/dts/r8a7740.dtsi.

Quoted 13 lines
Quoted 13 lines

- On R-Mobile A1, I get a BUG and a memory leak:

BUG: spinlock bad magic on CPU#0, swapper/1
lock: lcdc0_device+0x10c/0x308, .magic: 00000000, .owner:
<none>/-1, .owner_cpu: 0

            CPU: 0 PID: 1 Comm: swapper Not tainted
5.11.0-rc5-armadillo-00032-gf0a85c26907e #266
            Hardware name: Generic R8A7740 (Flattened Device Tree)
            [<c010c3c8>] (unwind_backtrace) from [<c010a49c>]
(show_stack+0x10/0x14)
            [<c010a49c>] (show_stack) from [<c0159534>]
(do_raw_spin_lock+0x20/0x94)
            [<c0159534>] (do_raw_spin_lock) from [<c04089d8>]
Quoted 8 lines
Quoted 8 lines

(dev_pm_get_subsys_data+0x30/0xa0)

            [<c04089d8>] (dev_pm_get_subsys_data) from [<c0413698>]
(genpd_add_device+0x34/0x1c0)
            [<c0413698>] (genpd_add_device) from [<c041389c>]
(of_genpd_add_device+0x34/0x4c)
            [<c041389c>] (of_genpd_add_device) from [<c0a1e9bc>]

(board_staging_register_device+0xf8/0x118)
[<c0a1e9bc>] (board_staging_register_device) from

This is indeed a pre-existing problem.
of_genpd_add_device() is called before platform_device_register(), as it needs to attach the genpd before the device is probed. But the spinlock is only initialized when the device is registered. This was masked before due to an unrelated wait context check failure, which disabled any further spinlock checks, and exposed by fw_devlinks changing probe order.
Patch sent.
"[PATCH] staging: board: Fix uninitialized spinlock when attaching genpd"
https://lore.kernel.org/r/[email protected]

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#63 lore raw

Hi Geert,

Quoted 24 lines · Geert Uytterhoeven

Hi Saravana,

Quoted 11 lines · Saravana Kannan
Quoted 5 lines · Geert Uytterhoeven

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

Rob doesn't like the proliferation of OF_POPULATED and we don't need it anymore, so maybe work it out with him? It's a balance between some wasted memory (struct device(s)) vs not proliferating OF_POPULATED.

Quoted 8 lines
Quoted 5 lines

2. SH/R-Mobile AG5 (kzm9g), APE6 (ape6evm), A1 (armadillo800-eva)

- "PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling" is no longer needed
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Good to see more evidence that this series is fixing things at a more generic level.

Quoted 8 lines

I spoke too soon: if CONFIG_POWER_RESET_RMOBILE=n,
booting fails again, as everything is waiting on the system controller, which never becomes available.
Rcar-sysc doesn't suffer from this problem, cfr. above. Perhaps because the rmobile-sysc bindings use a hierarchical instead of a linear PM domain description, and thus consumers point to the children of the system controller node?
Cfr. system-controller@e6180000 in arch/arm/boot/dts/r8a7740.dtsi.

Ok, I see what's going on. The problem is that the "power domain" fwnode being registered is not the node that contains the "compatible" property and becomes a device. So this patch[1] is not helping here. Fix is to do something like this (to avoid using OF_POPULATED flag and breaking reset):

(quoted diff) +0 -0

b/drivers/soc/renesas/rmobile-sysc.c
index 9046b8c933cb..b7e66139ef7d 100644

drivers/soc/renesas/rmobile-sysc.c +1 -0
@@ -344,6 +344,7 @@ static int __init rmobile_init_pm_domains(void)
                        of_node_put(np);
                        break;
                }
+               fwnode_dev_initialized(&np->fwnode, true);
        }
 
        put_special_pds();

Can you give it a shot?

[1] - https://lore.kernel.org/lkml/[email protected]/

Quoted 22 lines
Quoted 13 lines
Quoted 13 lines

- On R-Mobile A1, I get a BUG and a memory leak:

BUG: spinlock bad magic on CPU#0, swapper/1
lock: lcdc0_device+0x10c/0x308, .magic: 00000000, .owner:
<none>/-1, .owner_cpu: 0

            CPU: 0 PID: 1 Comm: swapper Not tainted
5.11.0-rc5-armadillo-00032-gf0a85c26907e #266
            Hardware name: Generic R8A7740 (Flattened Device Tree)
            [<c010c3c8>] (unwind_backtrace) from [<c010a49c>]
(show_stack+0x10/0x14)
            [<c010a49c>] (show_stack) from [<c0159534>]
(do_raw_spin_lock+0x20/0x94)
            [<c0159534>] (do_raw_spin_lock) from [<c04089d8>]
Quoted 8 lines
Quoted 8 lines

(dev_pm_get_subsys_data+0x30/0xa0)

            [<c04089d8>] (dev_pm_get_subsys_data) from [<c0413698>]
(genpd_add_device+0x34/0x1c0)
            [<c0413698>] (genpd_add_device) from [<c041389c>]
(of_genpd_add_device+0x34/0x4c)
            [<c041389c>] (of_genpd_add_device) from [<c0a1e9bc>]

(board_staging_register_device+0xf8/0x118)
[<c0a1e9bc>] (board_staging_register_device) from

Quoted 11 lines

This is indeed a pre-existing problem.
of_genpd_add_device() is called before platform_device_register(), as it needs to attach the genpd before the device is probed. But the spinlock is only initialized when the device is registered. This was masked before due to an unrelated wait context check failure, which disabled any further spinlock checks, and exposed by fw_devlinks changing probe order.
Patch sent.
"[PATCH] staging: board: Fix uninitialized spinlock when attaching genpd"
https://lore.kernel.org/r/[email protected]

Great!

Thanks,
Saravana

#64 lore raw

Hi Saravana,

Quoted 51 lines · Saravana Kannan
Quoted 21 lines · Geert Uytterhoeven
Quoted 11 lines · Saravana Kannan
Quoted 5 lines · Geert Uytterhoeven

1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu).

- Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init") is no longer needed (but already queued for v5.12 anyway)

Rob doesn't like the proliferation of OF_POPULATED and we don't need it anymore, so maybe work it out with him? It's a balance between some wasted memory (struct device(s)) vs not proliferating OF_POPULATED.

Quoted 8 lines
Quoted 5 lines

2. SH/R-Mobile AG5 (kzm9g), APE6 (ape6evm), A1 (armadillo800-eva)

- "PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling" is no longer needed
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Good to see more evidence that this series is fixing things at a more generic level.

Quoted 8 lines

I spoke too soon: if CONFIG_POWER_RESET_RMOBILE=n,
booting fails again, as everything is waiting on the system controller, which never becomes available.
Rcar-sysc doesn't suffer from this problem, cfr. above. Perhaps because the rmobile-sysc bindings use a hierarchical instead of a linear PM domain description, and thus consumers point to the children of the system controller node?
Cfr. system-controller@e6180000 in arch/arm/boot/dts/r8a7740.dtsi.

Ok, I see what's going on. The problem is that the "power domain" fwnode being registered is not the node that contains the "compatible" property and becomes a device. So this patch[1] is not helping here. Fix is to do something like this (to avoid using OF_POPULATED flag and breaking reset):

drivers/soc/renesas/rmobile-sysc.c +1 -0
index 9046b8c933cb..b7e66139ef7d 100644
@@ -344,6 +344,7 @@ static int __init rmobile_init_pm_domains(void)
                        of_node_put(np);
                        break;
                }
+               fwnode_dev_initialized(&np->fwnode, true);
        }
 
        put_special_pds();
Quoted 1 line

Can you give it a shot?

Thanks, works. Patch sent
"[PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when PM domain is added"
https://lore.kernel.org/linux-arm-kernel/[email protected]/

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#65 lore raw
In reply to Geert Uytterhoeven
Quoted 40 lines · Geert Uytterhoeven
Quoted 7 lines · Saravana Kannan

There are a lot of devices/drivers where they never have a struct device created for them or the driver initializes the hardware without ever binding to the struct device.

This series is intended to avoid any boot regressions due to such devices/drivers when fw_devlink=on and also address the handling of optional suppliers.

- Some devices are reprobed, despite their drivers returning a real error code, and not -EPROBE_DEFER:

renesas_wdt e6020000.watchdog: Watchdog blacklisted on r8a7791 ES1.* (rwdt_probe() returns -ENODEV)

sh-pfc e6060000.pinctrl: pin GP_7_23 already requested by
ee090000.pci; cannot claim for e6590000.usb

            sh-pfc e6060000.pinctrl: pin-247 (e6590000.usb) status -22
            sh-pfc e6060000.pinctrl: could not request pin 247
(GP_7_23) from group usb0  on device sh-pfc
            renesas_usbhs e6590000.usb: Error applying setting,
reverse things back
            renesas_usbhs: probe of e6590000.usb failed with error -22

            rcar-pcie fe000000.pcie: host bridge /soc/pcie@fe000000 ranges:
            rcar-pcie fe000000.pcie:       IO
0x00fe100000..0x00fe1fffff -> 0x0000000000
            rcar-pcie fe000000.pcie:      MEM
0x00fe200000..0x00fe3fffff -> 0x00fe200000
            rcar-pcie fe000000.pcie:      MEM
0x0030000000..0x0037ffffff -> 0x0030000000
            rcar-pcie fe000000.pcie:      MEM
0x0038000000..0x003fffffff -> 0x0038000000
            rcar-pcie fe000000.pcie:   IB MEM
0x0040000000..0x00bfffffff -> 0x0040000000
            rcar-pcie fe000000.pcie:   IB MEM

0x0200000000..0x02ffffffff -> 0x0200000000
rcar-pcie fe000000.pcie: PCIe link down (rcar_pcie_probe() returns -ENODEV)

Quoted 7 lines

xhci-hcd ee000000.usb: xHCI Host Controller
xhci-hcd ee000000.usb: new USB bus registered, assigned bus number 7 xhci-hcd ee000000.usb: Direct firmware load for
r8a779x_usb3_v3.dlmem failed with error -2
xhci-hcd ee000000.usb: can't setup: -2
xhci-hcd ee000000.usb: USB bus 7 deregistered
xhci-hcd: probe of ee000000.usb failed with error -2

Consumers are added to the deferred probe pending list before they are probed, but not removed on probe failure.
Patch sent
"[PATCH] driver core: Fix double failed probing with fw_devlink=on"
https://lore.kernel.org/linux-renesas-soc/[email protected]/

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds