Skip to contentSkip to conversation

memory: samsung: exynos5422-dmc: Correct function names in kerneldoc

PATCH Applied Krzysztof Kozlowski 2 participants 3 messages Feb 6, 2021 – Feb 8, 2021

Subsystems (3)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 memory: samsung: exynos5422-dmc: Correct function names in kerneldoc

Correct kerneldoc to fix W=1 warnings:

drivers/memory/samsung/exynos5422-dmc.c:290: warning:
expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead

---
 drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/samsung/exynos5422-dmc.c +2 -2
index c5ee4121a4d2..1dabb509dec3 100644
@@ -278,7 +278,7 @@ static int exynos5_counters_disable_edev(struct exynos5_dmc *dmc)
 }
 
 /**
- * find_target_freq_id() - Finds requested frequency in local DMC configuration
+ * find_target_freq_idx() - Finds requested frequency in local DMC configuration
  * @dmc:	device for which the information is checked
  * @target_rate:	requested frequency in KHz
  *
@@ -998,7 +998,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
 };
 
 /**
- * exynos5_dmc_align_initial_frequency() - Align initial frequency value
+ * exynos5_dmc_align_init_freq() - Align initial frequency value
  * @dmc:	device for which the frequency is going to be set
  * @bootloader_init_freq:	initial frequency set by the bootloader in KHz
  *
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Krzysztof Kozlowski

Correct kerneldoc to fix W=1 warnings:

drivers/memory/samsung/exynos5422-dmc.c:290: warning:
expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead

Thank you Krzysztof for looking at this.
LGTM

Regards,
Lukasz

Quoted 19 lines
---
  drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/samsung/exynos5422-dmc.c +1 -1
index c5ee4121a4d2..1dabb509dec3 100644
@@ -278,7 +278,7 @@ static int exynos5_counters_disable_edev(struct exynos5_dmc *dmc)
  }
 
  /**
- * find_target_freq_id() - Finds requested frequency in local DMC configuration
+ * find_target_freq_idx() - Finds requested frequency in local DMC configuration
   * @dmc:	device for which the information is checked
   * @target_rate:	requested frequency in KHz
   *

drivers/memory/samsung/exynos5422-dmc.c static struct devfreq_dev_profile exynos5_dmc_df_profile = { · line 1004

Quoted 8 lines
drivers/memory/samsung/exynos5422-dmc.c +1 -1
@@ -998,7 +998,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
  };
 
  /**
- * exynos5_dmc_align_initial_frequency() - Align initial frequency value
+ * exynos5_dmc_align_init_freq() - Align initial frequency value
   * @dmc:	device for which the frequency is going to be set
   * @bootloader_init_freq:	initial frequency set by the bootloader in KHz
   *

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer Applied
#2 lore raw

Re: (subset) [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc

In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Correct kerneldoc to fix W=1 warnings:

drivers/memory/samsung/exynos5422-dmc.c:290: warning:
expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead

Applied, thanks!

[1/1] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc

      commit: 0e9bc42089a7374d056745419c7a8f28016b4191

Best regards,

Signature · 6 lines
Krzysztof Kozlowski <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel