Skip to contentSkip to conversation

add Ebang EBAZ4205 support

PATCH In review Michael Walle 3 participants 14 messages Jan 20, 2021 – Feb 9, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover add Ebang EBAZ4205 support

Add support for the Ebang EBAZ4205 board. This board was once used as a control board for a bitcoin mining device. Nowawdays it is sold as a cheap Zynq-7000 eval board.

Michael Walle (3):
dt-bindings: add ebang vendor prefix
dt-bindings: arm: add Ebang EBAZ4205 board
ARM: dts: add Ebang EBAZ4205 device tree

 .../devicetree/bindings/arm/xilinx.yaml       |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/zynq-ebaz4205.dts           | 109 ++++++++++++++++++
 4 files changed, 113 insertions(+)
 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/3 dt-bindings: add ebang vendor prefix

Add vendor prefix for Zhejiang Ebang Communication Co., Ltd.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index e8c773478f54..f23ea04e0a86 100644
@@ -311,6 +311,8 @@ patternProperties:
     description: Dyna-Image
   "^ea,.*":
     description: Embedded Artists AB
+  "^ebang,.*":
+    description: Zhejiang Ebang Communication Co., Ltd
   "^ebs-systart,.*":
     description: EBS-SYSTART GmbH
   "^ebv,.*":
Signature · 1 line
2.20.1
#3 lore raw

PATCH 2/3 dt-bindings: arm: add Ebang EBAZ4205 board

In reply to Michael Walle

Add the Ebang EBAZ4205 board to the Zynq-7000 board category.

---
 Documentation/devicetree/bindings/arm/xilinx.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/xilinx.yaml +1 -0
index e0c6787f6e94..aaca69d0199f 100644
@@ -22,6 +22,7 @@ properties:
               - adapteva,parallella
               - digilent,zynq-zybo
               - digilent,zynq-zybo-z7
+              - ebang,ebaz4205
               - xlnx,zynq-cc108
               - xlnx,zynq-zc702
               - xlnx,zynq-zc706
Signature · 1 line
2.20.1
#4 lore raw

PATCH 3/3 ARM: dts: add Ebang EBAZ4205 device tree

In reply to Michael Walle

The Ebang EBAZ4205 is a simple board based on the Xilinx Zynq-7000 SoC. Its features are:
- one serial port
- 256 MB RAM
- 128 MB NAND flash
- SDcard slot
- IP101GA 10/100 Mbit Ethernet PHY (connected to PL IOs)
- two LEDs (connected to PL IOs)
- one Push Button (connect to PL IOs)
- (optional) RTC
- (optional) Input voltage supervisor

The NAND flash is not supported in mainline linux yet. Unfortunately, the PHY is connected via the PL, thus for working ethernet the FPGA has to be configured. Also, depending on the board variant, the PHY has no external crystal and its clock needs to be driven by the PL. FCLK3 is used for this and is kept enabled.

---
 arch/arm/boot/dts/Makefile          |   1 +
 arch/arm/boot/dts/zynq-ebaz4205.dts | 109 ++++++++++++++++++++++++++++
 2 files changed, 110 insertions(+)
 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts
arch/arm/boot/dts/Makefile +1 -0
index bf80fd901f61..03ac2e665241 100644
@@ -1312,6 +1312,7 @@ dtb-$(CONFIG_ARCH_VT8500) += \
 	wm8850-w70v2.dtb
 dtb-$(CONFIG_ARCH_ZYNQ) += \
 	zynq-cc108.dtb \
+	zynq-ebaz4205.dtb \
 	zynq-microzed.dtb \
 	zynq-parallella.dtb \
 	zynq-zc702.dtb \
arch/arm/boot/dts/zynq-ebaz4205.dts new file +109 -0

109 lines not on this page · raw message

Signature · 1 line
2.20.1
#5 lore raw
In reply to Michael Walle

Hi

Quoted 9 lines · Michael Walle

Add support for the Ebang EBAZ4205 board. This board was once used as a control board for a bitcoin mining device. Nowawdays it is sold as a cheap Zynq-7000 eval board.

Michael Walle (3):
dt-bindings: add ebang vendor prefix
dt-bindings: arm: add Ebang EBAZ4205 board
ARM: dts: add Ebang EBAZ4205 device tree

Quoted 7 lines
 .../devicetree/bindings/arm/xilinx.yaml       |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/zynq-ebaz4205.dts           | 109 ++++++++++++++++++
 4 files changed, 113 insertions(+)
 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts

any link with schematics?

I will let dt guys to comment 1/3 but series look good to me. The board doesn't look interesting from description point of view that's why all the time thinking if makes sense to add it to kernel.

Thanks,
Michal

#6 lore raw

Hi Michal,

Am 2021-01-21 10:25, schrieb Michal Simek:

Quoted 19 lines · Michael Walle
Quoted 9 lines

Add support for the Ebang EBAZ4205 board. This board was once used as a control board for a bitcoin mining device. Nowawdays it is sold as a cheap Zynq-7000 eval board.

Michael Walle (3):
dt-bindings: add ebang vendor prefix
dt-bindings: arm: add Ebang EBAZ4205 board
ARM: dts: add Ebang EBAZ4205 device tree

Quoted 8 lines
 .../devicetree/bindings/arm/xilinx.yaml       |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/zynq-ebaz4205.dts           | 109 
++++++++++++++++++
 4 files changed, 113 insertions(+)
 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts
Quoted 1 line

any link with schematics?

https://github.com/xjtuecho/EBAZ4205, looks like these are reverse engineered (from a layout file?) though.

Quoted 3 lines

I will let dt guys to comment 1/3 but series look good to me. The board doesn't look interesting from description point of view that's why all the time thinking if makes sense to add it to kernel.

What do you want to tell me? That for the time being, it didn't appear to you to add the board yourself - or do you thing it doesn't make sense at all. If its the latter, what would be actual reason to have a board in mainline?

-michael

#7 lore raw

Hi,

Quoted 22 lines · Michael Walle

Hi Michal,

Am 2021-01-21 10:25, schrieb Michal Simek:

Quoted 19 lines · Michael Walle
Quoted 17 lines

Add support for the Ebang EBAZ4205 board. This board was once used as a control board for a bitcoin mining device. Nowawdays it is sold as a cheap
Zynq-7000 eval board.

Michael Walle (3):
  dt-bindings: add ebang vendor prefix
  dt-bindings: arm: add Ebang EBAZ4205 board
  ARM: dts: add Ebang EBAZ4205 device tree

 .../devicetree/bindings/arm/xilinx.yaml       |   1 + .../devicetree/bindings/vendor-prefixes.yaml  |   2 + arch/arm/boot/dts/Makefile                    |   1 + arch/arm/boot/dts/zynq-ebaz4205.dts           | 109 ++++++++++++++++++

 4 files changed, 113 insertions(+)

 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts

Quoted 4 lines
Quoted 1 line

any link with schematics?

https://github.com/xjtuecho/EBAZ4205, looks like these are reverse engineered (from a layout file?) though.

Interesting but at least something.

Quoted 9 lines
Quoted 4 lines

I will let dt guys to comment 1/3 but series look good to me. The board doesn't look interesting from description point of view that's why all the time thinking if makes sense to add it to kernel.

What do you want to tell me? That for the time being, it didn't appear to you to add the board yourself - or do you thing it doesn't make sense at all. If its the latter, what would be actual reason to have a board in mainline?

I have bad experience with for example Avnet boards which people add and none is really updating them and they are in the same state for years.

Long time ago we agreed that doesn't make sense to describe PL in upstream projects and we only describe PS part. It means you likely miss several things which are useful and the reason for using these SoCs is PL.

As you likely know Xilinx has Versal device and I didn't push any device tree to any upstream project and thinking not to add any description for boards and stay in sort of space that "virtual" description for SoC should be enough. Maybe just versal.dtsi and one kitchen sink DT should be added but not description for all boards.

The same is if make sense to push all DTs for all standard xilinx zynqmp evaluation boards. If there is something interesting/new I thought it makes sense to add it as pattern to follow. But for boards which looks very similar from PS point of view I don't think there is real value to add and invest time for maintaining.

Back to your case. Board is cheap which is not all the time case for any xilinx board but you have only uart, sd and partially described ethernet which doesn't work without PL. Is it worth to have this described? Especially when it is visible that you need to describe custom PL and DT overlays are not solid yet.

Thanks,
Michal

#8 lore raw

Hi,

Am 2021-01-21 10:57, schrieb Michal Simek:

Quoted 38 lines

Hi,

Quoted 23 lines · Michael Walle

Hi Michal,

Am 2021-01-21 10:25, schrieb Michal Simek:

Quoted 20 lines · Michael Walle
Quoted 18 lines

Add support for the Ebang EBAZ4205 board. This board was once used as a control board for a bitcoin mining device. Nowawdays it is sold as a cheap
Zynq-7000 eval board.

Michael Walle (3):
  dt-bindings: add ebang vendor prefix
  dt-bindings: arm: add Ebang EBAZ4205 board
  ARM: dts: add Ebang EBAZ4205 device tree

 .../devicetree/bindings/arm/xilinx.yaml       |   1 + .../devicetree/bindings/vendor-prefixes.yaml  |   2 + arch/arm/boot/dts/Makefile                    |   1 + arch/arm/boot/dts/zynq-ebaz4205.dts           | 109
++++++++++++++++++

 4 files changed, 113 insertions(+)

 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts

Quoted 4 lines
Quoted 1 line

any link with schematics?

https://github.com/xjtuecho/EBAZ4205, looks like these are reverse engineered (from a layout file?) though.

Interesting but at least something.

Quoted 5 lines
Quoted 4 lines

I will let dt guys to comment 1/3 but series look good to me. The board doesn't look interesting from description point of view that's why all the time thinking if makes sense to add it to kernel.

Quoted 7 lines
Quoted 4 lines

What do you want to tell me? That for the time being, it didn't appear to you to add the board yourself - or do you thing it doesn't make sense at all. If its the latter, what would be actual reason to have a board in mainline?

I have bad experience with for example Avnet boards which people add and none is really updating them and they are in the same state for years.

Wouldn't it be better then to pull the plug at some time and remove these boards.

TBH I was a bit disappointed by your statement. It sounded like "nah this board isn't worth it". Esp. because it is just one (small) file. But more below.

Quoted 16 lines

Long time ago we agreed that doesn't make sense to describe PL in upstream projects and we only describe PS part. It means you likely miss several things which are useful and the reason for using these SoCs is PL.

As you likely know Xilinx has Versal device and I didn't push any device tree to any upstream project and thinking not to add any description for boards and stay in sort of space that "virtual" description for SoC should be enough. Maybe just versal.dtsi and one kitchen sink DT should be added but not description for all boards.

The same is if make sense to push all DTs for all standard xilinx zynqmp evaluation boards. If there is something interesting/new I thought it makes sense to add it as pattern to follow. But for boards which looks very similar from PS point of view I don't think there is real value to add and invest time for maintaining.

Quoted 3 lines

Back to your case. Board is cheap which is not all the time case for any xilinx board but you have only uart, sd and partially described ethernet which doesn't work without PL. Is it worth to have this described?

I got your point. But it is at least a jump start for the users if that board boots out of the box. And yes, its unfortunate, that ethernet just works if the PL is configured. This is already done by the bootloader, because there I do have the same problem.

Quoted 5 lines

Especially when it is visible that you need to describe custom PL and DT overlays are not solid yet.

Thanks,
Michal

Signature · 1 line
-michael
#9 lore raw

Hi,

Quoted 75 lines · Michael Walle

Hi,

Am 2021-01-21 10:57, schrieb Michal Simek:

Quoted 40 lines

Hi,

Quoted 24 lines · Michael Walle

Hi Michal,

Am 2021-01-21 10:25, schrieb Michal Simek:

Quoted 21 lines · Michael Walle
Quoted 19 lines

Add support for the Ebang EBAZ4205 board. This board was once used as a
control board for a bitcoin mining device. Nowawdays it is sold as a cheap
Zynq-7000 eval board.

Michael Walle (3):
  dt-bindings: add ebang vendor prefix
  dt-bindings: arm: add Ebang EBAZ4205 board
  ARM: dts: add Ebang EBAZ4205 device tree

 .../devicetree/bindings/arm/xilinx.yaml       |   1 + .../devicetree/bindings/vendor-prefixes.yaml  |   2 + arch/arm/boot/dts/Makefile                    |   1 + arch/arm/boot/dts/zynq-ebaz4205.dts           | 109
++++++++++++++++++

 4 files changed, 113 insertions(+)

 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts

Quoted 4 lines
Quoted 1 line

any link with schematics?

https://github.com/xjtuecho/EBAZ4205, looks like these are reverse engineered (from a layout file?) though.

Interesting but at least something.

Quoted 6 lines
Quoted 5 lines

I will let dt guys to comment 1/3 but series look good to me. The board doesn't look interesting from description point of view that's
why all the time thinking if makes sense to add it to kernel.

Quoted 7 lines
Quoted 4 lines

What do you want to tell me? That for the time being, it didn't appear to you to add the board yourself - or do you thing it doesn't make sense at all. If its the latter, what would be actual reason to have a board in mainline?

I have bad experience with for example Avnet boards which people add and none is really updating them and they are in the same state for years.

Wouldn't it be better then to pull the plug at some time and remove these boards.

TBH I was a bit disappointed by your statement. It sounded like "nah this board isn't worth it". Esp. because it is just one (small) file. But more below.

Quoted 17 lines

Long time ago we agreed that doesn't make sense to describe PL in upstream projects and we only describe PS part. It means you likely miss several things which are useful and the reason for using these SoCs is PL.

As you likely know Xilinx has Versal device and I didn't push any device tree to any upstream project and thinking not to add any description for boards and stay in sort of space that "virtual" description for SoC should be enough. Maybe just versal.dtsi and one kitchen sink DT should be added but not description for all boards.

The same is if make sense to push all DTs for all standard xilinx zynqmp evaluation boards. If there is something interesting/new I thought it makes sense to add it as pattern to follow. But for boards which looks very similar from PS point of view I don't think there is real value to add and invest time for maintaining.

Quoted 8 lines
Quoted 3 lines

Back to your case. Board is cheap which is not all the time case for any xilinx board but you have only uart, sd and partially described ethernet which doesn't work without PL. Is it worth to have this described?

I got your point. But it is at least a jump start for the users if that board boots out of the box. And yes, its unfortunate, that ethernet just works if the PL is configured. This is already done by the bootloader, because there I do have the same problem.

Zynq/ZynqMP boards can use U-Boot SPL. "Advantage" of this solution especially for Zynq is that in u-boot there is open a way for adding ps7_init file which is determined by device tree name.
I think it would make sense to add these DTs and also ps7_init to U-Boot project and wire it up with zynq_virt platform and then you can boot Linux with using U-Boot's DT pointed by $fdtcontroladdr. Then you will get support from scratch to be able to boot.

Thanks,
Michal

#10 lore raw

Hi,

Am 2021-01-21 11:23, schrieb Michal Simek:

Quoted 9 lines
Quoted 8 lines
Quoted 3 lines

Back to your case. Board is cheap which is not all the time case for any xilinx board but you have only uart, sd and partially described ethernet which doesn't work without PL. Is it worth to have this described?

I got your point. But it is at least a jump start for the users if that board boots out of the box. And yes, its unfortunate, that ethernet just works if the PL is configured. This is already done by the bootloader, because there I do have the same problem.

Quoted 7 lines

Zynq/ZynqMP boards can use U-Boot SPL. "Advantage" of this solution especially for Zynq is that in u-boot there is open a way for adding ps7_init file which is determined by device tree name.
I think it would make sense to add these DTs and also ps7_init to U-Boot project and wire it up with zynq_virt platform and then you can boot Linux with using U-Boot's DT pointed by $fdtcontroladdr. Then you will get support from scratch to be able to boot.

I already have patches for u-boot (using SPL). But my impression was that linux is the master for the device trees. Esp. if there are some problems with the board its often useful to have an in-tree device tree.

What is the difference between this board and the other zynq boards in the kernel?

In any case, please make this decision now: will you accept this device tree or not?

-michael

#11 lore raw
Quoted 27 lines · Michael Walle

Hi,

Am 2021-01-21 11:23, schrieb Michal Simek:

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines

Back to your case. Board is cheap which is not all the time case for any
xilinx board but you have only uart, sd and partially described ethernet
which doesn't work without PL. Is it worth to have this described?

I got your point. But it is at least a jump start for the users if that board boots out of the box. And yes, its unfortunate, that ethernet just works if the PL is configured. This is already done by the bootloader, because there I do have the same problem.

Quoted 7 lines

Zynq/ZynqMP boards can use U-Boot SPL. "Advantage" of this solution especially for Zynq is that in u-boot there is open a way for adding ps7_init file which is determined by device tree name.
I think it would make sense to add these DTs and also ps7_init to U-Boot project and wire it up with zynq_virt platform and then you can boot Linux with using U-Boot's DT pointed by $fdtcontroladdr. Then you will get support from scratch to be able to boot.

I already have patches for u-boot (using SPL). But my impression was that linux is the master for the device trees. Esp. if there are some problems with the board its often useful to have an in-tree device tree.

Quoted 5 lines

What is the difference between this board and the other zynq boards in the kernel?

In any case, please make this decision now: will you accept this device tree or not?

If you promise to regularly test it I am fine with it.

Thanks,
Michal

#12 lore raw

Am 2021-01-21 14:16, schrieb Michal Simek:

Quoted 26 lines · Michael Walle
Quoted 25 lines

Am 2021-01-21 11:23, schrieb Michal Simek:

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines

Back to your case. Board is cheap which is not all the time case for any
xilinx board but you have only uart, sd and partially described ethernet
which doesn't work without PL. Is it worth to have this described?

I got your point. But it is at least a jump start for the users if that board boots out of the box. And yes, its unfortunate, that ethernet just works if the PL is configured. This is already done by the bootloader, because there I do have the same problem.

Quoted 7 lines

Zynq/ZynqMP boards can use U-Boot SPL. "Advantage" of this solution especially for Zynq is that in u-boot there is open a way for adding ps7_init file which is determined by device tree name.
I think it would make sense to add these DTs and also ps7_init to U-Boot project and wire it up with zynq_virt platform and then you can boot Linux with using U-Boot's DT pointed by $fdtcontroladdr. Then you will get support from scratch to be able to boot.

I already have patches for u-boot (using SPL). But my impression was that linux is the master for the device trees. Esp. if there are some problems with the board its often useful to have an in-tree device tree.

Quoted 7 lines
Quoted 5 lines

What is the difference between this board and the other zynq boards in the kernel?

In any case, please make this decision now: will you accept this device tree or not?

If you promise to regularly test it I am fine with it.

I might even integrate it into our lava lab.

-michael

#13 lore raw
In reply to Michael Walle
Quoted 9 lines · Michael Walle

Add support for the Ebang EBAZ4205 board. This board was once used as a control board for a bitcoin mining device. Nowawdays it is sold as a cheap Zynq-7000 eval board.

Michael Walle (3):
dt-bindings: add ebang vendor prefix
dt-bindings: arm: add Ebang EBAZ4205 board
ARM: dts: add Ebang EBAZ4205 device tree

Quoted 7 lines
 .../devicetree/bindings/arm/xilinx.yaml       |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/zynq-ebaz4205.dts           | 109 ++++++++++++++++++
 4 files changed, 113 insertions(+)
 create mode 100644 arch/arm/boot/dts/zynq-ebaz4205.dts

Applied all.

Thanks,
Michal