mm: remove lru_add_drain_all in alloc_contig_range
Subsystems (2)
PATCH 1/1 mm: remove lru_add_drain_all in alloc_contig_range
__alloc_contig_migrate_range already has lru_add_drain_all call via migrate_prep. It's necessary to move LRU taget pages into LRU list to be able to isolated. However, lru_add_drain_all call after __alloc_contig_migrate_range is called is pointless.
This patch removes it.
--- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-)
mm/page_alloc.c +0 -2
@@ -8603,8 +8603,6 @@ int alloc_contig_range(unsigned long start, unsigned long end,* isolated thus they won't get removed from buddy. */ -lru_add_drain_all (); - order =0 ; outer_start = start;while (!PageBuddy (pfn_to_page (outer_start))) {
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
Quoted 18 lines · Minchan Kim
__alloc_contig_migrate_rangealready haslru_add_drain_allcall viamigrate_prep. It's necessary to move LRU taget pages into LRU list to be able to isolated. However,lru_add_drain_allcall after__alloc_contig_migrate_rangeis called is pointless.This patch removes it.
Signed-off-by Minchan Kim <[email protected]>--- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-)mm/page_alloc.c +0
-0
mm/page_alloc.c int alloc_contig_range(unsigned long start, unsigned long end, · line 8608
Quoted 8 lines
mm/page_alloc.c +0
-2@@ -8603,8 +8603,6 @@ int alloc_contig_range(unsigned long start, unsigned long end,* isolated thus they won't get removed from buddy. */ -lru_add_drain_all (); - order =0 ; outer_start = start;while (!PageBuddy (pfn_to_page (outer_start))) {
I was expecting some magical reason why this is still required but I am not able to find a compelling one. Maybe this is really some historical artifact.
Let's see if other people know why this call here still exists.
Signature · 3 lines
Thanks, David / dhildenb
Quoted 31 lines · David Hildenbrand
Quoted 17 lines · Minchan Kim
__alloc_contig_migrate_rangealready haslru_add_drain_allcall viamigrate_prep. It's necessary to move LRU taget pages into LRU list to be able to isolated. However,lru_add_drain_allcall after__alloc_contig_migrate_rangeis called is pointless.This patch removes it.
Signed-off-by Minchan Kim <[email protected]>--- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-)mm/page_alloc.c +0
-0mm/page_alloc.c int alloc_contig_range(unsigned long start, unsigned long end, · line 8608
Quoted 8 lines
mm/page_alloc.c +0
-2@@ -8603,8 +8603,6 @@ int alloc_contig_range(unsigned long start, unsigned long end,* isolated thus they won't get removed from buddy. */ -lru_add_drain_all (); - order =0 ; outer_start = start;while (!PageBuddy (pfn_to_page (outer_start))) {I was expecting some magical reason why this is still required but I am not able to find a compelling one. Maybe this is really some historical artifact.
Quoted 1 line
Let's see if other people know why this call here still exists.
I also stumbled upon this while working on adding hugetlb support for alloc_acontig_range [1].
I have to confess I puzzled me a bit.
I saw it going back to when the function was first introduced by
commit 041d3a8cdc18dc375a128d90bbb753949a81b1fb
Author: Michal Nazarewicz <[email protected]> Date: Thu Dec 29 13:09:50 2011 +0100
mm: page_alloc: introduce alloc_contig_range()
It does not make much sense to me. At this point our pages are free, so we do not care about LRU handling here.
But I might be missing something.
Signature · 2 lines
Oscar Salvador SUSE L3
Quoted 17 lines · Oscar Salvador
Quoted 5 lines · David Hildenbrand
I was expecting some magical reason why this is still required but I am not able to find a compelling one. Maybe this is really some historical artifact.
Let's see if other people know why this call here still exists.
I also stumbled upon this while working on adding hugetlb support for
alloc_acontig_range[1].
I have to confess I puzzled me a bit.I saw it going back to when the function was first introduced by
commit
041d3a8cdc18dc375a128d90bbb753949a81b1fbAuthor: Michal Nazarewicz <[email protected]> Date: Thu Dec 29 13:09:50 2011 +0100
Quoted 6 lines
mm:
page_alloc: introducealloc_contig_range()It does not make much sense to me. At this point our pages are free, so we do not care about LRU handling here.
But I might be missing something.
AFAICS, at the time page migration used putback_lru_page() to release the migration source page. This would put the page on lru pvec even if it was in fact not mapped anywhere anymore, and only the drain would actually free it. Seems Minchan optimized this in 2016 by c6c919eb90e0 ("mm: use put_page() to free page instead of putback_lru_page()")
Quoted 25 lines · Vlastimil Babka
Quoted 17 lines · Oscar Salvador
Quoted 5 lines · David Hildenbrand
I was expecting some magical reason why this is still required but I am not able to find a compelling one. Maybe this is really some historical artifact.
Let's see if other people know why this call here still exists.
I also stumbled upon this while working on adding hugetlb support for
alloc_acontig_range[1].
I have to confess I puzzled me a bit.I saw it going back to when the function was first introduced by
commit
041d3a8cdc18dc375a128d90bbb753949a81b1fbAuthor: Michal Nazarewicz <[email protected]> Date: Thu Dec 29 13:09:50 2011 +0100Quoted 6 lines
mm:
page_alloc: introducealloc_contig_range()It does not make much sense to me. At this point our pages are free, so we do not care about LRU handling here.
But I might be missing something.
Quoted 5 lines
AFAICS, at the time page migration used
putback_lru_page()to release the migration source page. This would put the page on lru pvec even if it was in fact not mapped anywhere anymore, and only the drain would actually free it. Seems Minchan optimized this in 2016 byc6c919eb90e0("mm: useput_page()to free page instead ofputback_lru_page()")
This would be a great addition to the changelog. Thanks a lot Vlastimil, you saved me from some archeology. With that mentioned feel free to add
Quoted 5 lines
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 5 lines · Vlastimil Babka
AFAICS, at the time page migration used
putback_lru_page()to release the migration source page. This would put the page on lru pvec even if it was in fact not mapped anywhere anymore, and only the drain would actually free it. Seems Minchan optimized this in 2016 byc6c919eb90e0("mm: useput_page()to free page instead ofputback_lru_page()")
Ok, I see. Thanks for this valuable information Vlastimil.
Signature · 2 lines
Oscar Salvador SUSE L3
Quoted 25 lines · Vlastimil Babka
Quoted 17 lines · Oscar Salvador
Quoted 5 lines · David Hildenbrand
I was expecting some magical reason why this is still required but I am not able to find a compelling one. Maybe this is really some historical artifact.
Let's see if other people know why this call here still exists.
I also stumbled upon this while working on adding hugetlb support for
alloc_acontig_range[1].
I have to confess I puzzled me a bit.I saw it going back to when the function was first introduced by
commit
041d3a8cdc18dc375a128d90bbb753949a81b1fbAuthor: Michal Nazarewicz <[email protected]> Date: Thu Dec 29 13:09:50 2011 +0100Quoted 6 lines
mm:
page_alloc: introducealloc_contig_range()It does not make much sense to me. At this point our pages are free, so we do not care about LRU handling here.
But I might be missing something.
Quoted 7 lines
AFAICS, at the time page migration used
putback_lru_page()to release the migration source page. This would put the page on lru pvec even if it was in fact not mapped anywhere anymore, and only the drain would actually free it. Seems Minchan optimized this in 2016 byc6c919eb90e0("mm: useput_page()to free page instead ofputback_lru_page()")
Thanks for digging history, Vlastimil!
Quoted 8 lines · Minchan Kim
__alloc_contig_migrate_rangealready haslru_add_drain_allcall viamigrate_prep. It's necessary to move LRU taget pages into LRU list to be able to isolated. However,lru_add_drain_allcall after__alloc_contig_migrate_rangeis called is pointless.This patch removes it.
Signed-off-by Minchan Kim <[email protected]>
Quoted 18 lines
--- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-)mm/page_alloc.c +0
-2@@ -8603,8 +8603,6 @@ int alloc_contig_range(unsigned long start, unsigned long end,* isolated thus they won't get removed from buddy. */ -lru_add_drain_all (); - order =0 ; outer_start = start;while (!PageBuddy (pfn_to_page (outer_start))) {
Quoted 8 lines · Minchan Kim
__alloc_contig_migrate_rangealready haslru_add_drain_allcall viamigrate_prep. It's necessary to move LRU taget pages into LRU list to be able to isolated. However,lru_add_drain_allcall after__alloc_contig_migrate_rangeis called is pointless.This patch removes it.
Signed-off-by Minchan Kim <[email protected]>
I agree with Michal that the changelog could benefit from Vastimil's clarification, so with that:
Quoted 21 lines
--- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-)mm/page_alloc.c +0
-2@@ -8603,8 +8603,6 @@ int alloc_contig_range(unsigned long start, unsigned long end,* isolated thus they won't get removed from buddy. */ -lru_add_drain_all (); - order =0 ; outer_start = start;while (!PageBuddy (pfn_to_page (outer_start))) {Signature · 1 line
2.30.0.478.g8a0d178c01-goog
Signature · 2 lines
Oscar Salvador SUSE L3