dma-buf: dma-heap: Provide accessor to get heap name
PATCH v2 1/2 dma-buf: dma-heap: Provide accessor to get heap name
It can be useful to access the name for the heap, so provide an accessor to do so.
---
v2:
* Make sure to use "const char *" as Reported-by: kernel test robot <[email protected]>
--- drivers/dma-buf/dma-heap.c | 12 ++++++++++++ include/linux/dma-heap.h | 9 +++++++++ 2 files changed, 21 insertions(+)
drivers/dma-buf/dma-heap.c +12 -0
@@ -190,6 +190,18 @@ void *dma_heap_get_drvdata(struct dma_heap *heap)return heap->priv; } +/** +* dma_heap_get_name() - get heap name +* @heap: DMA-Heap to retrieve private data for +* +* Returns: +* The char* for the heap name. +*/ +const char *dma_heap_get_name (struct dma_heap *heap) +{ +return heap->name; +} +struct dma_heap *dma_heap_add (const struct dma_heap_export_info *exp_info) {struct dma_heap *heap, *h, *err_ret;
include/linux/dma-heap.h +9 -0
@@ -50,6 +50,15 @@ struct dma_heap_export_info {*/ void *dma_heap_get_drvdata (struct dma_heap *heap); +/** +* dma_heap_get_name() - get heap name +* @heap: DMA-Heap to retrieve private data for +* +* Returns: +* The char* for the heap name. +*/ +const char *dma_heap_get_name (struct dma_heap *heap); +/** * dma_heap_add - adds a heap to dmabuf heaps * @exp_info: information needed to register this heap
Signature · 6 lines
2.25.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 2/2 dma-buf: heaps: Fix the name used when exporting dmabufs to be the actual heap name
By default dma_buf_export() sets the exporter name to be KBUILD_MODNAME. Unfortunately this may not be identical to the string used as the heap name (ie: "system" vs "system_heap").
This can cause some minor confusion with tooling, and there is the future potential where multiple heap types may be exported by the same module (but would all have the same name).
So to avoid all this, set the exporter exp_name to the heap name.
--- drivers/dma-buf/heaps/cma_heap.c | 1 + drivers/dma-buf/heaps/system_heap.c | 1 + 2 files changed, 2 insertions(+)
drivers/dma-buf/heaps/cma_heap.c +1 -0
@@ -339,6 +339,7 @@ static int cma_heap_allocate(struct dma_heap *heap, buffer->pagecount = pagecount;/* create the dmabuf */ + exp_info.exp_name =dma_heap_get_name (heap); exp_info.ops = &cma_heap_buf_ops; exp_info.size = buffer->len; exp_info.flags = fd_flags;
drivers/dma-buf/heaps/system_heap.c +1 -0
@@ -388,6 +388,7 @@ static int system_heap_allocate(struct dma_heap *heap, }/* create the dmabuf */ + exp_info.exp_name =dma_heap_get_name (heap); exp_info.ops = &system_heap_buf_ops; exp_info.size = buffer->len; exp_info.flags = fd_flags;
Signature · 6 lines
2.25.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel