of: irq: Fix the return value for of_irq_parse_one() stub
PATCH 1/1 of: irq: Fix the return value for of_irq_parse_one() stub
When commit 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()") added a stub for of_irq_parse_one() it set the return value to 0. Return value of 0 in this instance means the call succeeded and the out_irq pointer was filled with valid data. So, fix it to return an error value.
Fixes 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()")
Signed-off-by Saravana Kannan <[email protected]>
---
This needs to go into driver-core.
-Saravana
include/linux/of_irq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_irq.h +1 -1
@@ -60,7 +60,7 @@ u32 of_msi_map_id(struct device *dev, struct device_node *msi_np, u32 id_in);static inline int of_irq_parse_one (struct device_node *device,int index,struct of_phandle_args *out_irq) { -return 0 ; +return -EINVAL ; }static inline int of_irq_count (struct device_node *dev) {
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
Hi Saravana,
Quoted 8 lines · On Wed, 10 Feb 2021 12:00:49 -0800 Saravana Kannan <[email protected]> wrote:
When commit
1852ebd13542("of: irq: make a stub forof_irq_parse_one()") added a stub forof_irq_parse_one()it set the return value to 0. Return value of 0 in this instance means the call succeeded and theout_irqpointer was filled with valid data. So, fix it to return an error value.Fixes 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()")Signed-off-by Saravana Kannan <[email protected]>
Oops, sorry about that.
Acked-by Stephen Rothwell <[email protected]>
Signature · 2 lines
Cheers, Stephen Rothwell