Skip to contentSkip to conversation

ARM: dts: aspeed: fix PCA95xx GPIO expander properties on Portwell

PATCH RESEND New Krzysztof Kozlowski 1 participant 2 messages Feb 12, 2021

Subsystems (2)
Device tree bindings Arm/Aspeed machine support
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH RESEND v3 1/2 ARM: dts: aspeed: fix PCA95xx GPIO expander properties on Portwell

The PCA95xx GPIO expander requires GPIO controller properties to operate properly.

Signed-off-by Krzysztof Kozlowski <[email protected]>
Acked-by Joel Stanley <[email protected]>

---

Hi Arnd and Olof,

This is 5-months old patchset which was not picked up by Aspeed maintainers, so could you take it directly?

Best regards,
Krzysztof

 arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts +2 -0
index 4a1ca8f5b6a7..03c161493ffc 100644
@@ -121,6 +121,8 @@ &i2c5 {
 	pca9555 at 27 {
 		compatible = "nxp,pca9555";
 		reg = <0x27>;
+		gpio-controller;
+		#gpio-cells = <2>;
 	};
 };
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH RESEND v3 2/2 ARM: dts: aspeed: align GPIO hog names with dtschema

dtschema for pca95xx expects GPIO hogs to end with 'hog' suffix.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts |  2 +-
 arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts  | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +1 -1
index a4b77aec5424..5c98130358c8 100644
@@ -579,7 +579,7 @@ tca9554 at 40 {
 		gpio-controller;
 		#gpio-cells = <2>;
 
-		smbus0 {
+		smbus0-hog {
 			gpio-hog;
 			gpios = <4 GPIO_ACTIVE_HIGH>;
 			output-high;
arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts +8 -8
index cb85168f6761..577c211c469e 100644
@@ -827,7 +827,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus0 {
+				smbus0-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -852,7 +852,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus1 {
+				smbus1-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -900,7 +900,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus2 {
+				smbus2-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -925,7 +925,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus3 {
+				smbus3-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -992,7 +992,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus4 {
+				smbus4-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -1017,7 +1017,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus5 {
+				smbus5-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -1065,7 +1065,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus6 {
+				smbus6-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;

@@ -1090,7 +1090,7 @@ tca9554 at 39 {
 				gpio-controller;
 				#gpio-cells = <2>;
 
-				smbus7 {
+				smbus7-hog {
 					gpio-hog;
 					gpios = <4 GPIO_ACTIVE_HIGH>;
 					output-high;
Signature · 1 line
2.25.1