crypto: s5p-sss - initialize APB clock after the AXI bus clock for SlimSSS
Krzysztof Kozlowski
maintainerPATCH 1/1 crypto: s5p-sss - initialize APB clock after the AXI bus clock for SlimSSS
The driver for Slim Security Subsystem (SlimSSS) on Exynos5433 takes two clocks - aclk (AXI/AHB clock) and pclk (APB/Advanced Peripheral Bus clock). The "aclk", as main high speed bus clock, is enabled first. Then the "pclk" is enabled.
However the driver assigned reversed names for lookup of these clocks from devicetree, so effectively the "pclk" was enabled first.
Although it might not matter in reality, the correct order is to enable first main/high speed bus clock - "aclk". Also this was the intention of the actual code.
---
Not tested, please kindly test on Exynos5433 hardware.
--- drivers/crypto/s5p-sss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/s5p-sss.c +1 -1
@@ -401,7 +401,7 @@ static const struct samsung_aes_variant exynos_aes_data = {static const struct samsung_aes_variant exynos5433_slim_aes_data = { .aes_offset =0x400 , .hash_offset =0x800 , - .clk_names = {"pclk" ,"aclk" , }, + .clk_names = {"aclk" ,"pclk" , }, };static const struct of_device_id s5p_sss_dt_match[] = {
Signature · 1 line
2.25.1
Herbert Xu
maintainerQuoted 12 lines · Krzysztof Kozlowski
The driver for Slim Security Subsystem (SlimSSS) on Exynos5433 takes two clocks - aclk (AXI/AHB clock) and pclk (APB/Advanced Peripheral Bus clock). The "aclk", as main high speed bus clock, is enabled first. Then the "pclk" is enabled.
However the driver assigned reversed names for lookup of these clocks from devicetree, so effectively the "pclk" was enabled first.
Although it might not matter in reality, the correct order is to enable first main/high speed bus clock - "aclk". Also this was the intention of the actual code.
Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Not tested, please kindly test on Exynos5433 hardware.
--- drivers/crypto/s5p-sss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt