debugfs: be more robust at handling improper input in debugfs_lookup()
Subsystems (2)
Greg Kroah-Hartman
maintainerPATCH 1/2 debugfs: be more robust at handling improper input in debugfs_lookup()
debugfs_lookup() doesn't like it if it is passed an illegal name pointer, or if the filesystem isn't even initialized yet. If either of these happen, it will crash the system, so fix it up by properly testing for valid input and that we are up and running before trying to find a file in the filesystem.
--- fs/debugfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/inode.c +1 -1
@@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char *name, struct dentry *parent) {struct dentry *dentry; -if (IS_ERR (parent)) +if (!debugfs_initialized () ||IS_ERR_OR_NULL (name) ||IS_ERR (parent))return NULL ;if (!parent)
Signature · 1 line
2.30.1
Greg Kroah-Hartman
maintainerPATCH 2/2 debugfs: do not attempt to create a new file before the filesystem is initalized
Some subsystems want to add debugfs files at early boot, way before debugfs is initialized. This seems to work somehow as the vfs layer will not allow it to happen, but let's be explicit and test to ensure we are properly up and running before allowing files to be created.
--- fs/debugfs/inode.c | 3 +++ 1 file changed, 3 insertions(+)
fs/debugfs/inode.c +3 -0
@@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)if (!(debugfs_allow &DEBUGFS_ALLOW_API ))return ERR_PTR (-EPERM ); +if (!debugfs_initialized ()) +return ERR_PTR (-ENOENT ); +pr_debug ("creating file '%s'\n" , name);if (IS_ERR (parent))
Signature · 1 line
2.30.1
[irqchip: irq/irqchip-next] debugfs: do not attempt to create a new file before the filesystem is initalized
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: fb0757f54bc9259c4c67907fd97ca3ad109d3f6f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/fb0757f54bc9259c4c67907fd97ca3ad109d3f6f Author: Greg Kroah-Hartman <[email protected]> AuthorDate: Thu, 18 Feb 2021 11:08:18 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Thu, 18 Feb 2021 11:39:18
debugfs: do not attempt to create a new file before the filesystem is initalized
Some subsystems want to add debugfs files at early boot, way before debugfs is initialized. This seems to work somehow as the vfs layer will not allow it to happen, but let's be explicit and test to ensure we are properly up and running before allowing files to be created.
--- fs/debugfs/inode.c | 3 +++ 1 file changed, 3 insertions(+)
fs/debugfs/inode.c +3 -0
@@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)if (!(debugfs_allow &DEBUGFS_ALLOW_API ))return ERR_PTR (-EPERM ); +if (!debugfs_initialized ()) +return ERR_PTR (-ENOENT ); +pr_debug ("creating file '%s'\n" , name);if (IS_ERR (parent))
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 2ad058730606cb68e75177ee7e330e1f94ab7b4b Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/2ad058730606cb68e75177ee7e330e1f94ab7b4b Author: Greg Kroah-Hartman <[email protected]> AuthorDate: Thu, 18 Feb 2021 11:08:17 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Thu, 18 Feb 2021 11:39:18
debugfs: be more robust at handling improper input in debugfs_lookup()
debugfs_lookup() doesn't like it if it is passed an illegal name pointer, or if the filesystem isn't even initialized yet. If either of these happen, it will crash the system, so fix it up by properly testing for valid input and that we are up and running before trying to find a file in the filesystem.
--- fs/debugfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/inode.c +1 -1
@@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char *name, struct dentry *parent) {struct dentry *dentry; -if (IS_ERR (parent)) +if (!debugfs_initialized () ||IS_ERR_OR_NULL (name) ||IS_ERR (parent))return NULL ;if (!parent)