ARM: dts: nuvoton: Fix flash layout
PATCH 1/1 ARM: dts: nuvoton: Fix flash layout
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +8 -20
@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };
@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 { - label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>; + rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; }; }; };
Signature · 1 line
2.30.0.478.g8a0d178c01-goog
Dear Anton,
Thank you for your patch.
Am 18.02.21 um 13:25 schrieb [email protected]:
Quoted 3 lines
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Can you please list these requirements in the commit message? Maybe, also add OpenBMC to the commit message summary.
Quoted 4 lines
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)
[…]
Kind regards,
Paul
Quoted 45 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5
-14@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 {
arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-6- label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>; + rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };
I recommend just including the openbmc-flash-layout.dtsi file here instead since that contains the common flash layout for most OpenBMC systems.
Quoted 5 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +0
-1}; }; --2.30.0.478.g8a0d178c01-goog
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 62 lines · Benjamin Fair
Review
Quoted 11 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/nuvoton-npcm750-evb.dtsQuoted 34 lines
index
bd1eb6ee380f..741c1fee8552100644arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5
-14@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 {arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-6- label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>; + rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.
Quoted 1 line
Good solution,
Do you mean nuvoton-openbmc-flash-layout?
Quoted 6 lines
Quoted 5 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +0
-1}; }; --2.30.0.478.g8a0d178c01-goog
Thanks,
Tomer
Hi, Tom.
Yes, I'm using it for testing on real hardware.
BTW. Recent u-boot doesn't work with SD cards. The card doesn't detect. The last working version was this one:
However, u-boot from igps repo:
https://github.com/Nuvoton-Israel/igps/tree/master/ImageGeneration/versions
Has issues too. It doesn't allow me to read more than 4k bytes once at a time. Thus, to flash the stuff I have manually read chunks from the
SD-card: fat load doesn't work at all and I write that data in raw partition.
Quoted 88 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 53 lines · Benjamin Fair
Quoted 51 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5
-20@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 { - label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>;Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-0+ rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Good solution,
Do you mean nuvoton-openbmc-flash-layout?Quoted 6 lines
Quoted 6 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +0
-1}; }; --2.30.0.478.g8a0d178c01-goog
Thanks,
Tomer
Ofer,
Can you check why u-boot doesn't work with SD cards?
Quoted 108 lines · Anton Kachalov
Hi, Tom.
Yes, I'm using it for testing on real hardware.
BTW. Recent u-boot doesn't work with SD cards. The card doesn't detect. The last working version was this one:
However, u-boot from igps repo:
https://github.com/Nuvoton-Israel/igps/tree/master/ImageGeneration/versions
Has issues too. It doesn't allow me to read more than 4k bytes once at a time. Thus, to flash the stuff I have manually read chunks from the
SD-card: fat load doesn't work at all and I write that data in raw partition.Quoted 88 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 53 lines · Benjamin Fair
Quoted 51 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5
-20@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 { - label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>;Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-0+ rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Good solution,
Do you mean nuvoton-openbmc-flash-layout?Quoted 6 lines
Quoted 6 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +0
-1}; }; --2.30.0.478.g8a0d178c01-goog
Thanks,
Tomer
Signature · 2 lines
Regards, Avi
Hi Avi,
It seems an old version of uboot u-boot_2019.01.7.5.bin from igps below:
Please use latest from uboot.bin github.
Regards,
Ofer
-----Original Message-----
From: Avi Fishman <[email protected]>
Sent: Monday, February 22, 2021 12:21 PM
To: Anton Kachalov <[email protected]>
Cc: Tomer Maimon <[email protected]>; Benjamin Fair <[email protected]>; Tali Perry <[email protected]>; Patrick Venture <[email protected]>; Nancy Yuen <[email protected]>; Rob Herring <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux Kernel Mailing List <[email protected]>; IS20 Ofer Eilon <[email protected]>
Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layout
Ofer,
Can you check why u-boot doesn't work with SD cards?
Quoted 27 lines · Anton Kachalov
Hi, Tom.
Yes, I'm using it for testing on real hardware.
BTW. Recent u-boot doesn't work with SD cards. The card doesn't detect. The last working version was this one:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FNuvoton-Israel%2Fnuvoton-info%2Ftree%2Fmaster%2Fnpcm7xx-poleg %2Fevaluation-board%2Fsw_deliverables%2Fnpcm7xx_v2.3&data=04%7C01% 7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71bacd4%7Ca3f249 31d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnknown%7CTW FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 Mn0%3D%7C1000&sdata=f4t41g3CQaFTQNfwwNVBrIwQScndIGcfRTms0yrTn5o%3D &reserved=0However, u-boot from igps repo:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fver sions&data=04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee 4c08d8d71bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C6374958611 62860437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0%2BNzEv%2FSX9QTg0Xumch RrU61uGbZ3CZXrtspXu2560I%3D&reserved=0
Quoted 96 lines
Has issues too. It doesn't allow me to read more than 4k bytes once at a time. Thus, to flash the stuff I have manually read chunks from the
SD-card: fat load doesn't work at all and I write that data in raw partition.Quoted 90 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 55 lines · Benjamin Fair
Quoted 53 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)arch/arm/boot/dts/nuvoton-npcm750-evb.dts +2
-2@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; }; @@ -195,25 +195,13 @@kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; };arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-18- rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 { - label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>;Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-0+ rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Good solution,
Do you mean nuvoton-openbmc-flash-layout?Quoted 6 lines
Quoted 6 lines
}; };--
2.30.0.478.g8a0d178c01-googThanks,
Tomer
--
Regards,
Avi
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
Ofer,
The oldest version from igps doesn't work as well as the latest version from u-boot github.
The only version that works for me is in software deliverables:
Quoted 157 lines · On Mon, 22 Feb 2021 at 15:10, IS20 Ofer Eilon <[email protected]> wrote:
Hi Avi,
It seems an old version of uboot u-boot_2019.01.7.5.bin from igps below:
Please use latest from uboot.bin github.
Regards,
Ofer-----Original Message-----
From: Avi Fishman <[email protected]>
Sent: Monday, February 22, 2021 12:21 PM
To: Anton Kachalov <[email protected]>
Cc: Tomer Maimon <[email protected]>; Benjamin Fair <[email protected]>; Tali Perry <[email protected]>; Patrick Venture <[email protected]>; Nancy Yuen <[email protected]>; Rob Herring <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux Kernel Mailing List <[email protected]>; IS20 Ofer Eilon <[email protected]>
Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layoutOfer,
Can you check why u-boot doesn't work with SD cards?
Quoted 27 lines · Anton Kachalov
Hi, Tom.
Yes, I'm using it for testing on real hardware.
BTW. Recent u-boot doesn't work with SD cards. The card doesn't detect. The last working version was this one:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FNuvoton-Israel%2Fnuvoton-info%2Ftree%2Fmaster%2Fnpcm7xx-poleg %2Fevaluation-board%2Fsw_deliverables%2Fnpcm7xx_v2.3&data=04%7C01% 7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71bacd4%7Ca3f249 31d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnknown%7CTW FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 Mn0%3D%7C1000&sdata=f4t41g3CQaFTQNfwwNVBrIwQScndIGcfRTms0yrTn5o%3D &reserved=0However, u-boot from igps repo:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fver sions&data=04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee 4c08d8d71bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C6374958611 62860437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0%2BNzEv%2FSX9QTg0Xumch RrU61uGbZ3CZXrtspXu2560I%3D&reserved=0Quoted 96 lines
Has issues too. It doesn't allow me to read more than 4k bytes once at a time. Thus, to flash the stuff I have manually read chunks from the
SD-card: fat load doesn't work at all and I write that data in raw partition.Quoted 90 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 55 lines · Benjamin Fair
Quoted 53 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)arch/arm/boot/dts/nuvoton-npcm750-evb.dts +2
-2@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; }; @@ -195,25 +195,13 @@kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; };arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-18- rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 { - label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>;Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-0+ rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Good solution,
Do you mean nuvoton-openbmc-flash-layout?Quoted 6 lines
Quoted 6 lines
}; };--
2.30.0.478.g8a0d178c01-googThanks,
Tomer
--
Regards,
Avi
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
Hi Anton,
At runtime do you get into the code inside npcmx50_sdhci.c, but it doesn't work well or not access at all?
Can you check those registers (BootBlock should set them for you):
sd1irv1 at address 0xf0800054 value = 0xf5c80f80 sd1irv2 at address 0xf0800058 value = 0x52001132 sd2irv1 at address 0xf08000b4 value = 0xfdc80f80 sd2irv2 at address 0xf08000b8 value = 0x52003132
Also try to use attached file.
Thanks,
Avi
Quoted 168 lines · Anton Kachalov
Ofer,
The oldest version from igps doesn't work as well as the latest version from u-boot github.
The only version that works for me is in software deliverables:
Quoted 157 lines · On Mon, 22 Feb 2021 at 15:10, IS20 Ofer Eilon <[email protected]> wrote:
Hi Avi,
It seems an old version of uboot u-boot_2019.01.7.5.bin from igps below:
Please use latest from uboot.bin github.
Regards,
Ofer-----Original Message-----
From: Avi Fishman <[email protected]>
Sent: Monday, February 22, 2021 12:21 PM
To: Anton Kachalov <[email protected]>
Cc: Tomer Maimon <[email protected]>; Benjamin Fair <[email protected]>; Tali Perry <[email protected]>; Patrick Venture <[email protected]>; Nancy Yuen <[email protected]>; Rob Herring <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux Kernel Mailing List <[email protected]>; IS20 Ofer Eilon <[email protected]>
Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layoutOfer,
Can you check why u-boot doesn't work with SD cards?
Quoted 27 lines · Anton Kachalov
Hi, Tom.
Yes, I'm using it for testing on real hardware.
BTW. Recent u-boot doesn't work with SD cards. The card doesn't detect. The last working version was this one:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FNuvoton-Israel%2Fnuvoton-info%2Ftree%2Fmaster%2Fnpcm7xx-poleg %2Fevaluation-board%2Fsw_deliverables%2Fnpcm7xx_v2.3&data=04%7C01% 7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71bacd4%7Ca3f249 31d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnknown%7CTW FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 Mn0%3D%7C1000&sdata=f4t41g3CQaFTQNfwwNVBrIwQScndIGcfRTms0yrTn5o%3D &reserved=0However, u-boot from igps repo:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fver sions&data=04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee 4c08d8d71bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C6374958611 62860437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0%2BNzEv%2FSX9QTg0Xumch RrU61uGbZ3CZXrtspXu2560I%3D&reserved=0Quoted 96 lines
Has issues too. It doesn't allow me to read more than 4k bytes once at a time. Thus, to flash the stuff I have manually read chunks from the
SD-card: fat load doesn't work at all and I write that data in raw partition.Quoted 90 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 55 lines · Benjamin Fair
Quoted 53 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)arch/arm/boot/dts/nuvoton-npcm750-evb.dts +2
-2@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; }; @@ -195,25 +195,13 @@kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; };arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-18- rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 { - label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>;Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts
Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-0+ rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Good solution,
Do you mean nuvoton-openbmc-flash-layout?Quoted 6 lines
Quoted 6 lines
}; };--
2.30.0.478.g8a0d178c01-googThanks,
Tomer
--
Regards,
Avi
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
Signature · 2 lines
Regards, Avi
Hello, Tomer.
Seems like Nuvoton's u-boot expects the uboot-env at different address comparing to openbmc-flash-layout.dtsi:
https://github.com/Nuvoton-Israel/u-boot/blob/npcm7xx-v2019.01/include/configs/poleg.h#L30
Vs.
The change is more about making partitions naming the same as expected by OpenBMC.
Quoted 91 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 62 lines · Benjamin Fair
Review
Quoted 11 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/nuvoton-npcm750-evb.dtsQuoted 34 lines
index
bd1eb6ee380f..741c1fee8552100644arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5
-14@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 {arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-6- label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>; + rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Quoted 1 line
Good solution,
Do you mean nuvoton-openbmc-flash-layout?
Quoted 6 lines
Quoted 5 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +0
-1}; }; --2.30.0.478.g8a0d178c01-goog
Thanks,
Tomer
Hi Anton,
The reason the u-boot Env is at 0x100000 address is that some costumers have:
one copy of Bootblock and U-boot at 0x0 - 0x80000 second copy of Bootblock and U-boot at 0x80000 - 0x100000.
we have two options;
1. Modify the OpenBMC device tree flash layout u-boot Env address to 0x100000.
2. Add a patch to OpnBMC platform that using openbmc flash layout to modify CONFIG_ENV_OFFSET
in the u-boot.
Thanks,
Tomer
Quoted 110 lines · Anton Kachalov
Hello, Tomer.
Seems like Nuvoton's u-boot expects the uboot-env at different address comparing to
openbmc-flash-layout.dtsi:https://github.com/Nuvoton-Israel/u-boot/blob/npcm7xx-v2019.01/include/configs/poleg.h#L30
Vs.
The change is more about making partitions naming the same as expected by OpenBMC.
Quoted 91 lines · Tomer Maimon
Hi Benjamin and Anton,
Sorry for the late reply,
The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
Quoted 62 lines · Benjamin Fair
Review
Quoted 11 lines · On Thu, 18 Feb 2021 at 04:42, <[email protected]> wrote:
From: "Anton D. Kachalov" <[email protected]>
This change satisfy OpenBMC requirements for flash layout.
Signed-off-by Anton D. Kachalov <[email protected]>--- arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++---------------- 1 file changed, 8 insertions(+), 20 deletions(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/nuvoton-npcm750-evb.dtsQuoted 34 lines
index
bd1eb6ee380f..741c1fee8552100644arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5
-14@@ -182,8 +182,8 @@ bbuboot2@80000 { reg = <0x0080000 0x80000>; read-only; }; - envparam@100000 { - label = "env-param"; + ubootenv@100000 { + label = "u-boot-env"; reg = <0x0100000 0x40000>; read-only; };@@ -195,25 +195,13 @@ kernel@200000 { label = "kernel"; reg = <0x0200000 0x400000>; }; - rootfs@600000 { - label = "rootfs"; - reg = <0x0600000 0x700000>; + rofs@780000 { + label = "rofs"; + reg = <0x0780000 0x1680000>; }; - spare1@D00000 { - label = "spare1"; - reg = <0x0D00000 0x200000>; - }; - spare2@0F00000 { - label = "spare2"; - reg = <0x0F00000 0x200000>; - }; - spare3@1100000 {arch/arm/boot/dts/nuvoton-npcm750-evb.dts kernel@200000 { · line 205
Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +3
-6- label = "spare3"; - reg = <0x1100000 0x200000>; - }; - spare4@1300000 { - label = "spare4"; - reg = <0x1300000 0x0>; + rwfs@1e00000 { + label = "rwfs"; + reg = <0x1e00000 0x200000>; };I recommend just including the
openbmc-flash-layout.dtsifile here instead since that contains the common flash layout for most OpenBMC systems.Quoted 1 line
Good solution,
Do you mean nuvoton-openbmc-flash-layout?
Quoted 6 lines
Quoted 5 lines
arch/arm/boot/dts/nuvoton-npcm750-evb.dts +0
-1}; }; --2.30.0.478.g8a0d178c01-goog
Thanks,
Tomer