Skip to contentSkip to conversation

cpufreq: schedutil: Correct comment to update_lock of struct sugov_policy

PATCH In review Yue Hu 2 participants 3 messages Feb 18, 2021

Subsystems (2)
lore
Share & tools
lore

Yue Hu

author
#0 lore raw

PATCH 1/1 cpufreq: schedutil: Correct comment to update_lock of struct sugov_policy

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq().

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/cpufreq_schedutil.c +1 -1
index add8081..cc0308c 100644
@@ -26,7 +26,7 @@ struct sugov_policy {
 	struct sugov_tunables	*tunables;
 	struct list_head	tunables_hook;
 
-	raw_spinlock_t		update_lock;	/* For shared policies */
+	raw_spinlock_t		update_lock;	/* For single + shared policies */
 	u64			last_freq_update_time;
 	s64			freq_update_delay_ns;
 	unsigned int		next_freq;
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 14 lines · Yue Hu

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq().

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/cpufreq_schedutil.c +0 -0
index add8081..cc0308c 100644

kernel/sched/cpufreq_schedutil.c struct sugov_policy { · line 29

Quoted 5 lines
kernel/sched/cpufreq_schedutil.c +1 -1
@@ -26,7 +26,7 @@ struct sugov_policy {
 	struct sugov_tunables	*tunables;
 	struct list_head	tunables_hook;
 
-	raw_spinlock_t		update_lock;	/* For shared policies */
+	raw_spinlock_t		update_lock;	/* For single + shared policies */

I will just remove the comments, its pretty much useless anyway.

Signature · 1 line
viresh
author
#2 lore raw
Quoted 18 lines · On Thu, 18 Feb 2021 14:56:58 +0530 Viresh Kumar <[email protected]> wrote:
Quoted 17 lines · Yue Hu

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq().

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/kernel/sched/cpufreq_schedutil.c index add8081..cc0308c 100644

kernel/sched/cpufreq_schedutil.c +0 -0
@@ -26,7 +26,7 @@ struct sugov_policy {
 	struct sugov_tunables	*tunables;
 	struct list_head	tunables_hook;
 
Quoted 7 lines
Quoted 4 lines
kernel/sched/cpufreq_schedutil.c +0 -1
-	raw_spinlock_t		update_lock;	/* For

shared policies */

kernel/sched/cpufreq_schedutil.c +1 -0
+	raw_spinlock_t		update_lock;	/* For

single + shared policies */

I will just remove the comments, its pretty much useless anyway.

ok, i will do it.

Thx.