scsi/sd: Fix Opal support
Subsystems (2)
PATCH v2 1/1 scsi/sd: Fix Opal support
The SCSI core has been modified recently such that it only processes PM requests if rpm_status != RPM_ACTIVE. Since some Opal requests are submitted while rpm_status != RPM_ACTIVE, set flag RQF_PM for Opal requests.
See also https://bugzilla.kernel.org/show_bug.cgi?id=211227.
---
Changes compared to v1:
- Addressed Christoph's review comments.
- Added Cc: stable.
--- drivers/scsi/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/sd.c +3 -3
@@ -707,9 +707,9 @@ static int sd_sec_submit(void *data, u16 spsp, u8 secp, void *buffer,put_unaligned_be16 (spsp, &cdb[2 ]);put_unaligned_be32 (len, &cdb[6 ]); - ret =scsi_execute_req (sdev, cdb, - send ?DMA_TO_DEVICE :DMA_FROM_DEVICE , - buffer, len,NULL ,SD_TIMEOUT , sdkp->max_retries,NULL ); + ret =scsi_execute (sdev, cdb, send ?DMA_TO_DEVICE :DMA_FROM_DEVICE , + buffer, len,NULL ,NULL ,SD_TIMEOUT , sdkp->max_retries,0 , +RQF_PM ,NULL ); return ret <= 0 ? ret : -EIO; }#endif /* CONFIG_BLK_SED_OPAL */
Looks good,
Martin K. Petersen
AppliedBart,
Quoted 4 lines
The SCSI core has been modified recently such that it only processes PM requests if
rpm_status!=RPM_ACTIVE. Since some Opal requests are submitted whilerpm_status!=RPM_ACTIVE, set flagRQF_PMfor Opal requests.
Applied to 5.12/scsi-staging. Thanks for fixing this up!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Bart Van Assche
The SCSI core has been modified recently such that it only processes PM requests if
rpm_status!=RPM_ACTIVE. Since some Opal requests are submitted whilerpm_status!=RPM_ACTIVE, set flagRQF_PMfor Opal requests.See also https://bugzilla.kernel.org/show_bug.cgi?id=211227.
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi/sd: Fix Opal support
https://git.kernel.org/mkp/scsi/c/aaf15f8c6de9
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering