xfs: mark xfs_bmap_set_attrforkoff static
PATCH 1/1 xfs: mark xfs_bmap_set_attrforkoff static
xfs_bmap_set_attrforkoff is only used inside of xfs_bmap.c, so mark it static.
Signed-off-by Christoph Hellwig <[email protected]>
--- fs/xfs/libxfs/xfs_bmap.c | 2 +- fs/xfs/libxfs/xfs_bmap.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
fs/xfs/libxfs/xfs_bmap.c +1 -1
@@ -1028,7 +1028,7 @@ xfs_bmap_add_attrfork_local( }/* Set an inode attr fork off based on the format */ -int +static int xfs_bmap_set_attrforkoff( struct xfs_inode *ip, int size,
fs/xfs/libxfs/xfs_bmap.h +0 -1
@@ -186,7 +186,6 @@ static inline bool xfs_bmap_is_written_extent(struct xfs_bmbt_irec *irec)void xfs_trim_extent (struct xfs_bmbt_irec *irec,xfs_fileoff_t bno,xfs_filblks_t len);int xfs_bmap_add_attrfork (struct xfs_inode *ip,int size,int rsvd); -int xfs_bmap_set_attrforkoff (struct xfs_inode *ip,int size,int *version);void xfs_bmap_local_to_extents_empty (struct xfs_trans *tp,struct xfs_inode *ip,int whichfork); void __xfs_bmap_add_free(struct xfs_trans *tp, xfs_fsblock_t bno,
Signature · 1 line
2.29.2
Quoted 4 lines · Christoph Hellwig
xfs_bmap_set_attrforkoffis only used inside ofxfs_bmap.c, so mark it static.Signed-off-by Christoph Hellwig <[email protected]>
Looks fine, assuming you're all fine with Dave's other patch to initialize attr forks when ACLs are turned on?
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 33 lines
--- fs/xfs/libxfs/xfs_bmap.c | 2 +- fs/xfs/libxfs/xfs_bmap.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)fs/xfs/libxfs/xfs_bmap.c +1
-1@@ -1028,7 +1028,7 @@ xfs_bmap_add_attrfork_local( }/* Set an inode attr fork off based on the format */ -int +static int xfs_bmap_set_attrforkoff( struct xfs_inode *ip, int size,fs/xfs/libxfs/xfs_bmap.h +0
-1@@ -186,7 +186,6 @@ static inline bool xfs_bmap_is_written_extent(struct xfs_bmbt_irec *irec)void xfs_trim_extent (struct xfs_bmbt_irec *irec,xfs_fileoff_t bno,xfs_filblks_t len);int xfs_bmap_add_attrfork (struct xfs_inode *ip,int size,int rsvd); -int xfs_bmap_set_attrforkoff (struct xfs_inode *ip,int size,int *version);void xfs_bmap_local_to_extents_empty (struct xfs_trans *tp,struct xfs_inode *ip,int whichfork); void __xfs_bmap_add_free(struct xfs_trans *tp, xfs_fsblock_t bno,Signature · 1 line
2.29.2