Skip to contentSkip to conversation

KVM: x86: remove misplaced comment on active_mmu_pages

PATCH Applied Dongli Zhang 2 participants 2 messages Feb 26, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 KVM: x86: remove misplaced comment on active_mmu_pages

The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a list. Remove the misplaced comment as it's mostly stating the obvious anyways.

---
Changed since v1:
- change 'incorrect' to 'misplaced'

 arch/x86/include/asm/kvm_host.h | 3 ---
 1 file changed, 3 deletions(-)
arch/x86/include/asm/kvm_host.h +0 -3
index 84499aad01a4..318242512407 100644
@@ -937,9 +937,6 @@ struct kvm_arch {
 	unsigned int indirect_shadow_pages;
 	u8 mmu_valid_gen;
 	struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
-	/*
-	 * Hash table of struct kvm_mmu_page.
-	 */
 	struct list_head active_mmu_pages;
 	struct list_head zapped_obsolete_pages;
 	struct list_head lpage_disallowed_mmu_pages;
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 19 lines · Dongli Zhang

The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a list. Remove the misplaced comment as it's mostly stating the obvious anyways.

---
Changed since v1:
- change 'incorrect' to 'misplaced'

  arch/x86/include/asm/kvm_host.h | 3 ---
  1 file changed, 3 deletions(-)
arch/x86/include/asm/kvm_host.h +0 -0
index 84499aad01a4..318242512407 100644

arch/x86/include/asm/kvm_host.h struct kvm_arch { · line 942

Quoted 9 lines
arch/x86/include/asm/kvm_host.h +0 -3
@@ -937,9 +937,6 @@ struct kvm_arch {
  	unsigned int indirect_shadow_pages;
  	u8 mmu_valid_gen;
  	struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
-	/*
-	 * Hash table of struct kvm_mmu_page.
-	 */
  	struct list_head active_mmu_pages;
  	struct list_head zapped_obsolete_pages;
  	struct list_head lpage_disallowed_mmu_pages;

Queued, thanks.

Paolo