Skip to contentSkip to conversation

ARM: ep93xx: don't use clang IAS for crunch

PATCH In review Arnd Bergmann 4 participants 6 messages Feb 26, 2021 – Jun 3, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: ep93xx: don't use clang IAS for crunch

From: Arnd Bergmann <[email protected]>

Randconfig builds with ep93xx fail with the clang integrated assembler that does not understand the maverick crunch extensions:

arch/arm/mach-ep93xx/crunch-bits.S:94:2: error: invalid instruction
cfstr64 mvdx0, [r1, #0] @ save 64b registers

It is unclear if anyone is still using support for crunch: gcc-4.8 dropped it in 2012 when it was already too broken to be used reliabled. glibc support existed as an external patch but was never merged upstream. We could consider removing the last bits of the kernel support as well.

Turn off the integrated assembler for this file for now.

---
 arch/arm/mach-ep93xx/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-ep93xx/Makefile +1 -1
index 86768495f61d..f686577ba059 100644
@@ -7,7 +7,7 @@ obj-y			:= core.o clock.o timer-ep93xx.o
 obj-$(CONFIG_EP93XX_DMA)	+= dma.o
 
 obj-$(CONFIG_CRUNCH)		+= crunch.o crunch-bits.o
-AFLAGS_crunch-bits.o		:= -Wa,-mcpu=ep9312
+AFLAGS_crunch-bits.o		:= -Wa,-mcpu=ep9312 $(cc-option, -fno-integrated-as)
 
 obj-$(CONFIG_MACH_ADSSPHERE)	+= adssphere.o
 obj-$(CONFIG_MACH_EDB93XX)	+= edb93xx.o
Signature · 1 line
2.29.2
#1 lore raw

arch/arm/mach-ep93xx/Makefile obj-y := core.o clock.o timer-ep93xx.o · line 10

Quoted 4 lines · Arnd Bergmann

obj-$(CONFIG_CRUNCH) += crunch.o crunch-bits.o

arch/arm/mach-ep93xx/Makefile +1 -1
-AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312
+AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312 $(cc-option, -fno-integrated-as)

I reworked that patch just before sending it out, and ended up with two typos in there, it should be

+AFLAGS_crunch-bits.o := -Wa,-mcpu=ep9312 $(call cc-option,
-no-integrated-as)

I'll wait for others to comment before I send the fixed version.

Arnd

#2 lore raw
Quoted 13 lines · Arnd Bergmann

arch/arm/mach-ep93xx/Makefile obj-y := core.o clock.o timer-ep93xx.o · line 10

Quoted 4 lines · Arnd Bergmann

obj-$(CONFIG_CRUNCH) += crunch.o crunch-bits.o

arch/arm/mach-ep93xx/Makefile +1 -1
-AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312
+AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312 $(cc-option, -fno-integrated-as)

I reworked that patch just before sending it out, and ended up with two typos in there, it should be

(quoted diff) +1 -1
+AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312 $(call cc-option,
-no-integrated-as)
Quoted 1 line

I'll wait for others to comment before I send the fixed version.

Probably good for that v2?

Signature · 2 lines
Thanks,
~Nick Desaulniers
#3 lore raw
In reply to Arnd Bergmann

Hi!

Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Randconfig builds with ep93xx fail with the clang integrated assembler that does not understand the maverick crunch extensions:

Quoted 7 lines

arch/arm/mach-ep93xx/crunch-bits.S:94:2: error: invalid instruction cfstr64 mvdx0, [r1, #0] @ save 64b registers

It is unclear if anyone is still using support for crunch: gcc-4.8 dropped it in 2012 when it was already too broken to be used reliabled. glibc support existed as an external patch but was never merged upstream. We could consider removing the last bits of the kernel support as well.

This was my impression already in 2006, that Cirrus is not going to work on Crunch support. From my PoV it's OK to remove the support in the kernel completely.

Quoted 20 lines

Turn off the integrated assembler for this file for now.

---
 arch/arm/mach-ep93xx/Makefile | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-ep93xx/Makefile +0 -0
index 86768495f61d..f686577ba059 100644
@@ -7,7 +7,7 @@ obj-y                   := core.o clock.o timer-ep93xx.o

 obj-$(CONFIG_EP93XX_DMA)       += dma.o

 obj-$(CONFIG_CRUNCH)           += crunch.o crunch-bits.o

arch/arm/mach-ep93xx/Makefile +1 -1
-AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312
+AFLAGS_crunch-bits.o           := -Wa,-mcpu=ep9312 $(cc-option, -fno-integrated-as)


 obj-$(CONFIG_MACH_ADSSPHERE)   += adssphere.o
 obj-$(CONFIG_MACH_EDB93XX)     += edb93xx.o

Signature · 1 line
Alexander Sverdlin.
#4 lore raw
Quoted 7 lines · Alexander Sverdlin
Quoted 6 lines · Arnd Bergmann

Randconfig builds with ep93xx fail with the clang integrated assembler that does not understand the maverick crunch extensions:

arch/arm/mach-ep93xx/crunch-bits.S:94:2: error: invalid instruction cfstr64 mvdx0, [r1, #0] @ save 64b registers

Quoted 6 lines
Quoted 4 lines

It is unclear if anyone is still using support for crunch: gcc-4.8 dropped it in 2012 when it was already too broken to be used reliabled. glibc support existed as an external patch but was never merged upstream. We could consider removing the last bits of the kernel support as well.

This was my impression already in 2006, that Cirrus is not going to work on Crunch support. From my PoV it's OK to remove the support in the kernel completely.

Martin Guy did a lot of work trying to get the maverick crunch working but I was never able to successfully use it for anything. It "kind" of works but depending on the EP93xx silicon revision there are still a number of hardware bugs that either give imprecise or garbage results.

I have no problem with removing the kernel support for the maverick crunch.

Hartley

#5 lore raw
Quoted 14 lines · Hartley Sweeten
Quoted 12 lines · Alexander Sverdlin
Quoted 10 lines · Arnd Bergmann

Randconfig builds with ep93xx fail with the clang integrated assembler that does not understand the maverick crunch extensions:

arch/arm/mach-ep93xx/crunch-bits.S:94:2: error: invalid instruction
cfstr64 mvdx0, [r1, #0] @ save 64b registers

It is unclear if anyone is still using support for crunch: gcc-4.8 dropped it in 2012 when it was already too broken to be used reliabled. glibc support existed as an external patch but was never merged upstream. We could consider removing the last bits of the kernel support as well.

Quoted 5 lines
Quoted 1 line

This was my impression already in 2006, that Cirrus is not going to work on Crunch support. From my PoV it's OK to remove the support in the kernel completely.

Martin Guy did a lot of work trying to get the maverick crunch working but I was never able to successfully use it for anything. It "kind" of works but depending on the EP93xx silicon revision there are still a number of hardware bugs that either give imprecise or garbage results.

I have no problem with removing the kernel support for the maverick crunch.

Either way, please consider adding a

tag. That will help us notice when/where this lands in order to close out the issue. Thanks for the patch.

(if we go with this rather than removing the driver:)

(I'm also fine with removing the driver; my ack is not conditional on one way or the other).

Signature · 2 lines
Thanks,
~Nick Desaulniers