mm/hugetlb: remove redundant reservation check condition in alloc_huge_page()
Subsystems (2)
PATCH v2 1/1 mm/hugetlb: remove redundant reservation check condition in alloc_huge_page()
vma_resv_map(vma) checks if a reserve map is associated with the vma. The routine vma_needs_reservation() will check vma_resv_map(vma) and return 1 if no reserv map is present. map_chg is set to the return value of vma_needs_reservation(). Therefore, !vma_resv_map(vma) is redundant in the expression:
map_chg || avoid_reserve || !vma_resv_map(vma);
Remove the redundant check.
[Thanks Mike Kravetz for reshaping this commit message!]
--- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c +1 -1
@@ -2314,7 +2314,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,/* If this allocation is not consuming a reservation, charge it now. */ - deferred_reserve = map_chg || avoid_reserve || !vma_resv_map (vma); + deferred_reserve = map_chg || avoid_reserve;if (deferred_reserve) { ret =hugetlb_cgroup_charge_cgroup_rsvd ( idx,pages_per_huge_page (h), &h_cg);
Signature · 1 line
2.19.1
Quoted 11 lines · Miaohe Lin
vma_resv_map(vma)checks if a reserve map is associated with the vma. The routinevma_needs_reservation()will checkvma_resv_map(vma)and return 1 if no reserv map is present.map_chgis set to the return value ofvma_needs_reservation(). Therefore, !vma_resv_map(vma) is redundant in the expression:map_chg || avoid_reserve || !vma_resv_map(vma);Remove the redundant check.
[Thanks Mike Kravetz for reshaping this commit message!]
Signed-off-by Miaohe Lin <[email protected]>
Thanks,
Quoted 18 lines
--- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/hugetlb.c +1
-1@@ -2314,7 +2314,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,/* If this allocation is not consuming a reservation, charge it now. */ - deferred_reserve = map_chg || avoid_reserve || !vma_resv_map (vma); + deferred_reserve = map_chg || avoid_reserve;if (deferred_reserve) { ret =hugetlb_cgroup_charge_cgroup_rsvd ( idx,pages_per_huge_page (h), &h_cg);