usb: serial: io_edgeport: fix memory leak in edge_startup
Subsystems (2)
PATCH 1/1 usb: serial: io_edgeport: fix memory leak in edge_startup
sysbot found memory leak in edge_startup().
The problem was that when an error was received from the usb_submit_urb(), nothing was cleaned up.
Reported-by [email protected]
Signed-off-by Pavel Skripkin <[email protected]>
--- drivers/usb/serial/io_edgeport.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-)
drivers/usb/serial/io_edgeport.c +16 -10
@@ -3003,26 +3003,32 @@ static int edge_startup(struct usb_serial *serial) response = -ENODEV ; } -usb_free_urb (edge_serial->interrupt_read_urb); -kfree (edge_serial->interrupt_in_buffer); - -usb_free_urb (edge_serial->read_urb); -kfree (edge_serial->bulk_in_buffer); - -kfree (edge_serial); - -return response; + goto error; }/* start interrupt read for this edgeport this interrupt will * continue as long as the edgeport is connected */ response =usb_submit_urb (edge_serial->interrupt_read_urb,GFP_KERNEL ); -if (response) +if (response) {dev_err (ddev,"%s - Error %d submitting control urb\n" , __func__, response); + + goto error; + } }return response; + +error: +usb_free_urb (edge_serial->interrupt_read_urb); +kfree (edge_serial->interrupt_in_buffer); + +usb_free_urb (edge_serial->read_urb); +kfree (edge_serial->bulk_in_buffer); + +kfree (edge_serial); + +return response; }
Signature · 1 line
2.25.1
Johan Hovold
maintainerQuoted 6 lines · Pavel Skripkin
sysbot found memory leak in
edge_startup().
The problem was that when an error was received from theusb_submit_urb(), nothing was cleaned up.Reported-by [email protected]Signed-off-by Pavel Skripkin <[email protected]>
Now applied, thanks.
Johan