Skip to contentSkip to conversation

PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

PATCH Applied Pali Rohár 5 participants 5 messages Mar 3, 2021 – Mar 22, 2021

Subsystems (3)
PCI PCI native host bridge and endpoint drivers Broadcom iproc Arm architecture
lore
Share & tools
lore

Pali Rohár

author
#0 lore raw

PATCH 1/1 PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

IRQ domain alloc function should return zero on success. Non-zero value indicates failure.

Signed-off-by Pali Rohár <[email protected]>
Fixes fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
---
 drivers/pci/controller/pcie-iproc-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-iproc-msi.c +1 -1
index 908475d27e0e..eede4e8f3f75 100644
@@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
 				    NULL, NULL);
 	}
 
-	return hwirq;
+	return 0;
 }
 
 static void iproc_msi_irq_domain_free(struct irq_domain *domain,
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Pali Rohár

IRQ domain alloc function should return zero on success. Non-zero value indicates failure.

Signed-off-by Pali Rohár <[email protected]>
Fixes fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
---
 drivers/pci/controller/pcie-iproc-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-iproc-msi.c +0 -0
index 908475d27e0e..eede4e8f3f75 100644

drivers/pci/controller/pcie-iproc-msi.c static int iproc_msi_irq_domain_alloc(struct irq_domain *domain, · line 277

Quoted 8 lines
drivers/pci/controller/pcie-iproc-msi.c +1 -1
@@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
 				    NULL, NULL);
 	}
 
-	return hwirq;
+	return 0;
 }
 
 static void iproc_msi_irq_domain_free(struct irq_domain *domain,
Acked-by Marc Zyngier <[email protected]>
	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Acked-by on v1 1/1
#2 lore raw
In reply to Pali Rohár
Quoted 15 lines · Pali Rohár

IRQ domain alloc function should return zero on success. Non-zero value indicates failure.

Signed-off-by Pali Rohár <[email protected]>
Fixes fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
---
 drivers/pci/controller/pcie-iproc-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-iproc-msi.c +0 -0
index 908475d27e0e..eede4e8f3f75 100644

drivers/pci/controller/pcie-iproc-msi.c static int iproc_msi_irq_domain_alloc(struct irq_domain *domain, · line 277

Quoted 8 lines
drivers/pci/controller/pcie-iproc-msi.c +1 -1
@@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
 				    NULL, NULL);
 	}
 
-	return hwirq;
+	return 0;
 }
 
 static void iproc_msi_irq_domain_free(struct irq_domain *domain,

Looks good to me. Thanks for the fix.

Acked-by Ray Jui <[email protected]>