Skip to contentSkip to conversation

efi/apple-properties: Handle device properties with software node API

PATCH In review Heikki Krogerus 3 participants 4 messages Mar 4, 2021 – Mar 7, 2021 EFI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi/apple-properties: Handle device properties with software node API

The old device property API is going to be removed. Replacing the device_add_properties() call with the software node API equivalent, device_create_managed_software_node().

---
 drivers/firmware/efi/apple-properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/efi/apple-properties.c +1 -1
index e1926483ae2fd..4c3201e290e29 100644
@@ -157,7 +157,7 @@ static int __init unmarshal_devices(struct properties_header *properties)
 		if (!entry[0].name)
 			goto skip_device;
 
-		ret = device_add_properties(dev, entry); /* makes deep copy */
+		ret = device_create_managed_software_node(dev, entry, NULL);
 		if (ret)
 			dev_err(dev, "error %d assigning properties\n", ret);
 
Signature · 1 line
2.30.1
maintainer
#1 lore raw

(+ Lukas)

Quoted 26 lines · Heikki Krogerus

The old device property API is going to be removed. Replacing the device_add_properties() call with the software node API equivalent, device_create_managed_software_node().

---
 drivers/firmware/efi/apple-properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/efi/apple-properties.c +1 -2
index e1926483ae2fd..4c3201e290e29 100644
@@ -157,7 +157,7 @@ static int __init unmarshal_devices(struct properties_header *properties)
                if (!entry[0].name)
                        goto skip_device;
 
-               ret = device_add_properties(dev, entry); /* makes deep copy */
+               ret = device_create_managed_software_node(dev, entry, NULL);
                if (ret)
                        dev_err(dev, "error %d assigning properties\n", ret);
 
--

2.30.1