pinctrl: intel: No need to disable IRQs in the handler
Subsystems (3)
PATCH 1/1 pinctrl: intel: No need to disable IRQs in the handler
In IRQ handler interrupts are already disabled, hence no need to repeat it. Even in the threaded case, which is disabled here, it is not a problem because IRQ framework serializes descriptor handling. Remove disabling IRQ part in the handler.
--- drivers/pinctrl/intel/pinctrl-intel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.c +2 -3
@@ -1173,16 +1173,15 @@ static int intel_gpio_community_irq_handler(struct intel_pinctrl *pctrl,for (gpp =0 ; gpp < community->ngpps; gpp++) {const struct intel_padgroup *padgrp = &community->gpps[gpp];unsigned long pending, enabled, gpp_offset; -unsigned long flags; -raw_spin_lock_irqsave (&pctrl->lock, flags); +raw_spin_lock (&pctrl->lock); pending =readl (community->regs + community->is_offset + padgrp->reg_num *4 ); enabled =readl (community->regs + community->ie_offset + padgrp->reg_num *4 ); -raw_spin_unlock_irqrestore (&pctrl->lock, flags); +raw_spin_unlock (&pctrl->lock);/* Only interrupts that are enabled */ pending &= enabled;
Signature · 1 line
2.30.1
Quoted 6 lines · Andy Shevchenko
In IRQ handler interrupts are already disabled, hence no need to repeat it. Even in the threaded case, which is disabled here, it is not a problem because IRQ framework serializes descriptor handling. Remove disabling IRQ part in the handler.
Signed-off-by Andy Shevchenko <[email protected]>
Quoted 9 lines · Mika Westerberg
Quoted 6 lines · Andy Shevchenko
In IRQ handler interrupts are already disabled, hence no need to repeat it. Even in the threaded case, which is disabled here, it is not a problem because IRQ framework serializes descriptor handling. Remove disabling IRQ part in the handler.
Signed-off-by Andy Shevchenko <[email protected]>Acked-by Mika Westerberg <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko