memstick: core: fix error return code of mspro_block_resume()
Subsystems (2)
PATCH 1/1 memstick: core: fix error return code of mspro_block_resume()
When mspro_block_init_card() fails, no error return code of mspro_block_resume() is assigned.
To fix this bug, rc is assigned with the return value of mspro_block_init_card(), and then rc is checked.
Reported-by TOTE Robot <[email protected]>
Signed-off-by Jia-Ju Bai <[email protected]>
--- drivers/memstick/core/mspro_block.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +2 -1
@@ -1382,7 +1382,8 @@ static int mspro_block_resume(struct memstick_dev *card) new_msb->card = card;memstick_set_drvdata (card, new_msb); -if (mspro_block_init_card (card)) + rc =mspro_block_init_card (card); +if (rc) goto out_free; for (cnt = 0; new_msb->attr_group.attrs[cnt]
Signature · 1 line
2.17.1
Quoted 8 lines · Jia-Ju Bai
When
mspro_block_init_card()fails, no error return code ofmspro_block_resume()is assigned.
To fix this bug, rc is assigned with the return value ofmspro_block_init_card(), and then rc is checked.Reported-by TOTE Robot <[email protected]>Signed-off-by Jia-Ju Bai <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 21 lines
--- drivers/memstick/core/mspro_block.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/memstick/core/mspro_block.c +2
-2@@ -1382,7 +1382,8 @@ static int mspro_block_resume(struct memstick_dev *card) new_msb->card = card;memstick_set_drvdata (card, new_msb); -if (mspro_block_init_card (card)) + rc =mspro_block_init_card (card); +if (rc) goto out_free; for (cnt = 0; new_msb->attr_group.attrs[cnt] --2.17.1