Skip to contentSkip to conversation

dt-bindings: iio: samsung,exynos-adc: add common clock properties

PATCH In review Krzysztof Kozlowski 3 participants 5 messages Feb 12, 2021 – Mar 7, 2021

Subsystems (3)
Device tree bindings Arm Samsung Exynos IIO
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: samsung,exynos-adc: add common clock properties

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:

    adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
  arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
    adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 .../bindings/iio/adc/samsung,exynos-adc.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +12 -0
index c65921e66dc1..ce03132f8ebc 100644
@@ -27,6 +27,18 @@ properties:
   reg:
     maxItems: 1
 
+  assigned-clocks:
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-parents:
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-rates:
+    minItems: 1
+    maxItems: 3
+
   clocks:
     description:
       Phandle to ADC bus clock. For Exynos3250 additional clock is needed.
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hi Krzysztof,

Quoted 7 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to almost all bindings? IMHO this is an over-engineering and this has to be handled somewhere else...

Quoted 18 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
  .../bindings/iio/adc/samsung,exynos-adc.yaml         | 12 ++++++++++++
  1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +5 -0
index c65921e66dc1..ce03132f8ebc 100644
@@ -27,6 +27,18 @@ properties:
    reg:
      maxItems: 1
 
+  assigned-clocks:
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-parents:

Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml properties: · line 44

Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +7 -0
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-rates:
+    minItems: 1
+    maxItems: 3
+
    clocks:
      description:
        Phandle to ADC bus clock. For Exynos3250 additional clock is needed.

Best regards

Signature · 8 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#2 lore raw
Quoted 6 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 3 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

Quoted 7 lines
Quoted 4 lines
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to almost all bindings?

To my understanding: yes, and we already added it to multiple schemas.

Quoted 2 lines

IMHO this is an over-engineering and this has to be handled somewhere else...

Would have to be made a part of the core schema (just like pinctrl nodes etc).

Best regards,
Krzysztof

maintainer
#3 lore raw
Quoted 15 lines · Krzysztof Kozlowski
Quoted 6 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 3 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

Quoted 7 lines
Quoted 4 lines
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to almost all bindings?

Quoted 7 lines

To my understanding: yes, and we already added it to multiple schemas.

Quoted 2 lines

IMHO this is an over-engineering and this has to be handled somewhere else...

Would have to be made a part of the core schema (just like pinctrl nodes etc).

That's the case now. It's contingent on having a 'clocks' property in the node.

Rob

author maintainer
#4 lore raw
Quoted 18 lines · Rob Herring
Quoted 17 lines · Krzysztof Kozlowski
Quoted 6 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 3 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

Quoted 7 lines
Quoted 4 lines
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to almost all bindings?

To my understanding: yes, and we already added it to multiple schemas.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

IMHO this is an over-engineering and this has to be handled somewhere else...

Would have to be made a part of the core schema (just like pinctrl nodes etc).

That's the case now. It's contingent on having a 'clocks' property in the node.

Do I understand correctly: with new dtschema my patch is not needed anymore?

Best regards,
Krzysztof