Skip to contentSkip to conversation

kernel: sched: remove unnecessary variable from schedule_tail()

PATCH Applied Edmundo Carmona Antoranz 4 participants 6 messages Mar 6, 2021 – Mar 10, 2021 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: sched: remove unnecessary variable from schedule_tail()

Since 565790d28b1 (sched: Fix balance_callback(), 2020-05-11), there is no longer a need to reuse the result value of the call to finish_task_switch() inside schedule_tail(), therefore the variable used to hold that value (rq) is no longer needed.

---
 kernel/sched/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/sched/core.c +1 -3
index ca2bb629595f..8d89d106b724 100644
@@ -4246,8 +4246,6 @@ static struct rq *finish_task_switch(struct task_struct *prev)
 asmlinkage __visible void schedule_tail(struct task_struct *prev)
 	__releases(rq->lock)
 {
-	struct rq *rq;
-
 	/*
 	 * New tasks start with FORK_PREEMPT_COUNT, see there and
 	 * finish_task_switch() for details.
@@ -4257,7 +4255,7 @@ asmlinkage __visible void schedule_tail(struct task_struct *prev)
 	 * PREEMPT_COUNT kernels).
 	 */
 
-	rq = finish_task_switch(prev);
+	finish_task_switch(prev);
 	preempt_enable();
 
 	if (current->set_child_tid)
Signature · 1 line
2.30.1
#1 lore raw

On Sat, Mar 6, 2021 at 3:08 PM Edmundo Carmona Antoranz <[email protected]> wrote:

While looking for ways to find compilation messages (still learning, if you have any good resources for a kernel newbie to look at / learn from, please, let me know) I found this piece of low hanging fruit that was begging for a kind soul to pick it up. Given that this is my first baby intended for linux, let's see how far it is able to fly (I wouldn't be surprised if it falls directly to the ground). I hope I didn't mess up too badly in terms of formatting and that I am _hopefully_ following "the procedure".. and if that's not the case, please let me know where I can read about it.

Thanks!

#2 lore raw
Quoted 12 lines · Edmundo Carmona Antoranz

On Sat, Mar 6, 2021 at 3:08 PM Edmundo Carmona Antoranz <[email protected]> wrote:

While looking for ways to find compilation messages (still learning, if you have any good resources for a kernel newbie to look at / learn from, please, let me know) I found this piece of low hanging fruit that was begging for a kind soul to pick it up. Given that this is my first baby intended for linux, let's see how far it is able to fly (I wouldn't be surprised if it falls directly to the ground). I hope I didn't mess up too badly in terms of formatting and that I am _hopefully_ following "the procedure".. and if that's not the case, please let me know where I can read about it.

I would be better to start with drivers staging than with the scheduler.

julia

A message that is not in the archive (sent off-list or not yet received): CAOc6etbrW15DWRdJ=wP-R_TXzKDqAKAjzB5oVLwWfT7sOAbY_A@mail.gmail.com

maintainer
#5 lore raw
Quoted 9 lines · Edmundo Carmona Antoranz
Quoted 2 lines · Peter Zijlstra

Thanks!

You're welcome... but I still have no idea if this baby will make it to orbit or if it will have to be included in a revision of the theory of tectonic plates. I guess I will be learning the flows of how patches move around as time goes by. I will be posting a couple of questions (not related to this patch) today or tomorrow, probably.

It found its way here:

https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/core

And soon, today or tomorrow (provided the robots don't hate on anything I stick in that branch), I'll push it into tip at which point you'll get an email.

#6 lore raw

[tip: sched/core] sched: Remove unnecessary variable from schedule_tail()

In reply to Edmundo Carmona Antoranz
The following commit has been merged into the sched/core branch of tip:

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     13c2235b2b2870675195f0b551275d1abdd81068
Gitweb:        https://git.kernel.org/tip/13c2235b2b2870675195f0b551275d1abdd81068
Author:        Edmundo Carmona Antoranz <[email protected]>
AuthorDate:    Sat, 06 Mar 2021 15:07:39 -06:00
Committer:     Peter Zijlstra <[email protected]>
CommitterDate: Wed, 10 Mar 2021 09:51:49 +01:00

sched: Remove unnecessary variable from schedule_tail()

Since 565790d28b1 (sched: Fix balance_callback(), 2020-05-11), there is no longer a need to reuse the result value of the call to finish_task_switch() inside schedule_tail(), therefore the variable used to hold that value (rq) is no longer needed.

---
 kernel/sched/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/sched/core.c +1 -3
index d2629fd..28c4df6 100644
@@ -4253,8 +4253,6 @@ static struct rq *finish_task_switch(struct task_struct *prev)
 asmlinkage __visible void schedule_tail(struct task_struct *prev)
 	__releases(rq->lock)
 {
-	struct rq *rq;
-
 	/*
 	 * New tasks start with FORK_PREEMPT_COUNT, see there and
 	 * finish_task_switch() for details.
@@ -4264,7 +4262,7 @@ asmlinkage __visible void schedule_tail(struct task_struct *prev)
 	 * PREEMPT_COUNT kernels).
 	 */
 
-	rq = finish_task_switch(prev);
+	finish_task_switch(prev);
 	preempt_enable();
 
 	if (current->set_child_tid)