pinctrl: intel: Show the GPIO base calculation explicitly
Subsystems (3)
PATCH 1/1 pinctrl: intel: Show the GPIO base calculation explicitly
During the split of intel_pinctrl_add_padgroups(), the _by_size() variant missed the GPIO base calculations and hence made unable to retrieve proper GPIO number.
Assign the gpio_base explicitly in _by_size() variant.
While at it, differentiate NOMAP case with the rest in _by_gpps() variant.
Fixes 036e126c72eb ("pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance")
Reported-and-tested-by Maximilian Luz <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/pinctrl/intel/pinctrl-intel.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pinctrl/intel/pinctrl-intel.c +2 -0
@@ -1356,6 +1356,7 @@ static int intel_pinctrl_add_padgroups_by_gpps(struct intel_pinctrl *pctrl, gpps[i].gpio_base =0 ;break ;case INTEL_GPIO_BASE_NOMAP : +break ;default :break ; }
@@ -1392,6 +1393,7 @@ static int intel_pinctrl_add_padgroups_by_size(struct intel_pinctrl *pctrl, gpps[i].size =min (gpp_size, npins); npins -= gpps[i].size; + gpps[i].gpio_base = gpps[i].base; gpps[i].padown_num = padown_num;/*
Signature · 1 line
2.30.1
Quoted 11 lines · Andy Shevchenko
During the split of
intel_pinctrl_add_padgroups(), the_by_size()variant missed the GPIO base calculations and hence made unable to retrieve proper GPIO number.Assign the
gpio_baseexplicitly in_by_size()variant.While at it, differentiate NOMAP case with the rest in
_by_gpps()variant.Fixes 036e126c72eb ("pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance")Reported-and-tested-by Maximilian Luz <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
I think this needs stable tag too.
Acked-by Mika Westerberg <[email protected]>