Skip to contentSkip to conversation

AM64: Add SERDES DT bindings

PATCH In review Kishon Vijay Abraham I 4 participants 8 messages Mar 10, 2021 – Mar 17, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover AM64: Add SERDES DT bindings

Patch series adds device tree bindings to support SERDES in AM64 platform.

This is split from [1] since this binding is also required for AM64 USB DT patches to be merged.

Vinod,

Once the 1st patch of the series is reviewed by Rob, can you merge and prepare a immutable tag to be used by Nishant Menon so that he can merge USB3 DT patches.

Changes from [1]:
*) Reverted back to adding compatible under enum.

[1] -> http://lore.kernel.org/r/[email protected]

Kishon Vijay Abraham I (3):
dt-bindings: phy: ti,phy-j721e-wiz: Add bindings for AM64 SERDES
Wrapper
dt-bindings: phy: cadence-torrent: Add binding for refclk driver
dt-bindings: ti-serdes-mux: Add defines for AM64 SoC

 .../bindings/phy/phy-cadence-torrent.yaml     | 20 +++++++++++++++---
 .../bindings/phy/ti,phy-j721e-wiz.yaml        |  4 ++++
 include/dt-bindings/mux/ti-serdes.h           |  5 +++++
 include/dt-bindings/phy/phy-cadence-torrent.h |  2 ++
 include/dt-bindings/phy/phy-ti.h              | 21 +++++++++++++++++++
 5 files changed, 49 insertions(+), 3 deletions(-)
 create mode 100644 include/dt-bindings/phy/phy-ti.h
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 dt-bindings: phy: ti,phy-j721e-wiz: Add bindings for AM64 SERDES Wrapper

Add bindings for AM64 SERDES Wrapper.

---
 .../bindings/phy/ti,phy-j721e-wiz.yaml        |  4 ++++
 include/dt-bindings/phy/phy-ti.h              | 21 +++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 include/dt-bindings/phy/phy-ti.h
Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml +4 -0
index bbbd85501ada..57e1d013a502 100644
@@ -15,6 +15,7 @@ properties:
     enum:
       - ti,j721e-wiz-16g
       - ti,j721e-wiz-10g
+      - ti,am64-wiz-10g
 
   power-domains:
     maxItems: 1
@@ -42,6 +43,9 @@ properties:
   "#reset-cells":
     const: 1
 
+  "#clock-cells":
+    const: 1
+
   ranges: true
 
   assigned-clocks:
include/dt-bindings/phy/phy-ti.h new file +21 -0
new file mode 100644
index 000000000000..ad955d3a56b4
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * This header provides constants for TI SERDES.
+ */
+
+#ifndef _DT_BINDINGS_TI_SERDES
+#define _DT_BINDINGS_TI_SERDES
+
+/* Clock index for output clocks from WIZ */
+
+/* MUX Clocks */
+#define TI_WIZ_PLL0_REFCLK	0
+#define TI_WIZ_PLL1_REFCLK	1
+#define TI_WIZ_REFCLK_DIG	2
+
+/* Reserve index here for future additions */
+
+/* MISC Clocks */
+#define TI_WIZ_PHY_EN_REFCLK	16
+
+#endif /* _DT_BINDINGS_TI_SERDES */
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] dt-bindings: phy: ti,phy-j721e-wiz: Add bindings for AM64 SERDES Wrapper

Quoted 9 lines · Kishon Vijay Abraham I

Add bindings for AM64 SERDES Wrapper.

---
 .../bindings/phy/ti,phy-j721e-wiz.yaml        |  4 ++++
 include/dt-bindings/phy/phy-ti.h              | 21 +++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 include/dt-bindings/phy/phy-ti.h
#3 lore raw

PATCH 2/3 dt-bindings: phy: cadence-torrent: Add binding for refclk driver

In reply to Kishon Vijay Abraham I

Add binding for refclk driver used to route the refclk out of torrent SERDES.

---
 .../bindings/phy/phy-cadence-torrent.yaml     | 20 ++++++++++++++++---
 include/dt-bindings/phy/phy-cadence-torrent.h |  2 ++
 2 files changed, 19 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml +17 -3
index e266ade53d87..4608599a31d8 100644
@@ -28,13 +28,27 @@ properties:
   '#size-cells':
     const: 0
 
+  '#clock-cells':
+    const: 1
+
   clocks:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
     description:
-      PHY reference clock. Must contain an entry in clock-names.
+      PHY reference clock for 1 item. Must contain an entry in clock-names.
+      Optional Parent to enable output reference clock.
 
   clock-names:
-    const: refclk
+    minItems: 1
+    items:
+      - const: refclk
+      - const: phy_en_refclk
+
+  assigned-clocks:
+    maxItems: 3
+
+  assigned-clock-parents:
+    maxItems: 3
 
   reg:
     minItems: 1
include/dt-bindings/phy/phy-cadence-torrent.h +2 -0
index e387b6a95741..3c92c6192493 100644
@@ -10,4 +10,6 @@
 #define TORRENT_SERDES_EXTERNAL_SSC	1
 #define TORRENT_SERDES_INTERNAL_SSC	2
 
+#define CDNS_TORRENT_REFCLK_DRIVER      0
+
 #endif /* _DT_BINDINGS_TORRENT_SERDES_H */
Signature · 1 line
2.17.1
#4 lore raw

PATCH 3/3 dt-bindings: ti-serdes-mux: Add defines for AM64 SoC

In reply to Kishon Vijay Abraham I

AM64 has a single lane SERDES which can be configured to be used with either PCIe or USB. Define the possilbe values for the SERDES function in AM64 SoC here.

---
 include/dt-bindings/mux/ti-serdes.h | 5 +++++
 1 file changed, 5 insertions(+)
include/dt-bindings/mux/ti-serdes.h +5 -0
index 9047ec6bd3cf..d417b9268b16 100644
@@ -90,4 +90,9 @@
 #define J7200_SERDES0_LANE3_USB			0x2
 #define J7200_SERDES0_LANE3_IP4_UNUSED		0x3
 
+/* AM64 */
+
+#define AM64_SERDES0_LANE0_PCIE0		0x0
+#define AM64_SERDES0_LANE0_USB			0x1
+
 #endif /* _DT_BINDINGS_MUX_TI_SERDES */
Signature · 1 line
2.17.1
#5 lore raw
In reply to Kishon Vijay Abraham I

Hi Vinod,

Quoted 11 lines · Kishon Vijay Abraham I

Patch series adds device tree bindings to support SERDES in AM64 platform.

This is split from [1] since this binding is also required for AM64 USB DT patches to be merged.

Vinod,

Once the 1st patch of the series is reviewed by Rob, can you merge and prepare a immutable tag to be used by Nishant Menon so that he can merge USB3 DT patches.

Now that Rob has Acked the 1st patch, can you prepare an immutable tag for Nishant Menon on this series.

AM64 SERDES driver changes [1] can also be merged after this.

Thank You
Kishon

[1] -> http://lore.kernel.org/r/[email protected]

Quoted 20 lines

Changes from [1]:
*) Reverted back to adding compatible under enum.

[1] -> http://lore.kernel.org/r/[email protected]

Kishon Vijay Abraham I (3):
dt-bindings: phy: ti,phy-j721e-wiz: Add bindings for AM64 SERDES
Wrapper
dt-bindings: phy: cadence-torrent: Add binding for refclk driver
dt-bindings: ti-serdes-mux: Add defines for AM64 SoC

 .../bindings/phy/phy-cadence-torrent.yaml     | 20 +++++++++++++++---
 .../bindings/phy/ti,phy-j721e-wiz.yaml        |  4 ++++
 include/dt-bindings/mux/ti-serdes.h           |  5 +++++
 include/dt-bindings/phy/phy-cadence-torrent.h |  2 ++
 include/dt-bindings/phy/phy-ti.h              | 21 +++++++++++++++++++
 5 files changed, 49 insertions(+), 3 deletions(-)
 create mode 100644 include/dt-bindings/phy/phy-ti.h
maintainer
#6 lore raw
In reply to Kishon Vijay Abraham I
Quoted 11 lines · Kishon Vijay Abraham I

Patch series adds device tree bindings to support SERDES in AM64 platform.

This is split from [1] since this binding is also required for AM64 USB DT patches to be merged.

Vinod,

Once the 1st patch of the series is reviewed by Rob, can you merge and prepare a immutable tag to be used by Nishant Menon so that he can merge USB3 DT patches.

Applied and tag:

git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/ti-serdes-for-5.13

Signature · 1 line
~Vinod
#7 lore raw
Quoted 9 lines · Vinod Koul
Quoted 8 lines · Kishon Vijay Abraham I

Patch series adds device tree bindings to support SERDES in AM64 platform.

This is split from [1] since this binding is also required for AM64 USB DT patches to be merged.

Vinod,

Quoted 8 lines
Quoted 3 lines

Once the 1st patch of the series is reviewed by Rob, can you merge and prepare a immutable tag to be used by Nishant Menon so that he can merge USB3 DT patches.

Applied and tag:

git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/ti-serdes-for-5.13

Thanks Vinod. Much appreciated.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D