Skip to contentSkip to conversation

i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition

PATCH Applied Rafael J. Wysocki 3 participants 5 messages Mar 5, 2021 – Mar 18, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition

From: Rafael J. Wysocki <[email protected]>

The ACPI_MODULE_NAME() definition is only used by the message printing macros from ACPICA that are not used by the code in question, so it is redundant. Drop it.

No functional impact.

---
 drivers/i2c/busses/i2c-scmi.c |    2 --
 1 file changed, 2 deletions(-)
drivers/i2c/busses/i2c-scmi.c +0 -2
Index: linux-pm/drivers/i2c/busses/i2c-scmi.c
===================================================================
@@ -18,8 +18,6 @@
 /* SMBUS HID definition as supported by Microsoft Windows */
 #define ACPI_SMBUS_MS_HID		"SMB0001"
 
-ACPI_MODULE_NAME("smbus_cmi");
-
 struct smbus_methods_t {
 	char *mt_info;
 	char *mt_sbr;
#1 lore raw
Quoted 10 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The ACPI_MODULE_NAME() definition is only used by the message printing macros from ACPICA that are not used by the code in question, so it is redundant. Drop it.

No functional impact.

If there are no concerns regarding this, I'll queue it up for 5.13 in the ACPI tree, thanks!

Quoted 20 lines
---
 drivers/i2c/busses/i2c-scmi.c |    2 --
 1 file changed, 2 deletions(-)

Index: linux-pm/drivers/i2c/busses/i2c-scmi.c
===================================================================

drivers/i2c/busses/i2c-scmi.c +0 -2
@@ -18,8 +18,6 @@
 /* SMBUS HID definition as supported by Microsoft Windows */
 #define ACPI_SMBUS_MS_HID              "SMB0001"
 
-ACPI_MODULE_NAME("smbus_cmi");
-
 struct smbus_methods_t {
        char *mt_info;
        char *mt_sbr;
#2 lore raw
Quoted 8 lines · Rafael J. Wysocki
Quoted 7 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The ACPI_MODULE_NAME() definition is only used by the message printing macros from ACPICA that are not used by the code in question, so it is redundant. Drop it.

Quoted 6 lines
Quoted 3 lines

No functional impact.

If there are no concerns regarding this, I'll queue it up for 5.13 in the ACPI tree, thanks!

I'd prefer the I2C tree a tad to avoid conflicts. Any reason for the ACPI tree?

#3 lore raw
Quoted 12 lines · Wolfram Sang
Quoted 10 lines · Rafael J. Wysocki
Quoted 9 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The ACPI_MODULE_NAME() definition is only used by the message printing macros from ACPICA that are not used by the code in question, so it is redundant. Drop it.

No functional impact.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

If there are no concerns regarding this, I'll queue it up for 5.13 in the ACPI tree, thanks!

I'd prefer the I2C tree a tad to avoid conflicts. Any reason for the ACPI tree?

There are some patches doing this type of a cleanup in the ACPI tree, but this is the only reason, so please route it through the i2c tree if that is preferred.