scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
Subsystems (3)
Bodo Stroesser
maintainerPATCH 1/1 scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
In patch
"scsi: target: tcmu: Replace radix_tree with XArray"
meaning of last parameter of tcmu_blocks_release was changed. So in the callers we should subtract 1 from the previous parameter.
Unfortunately that change got lost at one of the two places where tcmu_blocks_release is called. That does not lead to any problems, but we should adjust it anyway.
--- drivers/target/target_core_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/target/target_core_user.c +1 -1
@@ -1658,7 +1658,7 @@ static void tcmu_dev_kref_release(struct kref *kref)xa_destroy (&udev->commands);WARN_ON (!all_expired); -tcmu_blocks_release (&udev->data_blocks,0 , udev->dbi_max +1 ); +tcmu_blocks_release (&udev->data_blocks,0 , udev->dbi_max);bitmap_free (udev->data_bitmap);mutex_unlock (&udev->cmdr_lock);
Signature · 1 line
2.12.3
Martin K. Petersen
AppliedBodo,
Quoted 3 lines
In patch "scsi: target: tcmu: Replace
radix_treewith XArray" meaning of last parameter oftcmu_blocks_releasewas changed. So in the callers we should subtract 1 from the previous parameter.
Applied to 5.13/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 9 lines · Bodo Stroesser
In patch
"scsi: target: tcmu: Replaceradix_treewith XArray"
meaning of last parameter oftcmu_blocks_releasewas changed. So in the callers we should subtract 1 from the previous parameter.Unfortunately that change got lost at one of the two places where
tcmu_blocks_releaseis called. That does not lead to any problems, but we should adjust it anyway.
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
https://git.kernel.org/mkp/scsi/c/471ee95ccca9
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering