drivers: spi: cadence: set cqspi to the driver_data field of struct device
PATCH 1/1 drivers: spi: cadence: set cqspi to the driver_data field of struct device
From: Meng Li <[email protected]>
When initialize cadence qspi controller, it is need to set cqspi to the driver_data field of struct device, because it will be used in function cqspi_remove/suspend/resume(). Otherwise, there will be a crash trace as below when invoking these finctions.
Call trace: cqspi_suspend+0x14/0x44 dpm_run_callback+0x50/0x1c0 __device_suspend+0x114/0x514 ...... el0_svc+0x20/0x30 el0_sync_handler+0x1a4/0x1b0 el0_sync+0x174/0x180
--- drivers/spi/spi-cadence-quadspi.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spi-cadence-quadspi.c +1 -0
@@ -1198,6 +1198,7 @@ static int cqspi_probe(struct platform_device *pdev) cqspi =spi_master_get_devdata (master); cqspi->pdev = pdev; +platform_set_drvdata (pdev, cqspi);/* Obtain configuration from OF. */ ret =cqspi_of_get_pdata (cqspi);
Signature · 1 line
2.17.1
Mark Brown
maintainerQuoted 10 lines · On Thu, Mar 11, 2021 at 05:12:20PM +0800, [email protected] wrote:
From: Meng Li <[email protected]>
When initialize cadence qspi controller, it is need to set cqspi to the
driver_datafield of struct device, because it will be used in function cqspi_remove/suspend/resume(). Otherwise, there will be a crash trace as below when invoking these finctions.Call trace: cqspi_suspend+0x14/0x44 dpm_run_callback+0x50/0x1c0 __device_suspend+0x114/0x514
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Mark Brown
maintainerQuoted 1 line · On Thu, Mar 11, 2021 at 05:12:20PM +0800, [email protected] wrote:
Fixes 31fb632b5d43("spi: Move cadence-quadspi driver to drivers/spi/")
Commit: 5e838bc8035a ("spi: cadence: set cqspi to the driver_data field of struct device")
Fixes tag: Fixes: 31fb632b5d43("spi: Move cadence-quadspi driver to drivers/spi/") Has these problem(s):
- missing space between the SHA1 and the subject
Thanks for reminding me these issues, and I will pay attention that when I submit patch next time. Do I need to submit v2 patch to fix this issue?
Thanks,
Limeng
Quoted 20 lines
-----Original Message-----
From: Mark Brown <[email protected]>
Sent: Thursday, March 11, 2021 9:26 PM
To: Li, Meng <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH] drivers: spi: cadence: set cqspi to thedriver_datafield of struct deviceQuoted 1 line · On Thu, Mar 11, 2021 at 05:12:20PM +0800, [email protected] wrote:
Fixes 31fb632b5d43("spi: Move cadence-quadspi driver to drivers/spi/")Commit:
5e838bc8035a("spi: cadence: set cqspi to thedriver_datafield of struct device")
Fixes tag: Fixes: 31fb632b5d43("spi: Move cadence-quadspi driver todrivers/spi/")
Has these problem(s):
- missing space between the SHA1 and the subject
Mark Brown
maintainerQuoted 2 lines · Meng
Thanks for reminding me these issues, and I will pay attention that when I submit patch next time. Do I need to submit v2 patch to fix this issue?
No.
Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
Mark Brown
maintainerQuoted 4 lines · On Thu, 11 Mar 2021 17:12:20 +0800, [email protected] wrote:
When initialize cadence qspi controller, it is need to set cqspi to the
driver_datafield of struct device, because it will be used in function cqspi_remove/suspend/resume(). Otherwise, there will be a crash trace as below when invoking these finctions.
Quoted 8 lines
Call trace: cqspi_suspend+0x14/0x44 dpm_run_callback+0x50/0x1c0 __device_suspend+0x114/0x514 ...... el0_svc+0x20/0x30 el0_sync_handler+0x1a4/0x1b0 el0_sync+0x174/0x180
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] drivers: spi: cadence: set cqspi to the driver_data field of struct device
commit: ea94191e584b146878f0b7fd4b767500d7aae870
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark