Skip to contentSkip to conversation

mmc: sdhci-pci: Avoid comma separated statements

PATCH In review Jisheng Zhang 3 participants 3 messages Mar 11, 2021

Subsystems (2)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver
lore
Share & tools
lore

Jisheng Zhang

author
#0 lore raw

PATCH 1/1 mmc: sdhci-pci: Avoid comma separated statements

Use semicolons.

Signed-off-by Jisheng Zhang <[email protected]>
---
 drivers/mmc/host/sdhci-pci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +1 -1
index 9552708846ca..62799c1d9c0c 100644
@@ -958,7 +958,7 @@ static int glk_emmc_probe_slot(struct sdhci_pci_slot *slot)
 		slot->host->mmc->caps2 |= MMC_CAP2_CQE;
 
 	if (slot->chip->pdev->device != PCI_DEVICE_ID_INTEL_GLK_EMMC) {
-		slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES,
+		slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES;
 		slot->host->mmc_host_ops.hs400_enhanced_strobe =
 						intel_hs400_enhanced_strobe;
 		slot->host->mmc->caps2 |= MMC_CAP2_CQE_DCMD;
Signature · 1 line
2.30.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Jisheng Zhang

Use semicolons.

Signed-off-by Jisheng Zhang <[email protected]>
Acked-by Adrian Hunter <[email protected]>
Quoted 18 lines
---
 drivers/mmc/host/sdhci-pci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +1 -1
index 9552708846ca..62799c1d9c0c 100644
@@ -958,7 +958,7 @@ static int glk_emmc_probe_slot(struct sdhci_pci_slot *slot)
 		slot->host->mmc->caps2 |= MMC_CAP2_CQE;
 
 	if (slot->chip->pdev->device != PCI_DEVICE_ID_INTEL_GLK_EMMC) {
-		slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES,
+		slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES;
 		slot->host->mmc_host_ops.hs400_enhanced_strobe =
 						intel_hs400_enhanced_strobe;
 		slot->host->mmc->caps2 |= MMC_CAP2_CQE_DCMD;
#2 lore raw
In reply to Jisheng Zhang
Quoted 4 lines · Jisheng Zhang

Use semicolons.

Signed-off-by Jisheng Zhang <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/sdhci-pci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +1 -2
index 9552708846ca..62799c1d9c0c 100644
@@ -958,7 +958,7 @@ static int glk_emmc_probe_slot(struct sdhci_pci_slot *slot)
                slot->host->mmc->caps2 |= MMC_CAP2_CQE;
 
        if (slot->chip->pdev->device != PCI_DEVICE_ID_INTEL_GLK_EMMC) {
-               slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES,
+               slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES;
                slot->host->mmc_host_ops.hs400_enhanced_strobe =
                                                intel_hs400_enhanced_strobe;
                slot->host->mmc->caps2 |= MMC_CAP2_CQE_DCMD;
--

2.30.2