arm64: configs: Enable PCIe support for imx8mq boards
PATCH v2 1/1 arm64: configs: Enable PCIe support for imx8mq boards
Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk, imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra.
---
v2:
- slightly modified the commit message (Fabio Estevam)
arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_BRCMSTB=m +CONFIG_PCI_IMX6=y CONFIG_PCI_LAYERSCAPE=y CONFIG_PCIE_LAYERSCAPE_GEN4=y CONFIG_PCI_HISI=y
Signature · 1 line
2.30.0
Quoted 16 lines · Heiko Thiery
Enable
PCI_IMX6to get PCI support for imx8mq boards like imx8mq-evk, imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra.Signed-off-by Heiko Thiery <[email protected]>---
v2:
- slightly modified the commit message (Fabio Estevam)arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm64/configs/defconfig +0
-0
arch/arm64/configs/defconfig CONFIG_PCI_HOST_THUNDER_PEM=y · line 228
Quoted 4 lines
arch/arm64/configs/defconfig +1
-0@@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_BRCMSTB=m +CONFIG_PCI_IMX6=y
Do we really want it to be built-in? If so, it would be nice to have some comments about that in commit log.
Shawn
Quoted 6 lines
arch/arm64/configs/defconfig +0
-0CONFIG_PCI_LAYERSCAPE=y CONFIG_PCIE_LAYERSCAPE_GEN4=y CONFIG_PCI_HISI=ySignature · 1 line
2.30.0
Hi Shawn,
Am Mi., 17. März 2021 um 09:02 Uhr schrieb Shawn Guo <[email protected]>:
Quoted 13 lines · Heiko Thiery
Quoted 11 lines
Enable
PCI_IMX6to get PCI support for imx8mq boards like imx8mq-evk, imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra.Signed-off-by Heiko Thiery <[email protected]>---
v2:
- slightly modified the commit message (Fabio Estevam)arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
arch/arm64/configs/defconfig CONFIG_PCI_HOST_THUNDER_PEM=y · line 228
Quoted 9 lines
arch/arm64/configs/defconfig +1
-0@@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_BRCMSTB=m +CONFIG_PCI_IMX6=yDo we really want it to be built-in? If so, it would be nice to have some comments about that in commit log.
Why would you not want it? I see other SOC PCI controllers are also enabled. I would like to have it because we have an Intel e1000 on our pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we would have the PCI support with the default defconfig. On the NXP imx8mq EVK a m.2 is connected to the PCI interface.
Is this the kind of comments you want?
Quoted 8 lines
Shawn
Quoted 6 lines
arch/arm64/configs/defconfig +0
-1CONFIG_PCI_LAYERSCAPE=y CONFIG_PCIE_LAYERSCAPE_GEN4=y CONFIG_PCI_HISI=y --2.30.0
BR
Signature · 3 lines
Heiko -- Heiko
Hi Shawn,
Am Mi., 17. März 2021 um 12:52 Uhr schrieb Heiko Thiery <[email protected]>:
Quoted 29 lines
Hi Shawn,
Am Mi., 17. März 2021 um 09:02 Uhr schrieb Shawn Guo <[email protected]>:
Quoted 25 lines · Heiko Thiery
Quoted 16 lines
Enable
PCI_IMX6to get PCI support for imx8mq boards like imx8mq-evk, imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra.Signed-off-by Heiko Thiery <[email protected]>---
v2:
- slightly modified the commit message (Fabio Estevam)arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm64/configs/defconfig +0
-0arch/arm64/configs/defconfig CONFIG_PCI_HOST_THUNDER_PEM=y · line 228
Quoted 4 lines
arch/arm64/configs/defconfig +1
-0@@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_BRCMSTB=m +CONFIG_PCI_IMX6=yDo we really want it to be built-in? If so, it would be nice to have some comments about that in commit log.
Or do you mean why it cannot be enabled as a module? The PCI_IMX6 driver is only a bool option in the Kconfig and cannot be built as a module. So it is required to have it built-in.
Quoted 23 lines
Why would you not want it? I see other SOC PCI controllers are also enabled. I would like to have it because we have an Intel e1000 on our pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we would have the PCI support with the default defconfig. On the NXP imx8mq EVK a m.2 is connected to the PCI interface.
Is this the kind of comments you want?
Quoted 8 lines
Shawn
Quoted 6 lines
arch/arm64/configs/defconfig +0
-1CONFIG_PCI_LAYERSCAPE=y CONFIG_PCIE_LAYERSCAPE_GEN4=y CONFIG_PCI_HISI=y --2.30.0
BR
--
Heiko
--
Heiko
Hi Heiko,
Quoted 10 lines · Heiko Thiery
Quoted 2 lines
Do we really want it to be built-in? If so, it would be nice to have some comments about that in commit log.
Why would you not want it? I see other SOC PCI controllers are also enabled. I would like to have it because we have an Intel e1000 on our pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we would have the PCI support with the default defconfig. On the NXP imx8mq EVK a m.2 is connected to the PCI interface.
Is this the kind of comments you want?
You have selected the driver to be built-in:CONFIG_PCI_IMX6=y
Shawn's question is why it needs to be built-in instead of a kernel module:
CONFIG_PCI_IMX6=m
On arch/arm64/configs/defconfig the preference is to select the options as modules, whenever possible.
If it can't be a module and needs to be built-in, then please provide a justification in the commit log.
Hope this can clarify.