Skip to contentSkip to conversation

staging: vt665x: fix alignment constraints

PATCH In review Edmundo Carmona Antoranz 3 participants 5 messages Mar 12, 2021 – Mar 16, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: vt665x: fix alignment constraints

Removing 2 instances of alignment warnings

drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’ is less than 2 [-Wpacked-not-aligned] drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘struct vnt_cts_fb’ is less than 2 [-Wpacked-not-aligned]

The root cause seems to be that _because_ struct ieee80211_cts is marked as __aligned(2), this requires any encapsulating struct to also have an alignment of 2.

Fixes 2faf12c57efe ("staging: vt665x: fix alignment constraints")
---
 drivers/staging/vt6655/rxtx.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vt6655/rxtx.h +2 -2
index e7061d383306..c3c2c1566882 100644
@@ -150,7 +150,7 @@ struct vnt_cts {
 	u16 reserved;
 	struct ieee80211_cts data;
 	u16 reserved2;
-} __packed;
+} __packed __aligned(2);
 
 struct vnt_cts_fb {
 	struct vnt_phy_field b;
@@ -160,7 +160,7 @@ struct vnt_cts_fb {
 	__le16 cts_duration_ba_f1;
 	struct ieee80211_cts data;
 	u16 reserved2;
-} __packed;
+} __packed __aligned(2);
 
 struct vnt_tx_fifo_head {
 	u8 tx_key[WLAN_KEY_LEN_CCMP];
Signature · 1 line
2.30.1
#1 lore raw
Quoted 1 line · Edmundo Carmona Antoranz

I wonder if this patch will be picked up if I don't include Greg in the conversation. Should I send the patch again looping him in?

Quoted 3 lines

--
2.30.1

#2 lore raw
Quoted 6 lines · Edmundo Carmona Antoranz
Quoted 1 line · Edmundo Carmona Antoranz

I wonder if this patch will be picked up if I don't include Greg in the conversation. Should I send the patch again looping him in?

Whoever is the maintainer for the driver should be included.

julia

#3 lore raw
Quoted 2 lines · Julia Lawall

Whoever is the maintainer for the driver should be included.

Right. Will send a v3 patch with him included. Thanks!

Quoted 2 lines

julia

#4 lore raw
In reply to Edmundo Carmona Antoranz
Quoted 7 lines · Edmundo Carmona Antoranz
Quoted 1 line · Edmundo Carmona Antoranz

I wonder if this patch will be picked up if I don't include Greg in the conversation. Should I send the patch again looping him in?

Yes. And you need to include the driver-devel mailing list from get_maintainer.pl. You can leave lkml out if you want.

regards,
dan carpenter