leds: lgm: fix gpiolib dependency
PATCH 1/1 leds: lgm: fix gpiolib dependency
From: Arnd Bergmann <[email protected]>
Without gpiolib, the driver fails to build:
drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
struct gpio_chip chip;
^
include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
struct gpio_chip;
^
drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
gpiod_set_value(led->gpiod, val);
^
drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
static inline void gpio_set_value(unsigned gpio, int value)
^
drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
gpiod_set_value(led->gpiod, 1);
^Add the dependency in Kconfig.
--- drivers/leds/blink/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/leds/blink/Kconfig +1 -0
@@ -9,6 +9,7 @@ if LEDS_BLINK config LEDS_BLINK_LGM tristate "LED support for Intel LGM SoC series" + depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON depends on OF
Signature · 1 line
2.29.2
Pavel Machek
AppliedIntel, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Hi!
Quoted 7 lines
From: Arnd Bergmann <[email protected]>
Without gpiolib, the driver fails to build:
drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' struct gpio_chip chip; ^
Thanks, applied.
I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek
Re: Intel, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Hi!
Quoted 4 lines
Quoted 4 lines
From: Arnd Bergmann <[email protected]>
Without gpiolib, the driver fails to build:
Quoted 8 lines
Quoted 3 lines
drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' struct gpio_chip chip; ^Thanks, applied.
I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away.
The following message to <[email protected]> was undeliverable.
The reason for the problem:
5.1.0 - Unknown address error 550-'5.1.1 <[email protected]>: Recipient +address rejected: User unknown in virtual mailbox table'
commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <[email protected]>
If someone knows how to contact the author, that would be welcome.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek
MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Quoted 11 lines · Pavel Machek
Quoted 2 lines
I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away.
The following message to <[email protected]> was undeliverable.
<[email protected]>: Recipient +address rejected: User unknown in virtual mailbox table'
commit
c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <[email protected]>
I asked around, and got told Mallikarjuna has been "sold" to MaxLinear, together with the rest of the Connected Home Division. So he most likely still works on this stuff, just under a different banner.
Quoted 1 line
If someone knows how to contact the author, that would be welcome.
Alas, no idea about his MaxLinear address.
Meow!
Signature · 4 lines
⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ in the beginning was the boot and root floppies and they were good. ⢿⡄⠘⠷⠚⠋⠀ -- <willmore> on #linux-sunxi ⠈⠳⣄⠀⠀⠀⠀
Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Hi!
Quoted 12 lines
Quoted 11 lines
Quoted 2 lines
I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away.
The following message to <[email protected]> was undeliverable.
<[email protected]>: Recipient +address rejected: User unknown in virtual mailbox table'
commit
c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <[email protected]>
Quoted 7 lines
I asked around, and got told Mallikarjuna has been "sold" to MaxLinear, together with the rest of the Connected Home Division. So he most likely still works on this stuff, just under a different banner.
Quoted 1 line
If someone knows how to contact the author, that would be welcome.
Alas, no idea about his MaxLinear address.
Thanks for the effort. Anyway, I suspect I'll just do this:
BR,
Pavel
drivers/leds/blink/Kconfig +1 -11
@@ -1,14 +1,6 @@ -menuconfig LEDS_BLINK - bool "LED Blink support" - depends on LEDS_CLASS - help - This option enables blink support for the leds class. - If unsure, say Y. - -if LEDS_BLINK - config LEDS_BLINK_LGM tristate "LED support for Intel LGM SoC series" + depends on BROKEN depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON
@@ -17,5 +9,3 @@ config LEDS_BLINK_LGM Parallel to serial conversion, which is also called SSO controller, can drive external shift register for LED outputs. This enables LED support for Serial Shift Output controller(SSO). - -endif # LEDS_BLINK
Signature · 1 line
http://www.livejournal.com/~pavelmachek
Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Quoted 19 lines · Pavel Machek
Hi!
Quoted 16 lines
Quoted 11 lines
Quoted 2 lines
I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away.
The following message to <[email protected]> was undeliverable.
<[email protected]>: Recipient +address rejected: User unknown in virtual mailbox table'
commit
c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <[email protected]>I asked around, and got told Mallikarjuna has been "sold" to MaxLinear, together with the rest of the Connected Home Division. So he most likely still works on this stuff, just under a different banner.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
If someone knows how to contact the author, that would be welcome.
Alas, no idea about his MaxLinear address.
Thanks for the effort. Anyway, I suspect I'll just do this:
Maybe Hauke or John (added both to cc) know who at MaxLinear is responsible for maintaining the Lightning Mountain drivers now.
Arnd
Quoted 30 lines
drivers/leds/blink/Kconfig +1
-12@@ -1,14 +1,6 @@ -menuconfig LEDS_BLINK - bool "LED Blink support" - depends on LEDS_CLASS - help - This option enables blink support for the leds class. - If unsure, say Y. - -if LEDS_BLINK - config LEDS_BLINK_LGM tristate "LED support for Intel LGM SoC series" + depends on BROKEN depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON@@ -17,5 +9,3 @@ config LEDS_BLINK_LGM Parallel to serial conversion, which is also called SSO controller, can drive external shift register for LED outputs. This enables LED support for Serial Shift Output controller(SSO). - -endif # LEDS_BLINK --
Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Quoted 22 lines · Arnd Bergmann
Quoted 21 lines · Pavel Machek
Hi!
Quoted 18 lines
Quoted 11 lines
Quoted 2 lines
I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away.
The following message to <[email protected]> was undeliverable.
<[email protected]>: Recipient +address rejected: User unknown in virtual mailbox table'
commit
c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <[email protected]>I asked around, and got told Mallikarjuna has been "sold" to MaxLinear, together with the rest of the Connected Home Division. So he most likely still works on this stuff, just under a different banner.
Quoted 1 line
If someone knows how to contact the author, that would be welcome.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Alas, no idea about his MaxLinear address.
Thanks for the effort. Anyway, I suspect I'll just do this:
Maybe Hauke or John (added both to cc) know who at MaxLinear is responsible for maintaining the Lightning Mountain drivers now.
Arnd
Hi Qiming,
It looks like there are some problems and potential fixes for the led driver Mallikarjuna added to the Linux kernel for LGM some time ago.
Could you please take care of this request from Pavel and Arnd.
Hauke
Quoted 31 lines
Quoted 31 lines
drivers/leds/blink/Kconfig +1
-12@@ -1,14 +1,6 @@ -menuconfig LEDS_BLINK - bool "LED Blink support" - depends on LEDS_CLASS - help - This option enables blink support for the leds class. - If unsure, say Y. - -if LEDS_BLINK - config LEDS_BLINK_LGM tristate "LED support for Intel LGM SoC series" + depends on BROKEN depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON@@ -17,5 +9,3 @@ config LEDS_BLINK_LGM Parallel to serial conversion, which is also called SSO controller, can drive external shift register for LED outputs. This enables LED support for Serial Shift Output controller(SSO). - -endif # LEDS_BLINK --
A message that is not in the archive (sent off-list or not yet received): MN2PR19MB3486B88ADF5BE557BEE168AEAF909@MN2PR19MB3486.namprd19.prod.outlook.com
A message that is not in the archive (sent off-list or not yet received): MW2PR1901MB2187816296E1B03F91EB972BD0909@MW2PR1901MB2187.namprd19.prod.outlook.com
A message that is not in the archive (sent off-list or not yet received): MN2PR19MB3693B7620DABED199AA304B5B1909@MN2PR19MB3693.namprd19.prod.outlook.com
Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Quoted 7 lines · Rahul Tanwar
Hi Arnd, Pavel,
Sorry for the hiccup due to missing email address in the email chain during the ownership transition.
Henceforth, I will be the maintainer for all kernel
drivers/coderelated to “formerly Intel’s now MaxLinear’s” Lightning Mountain SoC.Please send any Lightning Mountain SoC related issues email to Rahul Tanwar ([email protected]) and I will ensure that I address the issues in a timely manner.
Thank you for the reply and for stepping up as maintainer.
I tend to merge updates to the MAINTAINERS file as bugfixes the file contains the correct addresses at all times. If you sent an update for this to [email protected],
I'll get that merged.
Since I think this is an x86 platform, you can alternatively send the same patch to the x86 maintainers.
Are you also planning to maintain or add drivers for some of the older SoC generations from Ti/Lantiq/Infineon/Intel that are now owned by MaxLinear? It would be good to be explicit about which ones of these you are working with. From what I can tell, the arch/mips/lantiq/ platform is only for fairly old designs (xrx200 and older), while support for the slightly later mips and x86 based chips was submitted a few years ago but never merged.
Quoted 1 line
I will wait for more details on your fix request for LGM LED driver. Thanks.
From my side, only an Ack on the original bugfix I sent [1] is needed, but Pavel had other concerns about the driver. I expect he will follow up on those with you.
Arnd
Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
Hi Arnd,
Quoted 23 lines · Arnd Bergmann
This email was sent from outside of MaxLinear.
Quoted 3 lines · Rahul Tanwar
Hi Arnd, Pavel,
Sorry for the hiccup due to missing email address in the email chain
during the ownership transition.
Quoted 2 lines
Henceforth, I will be the maintainer for all kernel
drivers/coderelated to “formerly Intel’s now MaxLinear’s” Lightning Mountain SoC.
Quoted 2 lines
Please send any Lightning Mountain SoC related issues email to Rahul
Tanwar ([email protected]) and I will ensure that I address the issues in a timely manner.
Thank you for the reply and for stepping up as maintainer.
I tend to merge updates to the
MAINTAINERSfile as bugfixes the file contains
the correct addresses at all times. If you sent an update for this to [email protected],
I'll get that merged.
Quoted 4 lines
Since I think this is an x86 platform, you can alternatively send the same patch
to the x86 maintainers.
Haven't sent any patch to update MAINTAINERS file yet. Thanks for your suggestion. I will take it up soon..
Quoted 8 lines
Are you also planning to maintain or add drivers for some of the older SoC generations from Ti/Lantiq/Infineon/Intel that are now owned by MaxLinear? It would be good to be explicit about which ones of these you are working with. From what I can tell, the
arch/mips/lantiq/platform is only for fairly
old designs (xrx200 and older), while support for the slightly later mips and x86 based chips was submitted a few years ago but never merged.
Thank you for asking. At this point of time, our focus for upstreaming and maintaining is on LGM(Lightning Mountain) SoC.
Regards,
Rahul
Quoted 13 lines
Quoted 1 line
I will wait for more details on your fix request for LGM LED driver.
Thanks.
From my side, only an Ack on the original bugfix I sent [1] is needed, but
Pavel had other concerns about the driver. I expect he will follow up on those
with you.Arnd
[1]
https://lore.kernel.org/lkml/[email protected]/
<https://lore.kernel.org/lkml/[email protected]>
Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
In reply to a message not in the archiveHi!
Quoted 9 lines
Sorry for the hiccup due to missing email address in the email chain during the ownership transition.
Henceforth, I will be the maintainer for all kernel
drivers/coderelated to “formerly Intel’s now MaxLinear’s” Lightning Mountain SoC.Please send any Lightning Mountain SoC related issues email to Rahul Tanwar ([email protected]<mailto:[email protected]>) and I will ensure that I address the issues in a timely manner.
I will wait for more details on your fix request for LGM LED driver. Thanks.
Please review/Ack arnd's change.
Plus I'd like you to
1) remove LEDS_BLINK Kconfig symbol
2) provide useful Kconfig help text for your driver.
Thank you,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek