dt-bindings: power: bcm-pmb: add BCM63138 binding
PATCH 1/2 dt-bindings: power: bcm-pmb: add BCM63138 binding
From: Rafał Miłecki <[email protected]>
PMB can be also found on bcm63xx chipsets. It uses difference device addresses so a new binding is required.
--- Documentation/devicetree/bindings/power/brcm,bcm-pmb.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/power/brcm,bcm-pmb.yaml +1 -0
@@ -16,6 +16,7 @@ properties: compatible: enum: - brcm,bcm4908-pmb + - brcm,bcm63138-pmb reg: description: register space of one or more buses
Signature · 1 line
2.26.2
PATCH 2/2 soc: bcm: bcm-pmb: add BCM63138 SATA support
From: Rafał Miłecki <[email protected]>
BCM63138 has SATA controller that needs to be powered up using PMB.
---
Florian: this is based on your patches
ARM: dts: BCM63xx: enable SATA PHY and AHCI controller
reset: bcm63xx: Add Broadcom BCM63138 reset controller driver
I didn't test it as I don't own any bcm63xx devices.
--- drivers/soc/bcm/bcm63xx/bcm-pmb.c | 30 ++++++++++++++++++++++++++++++ include/dt-bindings/soc/bcm-pmb.h | 1 + 2 files changed, 31 insertions(+)
drivers/soc/bcm/bcm63xx/bcm-pmb.c +30 -0
@@ -209,6 +209,28 @@ static int bcm_pmb_power_on_device(struct bcm_pmb *pmb, int bus, u8 device)return err; } +static int bcm_pmb_power_on_sata (struct bcm_pmb *pmb,int bus,u8 device) +{ +int err; + + err =bcm_pmb_power_on_zone (pmb, bus, device,0 ); +if (err) +return err; + +/* Does not apply to the BCM963158 */ + err =bcm_pmb_bpcm_write (pmb, bus, device,BPCM_MISC_CONTROL ,0 ); +if (err) +return err; + + err =bcm_pmb_bpcm_write (pmb, bus, device,BPCM_SR_CONTROL ,0xffffffff ); +if (err) +return err; + + err =bcm_pmb_bpcm_write (pmb, bus, device,BPCM_SR_CONTROL ,0 ); + +return err; +} +static int bcm_pmb_power_on (struct generic_pm_domain *genpd) { struct bcm_pmb_pm_domain *pd = container_of(genpd, struct bcm_pmb_pm_domain, genpd);
@@ -222,6 +244,8 @@ static int bcm_pmb_power_on(struct generic_pm_domain *genpd)return bcm_pmb_power_on_zone (pmb, data->bus, data->device,0 );case BCM_PMB_HOST_USB :return bcm_pmb_power_on_device (pmb, data->bus, data->device); +case BCM_PMB_SATA : +return bcm_pmb_power_on_sata (pmb, data->bus, data->device);default :dev_err (pmb->dev,"unsupported device id: %d\n" , data->id);return -EINVAL ;
@@ -317,8 +341,14 @@ static const struct bcm_pmb_pd_data bcm_pmb_bcm4908_data[] = { { }, }; +static const struct bcm_pmb_pd_data bcm_pmb_bcm63138_data[] = { + { .name ="sata" , .id =BCM_PMB_SATA , .bus =0 , .device =3 , }, + { }, +}; +static const struct of_device_id bcm_pmb_of_match[] = { { .compatible ="brcm,bcm4908-pmb" , .data = &bcm_pmb_bcm4908_data, }, + { .compatible ="brcm,bcm63138-pmb" , .data = &bcm_pmb_bcm63138_data, }, { }, };
include/dt-bindings/soc/bcm-pmb.h +1 -0
@@ -7,5 +7,6 @@#define BCM_PMB_PCIE1 0x02#define BCM_PMB_PCIE2 0x03#define BCM_PMB_HOST_USB 0x04 +#define BCM_PMB_SATA 0x05#endif
Signature · 1 line
2.26.2
Florian Fainelli
AppliedRe: [PATCH Broadcom/stblinux 2/2] soc: bcm: bcm-pmb: add BCM63138 SATA support
Quoted 6 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
BCM63138 has SATA controller that needs to be powered up using PMB.
Signed-off-by Rafał Miłecki <[email protected]>---
Applied to drivers/next, thanks!
--
Florian
Quoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
PMB can be also found on bcm63xx chipsets. It uses difference device addresses so a new binding is required.
Signed-off-by Rafał Miłecki <[email protected]>--- Documentation/devicetree/bindings/power/brcm,bcm-pmb.yaml | 1 + 1 file changed, 1 insertion(+)
Florian Fainelli
AppliedQuoted 7 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
PMB can be also found on bcm63xx chipsets. It uses difference device addresses so a new binding is required.
Signed-off-by Rafał Miłecki <[email protected]>---
Applied to drivers/next, thanks!
--
Florian